Andreas/mtg_python_deckbuilder
1
0
Fork 0
mirror of https://github.com/mwisnowski/mtg_python_deckbuilder.git synced 2025-12-18 00:20:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: complete include/exclude observability, fix validation bugs, and organize tests

Browse source 
- Add structured logging for include/exclude operations with comprehensive event tracking
- Fix duplicate counting bug in validation API by eliminating double validation passes
- Simplify color identity validation UX by consolidating into single 'illegal' status
- Organize project structure by moving all test files to centralized code/tests/ directory
- Update documentation reflecting feature completion and production readiness
- Add validation test scripts and performance benchmarks confirming targets met
- Finalize include/exclude feature as production-ready with EDH format compliance
This commit is contained in:
matt 2025-09-09 20:18:03 -07:00
parent f77bce14cb
commit 3e4395d6e9
32 changed files with 470 additions and 89 deletions
Download patch file Download diff file Expand all files Collapse all files

68
code/web/templates/build/_new_deck_modal.html
View file

@ -506,14 +506,9 @@
badges += `<span style="background:#dcfce7; color:#166534; padding:2px 6px; border-radius:12px; border:1px solid #bbf7d0;">✓ ${includeData.legal.length} legal</span>`;
}
// Invalid cards badge
// Invalid cards badge (includes color mismatches and not found cards)
if (includeData.illegal && includeData.illegal.length > 0) {
badges += `<span style="background:#fee2e2; color:#dc2626; padding:2px 6px; border-radius:12px; border:1px solid #fecaca;">✗ ${includeData.illegal.length} invalid</span>`;
}
// Color mismatch badge
if (includeData.color_mismatched && includeData.color_mismatched.length > 0) {
badges += `<span style="background:#fef3c7; color:#92400e; padding:2px 6px; border-radius:12px; border:1px solid #fde68a;">⚠ ${includeData.color_mismatched.length} off-color</span>`;
badges += `<span style="background:#fee2e2; color:#dc2626; padding:2px 6px; border-radius:12px; border:1px solid #fecaca;">✗ ${includeData.illegal.length} illegal</span>`;
}
// Duplicates badge
@ -523,6 +518,62 @@
}
badgeContainer.innerHTML = badges;
// Update chip colors based on validation status
updateChipColors('include', includeData);
}
// Update chip colors based on validation status
function updateChipColors(type, validationData) {
if (!validationData) return;
const container = document.getElementById(`${type}_chips`);
if (!container) return;
const chips = container.querySelectorAll('.card-chip');
chips.forEach(chip => {
const cardName = chip.getAttribute('data-card-name');
if (!cardName) return;
// Determine status
let isLegal = false;
let isIllegal = false;
if (validationData.legal && validationData.legal.includes(cardName)) {
isLegal = true;
}
if (validationData.illegal && validationData.illegal.includes(cardName)) {
isIllegal = true;
}
// Apply styling based on status (prioritize illegal over legal)
if (isIllegal) {
// Red styling for illegal cards
chip.style.background = '#fee2e2';
chip.style.border = '1px solid #fecaca';
chip.style.color = '#dc2626';
// Update remove button color too
const removeBtn = chip.querySelector('button');
if (removeBtn) {
removeBtn.style.color = '#dc2626';
removeBtn.onmouseover = () => removeBtn.style.background = '#fee2e2';
}
} else if (isLegal) {
// Green styling for legal cards
chip.style.background = '#dcfce7';
chip.style.border = '1px solid #bbf7d0';
chip.style.color = '#166534';
// Update remove button color too
const removeBtn = chip.querySelector('button');
if (removeBtn) {
removeBtn.style.color = '#166534';
removeBtn.onmouseover = () => removeBtn.style.background = '#bbf7d0';
}
}
// If no status info, keep default styling
});
}
// Update exclude validation badges
@ -554,6 +605,9 @@
}
badgeContainer.innerHTML = badges;
// Update chip colors based on validation status
updateChipColors('exclude', excludeData);
}
// Comprehensive validation for both include and exclude cards