Andreas/markdownlint
1
0
Fork 0
mirror of https://github.com/DavidAnson/markdownlint.git synced 2025-09-22 05:40:48 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Update MD033/no-inline-html to ignore email autolinks (fixes #183).

Browse source
This commit is contained in:
David Anson 2019-05-08 18:42:26 -07:00
parent ad8e4007c0
commit f003926a72
3 changed files with 27 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
lib/md033.js
View file

@ -6,8 +6,12 @@ const { addError, bareUrlRe, forEachLine, unescapeMarkdown } =
require("../helpers"); require("../helpers");
const { lineMetadata } = require("./cache"); const { lineMetadata } = require("./cache");
const htmlElementRe = /<(\w+)(?:[^>]*)?>/g; const htmlElementRe = /<(([\w+.-]+)(?:[^>]*)?)>/g;
const linkDestinationRe = /]\(\s*$/; const linkDestinationRe = /]\(\s*$/;
// See https://spec.commonmark.org/0.29/#autolinks
const emailAddressRe =
// eslint-disable-next-line max-len
/^[a-zA-Z0-9.!#$%&'*+/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*$/;
module.exports = { module.exports = {
"names": [ "MD033", "no-inline-html" ], "names": [ "MD033", "no-inline-html" ],
@ -20,9 +24,10 @@ module.exports = {
let match = null; let match = null;
// eslint-disable-next-line no-unmodified-loop-condition // eslint-disable-next-line no-unmodified-loop-condition
while (!inCode && (match = htmlElementRe.exec(line))) { while (!inCode && (match = htmlElementRe.exec(line))) {
const [ tag, element ] = match; const [ tag, content, element ] = match;
if (!allowedElements.includes(element.toLowerCase()) && if (!allowedElements.includes(element.toLowerCase()) &&
!tag.endsWith("\\>") && !bareUrlRe.test(tag)) { !tag.endsWith("\\>") && !bareUrlRe.test(content) &&
!emailAddressRe.test(content)) {
const prefix = line.substring(0, match.index); const prefix = line.substring(0, match.index);
if (!linkDestinationRe.test(prefix) && if (!linkDestinationRe.test(prefix) &&
!unescapeMarkdown(prefix + "<", "_").endsWith("_")) { !unescapeMarkdown(prefix + "<", "_").endsWith("_")) {

10
test/detailed-results-html-tags.md
View file

@ -79,3 +79,13 @@ Text <a href="#anchor">inline</a> text
text <img src="src.png"/> text text <img src="src.png"/> text
Text Text
<name@example.com> is an email autolink.
Text
Another email autolink: <first+last@ex.exa-mple.com>.
Text
But <foo.bar.baz> is not an email autolink.

9
test/detailed-results-html-tags.results.json
View file

@ -151,5 +151,14 @@
"errorDetail": "Element: img", "errorDetail": "Element: img",
"errorContext": null, "errorContext": null,
"errorRange": [ 6, 20 ] "errorRange": [ 6, 20 ]
},
{
"lineNumber": 91,
"ruleNames": [ "MD033", "no-inline-html" ],
"ruleDescription": "Inline HTML",
"ruleInformation": "https://github.com/DavidAnson/markdownlint/blob/v0.0.0/doc/Rules.md#md033",
"errorDetail": "Element: foo.bar.baz",
"errorContext": null,
"errorRange": [ 5, 13 ]
} }
] ]