From e305d22cce6c30447719fa57b131421d394647ec Mon Sep 17 00:00:00 2001 From: David Anson Date: Wed, 18 Mar 2015 22:45:51 -0700 Subject: [PATCH] Undefined config.default should behave like true. --- lib/markdownlint.js | 2 +- test/markdownlint-test.js | 26 ++++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/lib/markdownlint.js b/lib/markdownlint.js index 9e31a5f8..03e75546 100644 --- a/lib/markdownlint.js +++ b/lib/markdownlint.js @@ -80,7 +80,7 @@ function lintFile(file, config, callback) { }; // Merge rules/tags and sanitize config var mergedRules = {}; - var ruleDefault = (config.default !== undefined) && !!config.default; + var ruleDefault = (config.default === undefined) || !!config.default; rules.forEach(function forRule(rule) { mergedRules[rule.name] = ruleDefault; }); diff --git a/test/markdownlint-test.js b/test/markdownlint-test.js index 064f271d..1b398aae 100644 --- a/test/markdownlint-test.js +++ b/test/markdownlint-test.js @@ -174,6 +174,32 @@ module.exports.defaultFalse = function defaultFalse(test) { }); }; +module.exports.defaultUndefined = function defaultUndefined(test) { + test.expect(2); + var options = { + "files": [ + "./test/atx_header_spacing.md", + "./test/first_header_bad_atx.md" + ], + "config": {} + }; + markdownlint(options, function callback(err, actualResult) { + test.ifError(err); + var expectedResult = { + "./test/atx_header_spacing.md": { + "MD002": [ 3 ], + "MD018": [ 1 ], + "MD019": [ 3, 5 ] + }, + "./test/first_header_bad_atx.md": { + "MD002": [ 1 ] + } + }; + test.deepEqual(actualResult, expectedResult, "Undetected issues."); + test.done(); + }); +}; + module.exports.disableRules = function disableRules(test) { test.expect(2); var options = {