mirror of
https://github.com/DavidAnson/markdownlint.git
synced 2025-12-16 22:10:13 +01:00
Reimplement MD039/no-space-in-links using micromark tokens.
This commit is contained in:
parent
92a19b6f36
commit
daa155d5a1
6 changed files with 265 additions and 124 deletions
102
lib/md039.js
102
lib/md039.js
|
|
@ -2,10 +2,9 @@
|
|||
|
||||
"use strict";
|
||||
|
||||
const { addErrorContext, filterTokens } = require("../helpers");
|
||||
|
||||
const spaceInLinkRe =
|
||||
/\[(?:\s[^\]]*|[^\]]*?\s)\](?=(\([^)]*\)|\[[^\]]*\]))/;
|
||||
const { addErrorContext } = require("../helpers");
|
||||
const { filterByTypes } = require("../helpers/micromark.cjs");
|
||||
const { referenceLinkImageData } = require("./cache");
|
||||
|
||||
// eslint-disable-next-line jsdoc/valid-types
|
||||
/** @type import("./markdownlint").Rule */
|
||||
|
|
@ -13,59 +12,54 @@ module.exports = {
|
|||
"names": [ "MD039", "no-space-in-links" ],
|
||||
"description": "Spaces inside link text",
|
||||
"tags": [ "whitespace", "links" ],
|
||||
"parser": "markdownit",
|
||||
"parser": "micromark",
|
||||
"function": function MD039(params, onError) {
|
||||
filterTokens(params, "inline", (token) => {
|
||||
const { children } = token;
|
||||
let { lineNumber } = token;
|
||||
let inLink = false;
|
||||
let linkText = "";
|
||||
let lineIndex = 0;
|
||||
for (const child of children) {
|
||||
const { content, markup, type } = child;
|
||||
if (type === "link_open") {
|
||||
inLink = true;
|
||||
linkText = "";
|
||||
} else if (type === "link_close") {
|
||||
inLink = false;
|
||||
const left = linkText.trimStart().length !== linkText.length;
|
||||
const right = linkText.trimEnd().length !== linkText.length;
|
||||
if (left || right) {
|
||||
const line = params.lines[lineNumber - 1];
|
||||
let range = null;
|
||||
let fixInfo = null;
|
||||
const match = line.slice(lineIndex).match(spaceInLinkRe);
|
||||
if (match) {
|
||||
// @ts-ignore
|
||||
const column = match.index + lineIndex + 1;
|
||||
const length = match[0].length;
|
||||
range = [ column, length ];
|
||||
fixInfo = {
|
||||
"editColumn": column + 1,
|
||||
"deleteCount": length - 2,
|
||||
"insertText": linkText.trim()
|
||||
};
|
||||
lineIndex = column + length - 1;
|
||||
}
|
||||
addErrorContext(
|
||||
onError,
|
||||
lineNumber,
|
||||
`[${linkText}]`,
|
||||
left,
|
||||
right,
|
||||
range,
|
||||
fixInfo
|
||||
);
|
||||
const { definitions } = referenceLinkImageData();
|
||||
const labels = filterByTypes(
|
||||
params.parsers.micromark.tokens,
|
||||
[ "label" ]
|
||||
).filter((label) => label.parent?.type === "link");
|
||||
for (const label of labels) {
|
||||
const labelTexts = filterByTypes(label.children, [ "labelText" ]);
|
||||
for (const labelText of labelTexts) {
|
||||
const leftSpace =
|
||||
labelText.text.trimStart().length !== labelText.text.length;
|
||||
const rightSpace =
|
||||
labelText.text.trimEnd().length !== labelText.text.length;
|
||||
if (
|
||||
(leftSpace || rightSpace) &&
|
||||
// Ignore non-shortcut link content "[ text ]"
|
||||
((label.parent?.children.length !== 1) || definitions.has(labelText.text.trim()))
|
||||
) {
|
||||
// eslint-disable-next-line no-undef-init
|
||||
let range = undefined;
|
||||
if (label.startLine === label.endLine) {
|
||||
const labelColumn = label.startColumn;
|
||||
const labelLength = label.endColumn - label.startColumn;
|
||||
range = [ labelColumn, labelLength ];
|
||||
}
|
||||
} else if ((type === "softbreak") || (type === "hardbreak")) {
|
||||
lineNumber++;
|
||||
lineIndex = 0;
|
||||
} else if (inLink) {
|
||||
linkText += type.endsWith("_inline") ?
|
||||
`${markup}${content}${markup}` :
|
||||
(content || markup);
|
||||
// eslint-disable-next-line no-undef-init
|
||||
let fixInfo = undefined;
|
||||
if (labelText.startLine === labelText.endLine) {
|
||||
const textColumn = labelText.startColumn;
|
||||
const textLength = labelText.endColumn - labelText.startColumn;
|
||||
fixInfo = {
|
||||
"editColumn": textColumn,
|
||||
"deleteCount": textLength,
|
||||
"insertText": labelText.text.trim()
|
||||
};
|
||||
}
|
||||
addErrorContext(
|
||||
onError,
|
||||
labelText.startLine,
|
||||
label.text.replace(/\s+/g, " "),
|
||||
leftSpace,
|
||||
rightSpace,
|
||||
range,
|
||||
fixInfo
|
||||
);
|
||||
}
|
||||
}
|
||||
});
|
||||
}
|
||||
}
|
||||
};
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue