From a92da33235007e6ea6ff2c97f90e76d53f0f67e7 Mon Sep 17 00:00:00 2001 From: David Anson Date: Sat, 6 Feb 2021 16:09:16 -0800 Subject: [PATCH] Update MD004/ul-style to handle invalid "style" parameter values. --- demo/markdownlint-browser.js | 4 ++++ lib/md004.js | 5 ++++- test/invalid-ul-style-style.md | 16 ++++++++++++++++ 3 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 test/invalid-ul-style-style.md diff --git a/demo/markdownlint-browser.js b/demo/markdownlint-browser.js index 455b0668..5cf1c5f2 100644 --- a/demo/markdownlint-browser.js +++ b/demo/markdownlint-browser.js @@ -1849,6 +1849,7 @@ var differentItemStyle = { "plus": "asterisk", "asterisk": "dash" }; +var validStyles = Object.keys(expectedStyleToMarker); module.exports = { "names": ["MD004", "ul-style"], "description": "Unordered list style", @@ -1874,6 +1875,9 @@ module.exports = { } expectedStyle = nestingStyles[nesting]; } + if (!validStyles.includes(expectedStyle)) { + expectedStyle = validStyles[0]; + } var range = null; var fixInfo = null; var match = item.line.match(listItemMarkerRe); diff --git a/lib/md004.js b/lib/md004.js index fa92a124..a79106fc 100644 --- a/lib/md004.js +++ b/lib/md004.js @@ -11,12 +11,12 @@ const expectedStyleToMarker = { "plus": "+", "asterisk": "*" }; - const differentItemStyle = { "dash": "plus", "plus": "asterisk", "asterisk": "dash" }; +const validStyles = Object.keys(expectedStyleToMarker); module.exports = { "names": [ "MD004", "ul-style" ], @@ -43,6 +43,9 @@ module.exports = { } expectedStyle = nestingStyles[nesting]; } + if (!validStyles.includes(expectedStyle)) { + expectedStyle = validStyles[0]; + } let range = null; let fixInfo = null; const match = item.line.match(listItemMarkerRe); diff --git a/test/invalid-ul-style-style.md b/test/invalid-ul-style-style.md new file mode 100644 index 00000000..031d6f91 --- /dev/null +++ b/test/invalid-ul-style-style.md @@ -0,0 +1,16 @@ +# Invalid ul-style style + +* Item {MD004} + * Item {MD004} + ++ Item {MD004} + + Item {MD004} + +- Item + - Item + +