Andreas/markdownlint
1
0
Fork 0
mirror of https://github.com/DavidAnson/markdownlint.git synced 2025-12-22 00:40:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Replace helpers.urlRe with helpers.urlFe to address "innefficient regular expression" CodeQL alert, introduce function expressions as an alternative, test more inputs.

Browse source
This commit is contained in:
David Anson 2022-12-18 15:46:19 -08:00
parent 485c63c579
commit 8d6e0b5419
5 changed files with 277 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

75
test/markdownlint-test-helpers.js
View file

@ -1309,7 +1309,7 @@ test("expandTildePath", (t) => {
t.is(helpers.expandTildePath("~/dir/file", null), "~/dir/file");
});
test("urlRe", (t) => {
test("urlFe", (t) => {
t.plan(1);
const input = `
Text ftp://example.com text
@ -1329,6 +1329,11 @@ Text https://example.com/path() text
Text https://example.com/path(path) text
Text https://example.com/path(path)path text
Text https://example.com/path-(path) text
Text https://example.com/path(() text
Text https://example.com/path()) text
Text https://example.com/path(()) text
Text https://example.com/path((())) text
Text https://example.com/path()() text
Text (https://example.com/path) text
Text <https://example.com/path> text
Text >https://example.com/path< text
@ -1350,24 +1355,35 @@ Text *https://example.com* text
Text **https://example.com** text
Text _https://example.com_ text
Text __https://example.com__ text
Text https://example.com. Text
Text https://example.com. text
Text https://example.com, text
Text https://example.com; text
Text https://example.com: text
Text https://example.com? Text
Text https://example.com! Text
Text https://example.com。 Text
Text https://example.com， Text
Text https://example.com； Text
Text https://example.com： Text
Text https://example.com！ Text
Text https://example.com? text
Text https://example.com! text
Text https://example.com。 text
Text https://example.com， text
Text https://example.com； text
Text https://example.com： text
Text https://example.com！ text
Text https://example.com,text
Text https://example.com.path text
Text https://example.com?path text
Text https://example.com!text
Text https://example.com.. text
Text https://example.com... text
Text https://example.com.co text
Text <https://example.com/path text> text
Text <https://example.com/path.path> text
Text <https://example.com/path,path> text
Text <https://example.com/path;path> text
Text <https://example.com/path:path> text
Text <https://example.com/path?path> text
Text <https://example.com/path!path> text
[https://example.com/path](https://example.com/path)
[ https://example.com/path](https://example.com/path)
[https://example.com/path ](https://example.com/path)
https://example.com/ text https://example.com/path text https://example.com/
https://example.com
https://example.com
https://example.com
@ -1390,6 +1406,11 @@ Text text
Text text
Text text
Text text
Text text
Text ) text
Text ) text
Text )) text
Text text
Text () text
Text <> text
Text >< text
@ -1409,26 +1430,37 @@ Text <a href="">link</a> text
Text <a href=""></a> text
Text ** text
Text **** text
Text _ text
Text __ text
Text . Text
Text ____ text
Text . text
Text , text
Text ; text
Text : text
Text ? Text
Text ! Text
Text 。 Text
Text ， Text
Text ； Text
Text ： Text
Text ！ Text
Text
Text ? text
Text ! text
Text 。 text
Text ， text
Text ； text
Text ： text
Text ！ text
Text ,text
Text text
Text text
Text
Text !text
Text .. text
Text ... text
Text text
Text < text> text
Text <> text
Text <> text
Text <> text
Text <> text
Text <> text
Text <> text
[]()
[ ]()
[ ]()
text text
@ -1437,7 +1469,8 @@ Text
for (let line of input) {
const urlRanges = [];
let match = null;
while ((match = helpers.urlRe.exec(line)) !== null) {
while ((match = helpers.funcExpExec(helpers.urlFe, line)) !== null) {
// @ts-ignore
urlRanges.push([ match.index, match[0].length ]);
}
urlRanges.reverse();