Andreas/markdownlint
1
0
Fork 0
mirror of https://github.com/DavidAnson/markdownlint.git synced 2025-09-21 21:30:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Handle un-closed HTML comments in a way that does not trigger MD047/single-trailing-newline (fixes #187).

Browse source
This commit is contained in:
David Anson 2019-05-16 22:14:07 -07:00
parent 0b9b74ccfd
commit 61c92e5997
4 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
helpers/helpers.js
View file

@ -76,7 +76,7 @@ module.exports.clearHtmlCommentText = function clearHtmlCommentText(text) {
let j = text.indexOf(htmlCommentEnd, i); let j = text.indexOf(htmlCommentEnd, i);
if (j === -1) { if (j === -1) {
j = text.length; j = text.length;
text += "\\"; text += "\\\n";
} }
const comment = text.slice(i + htmlCommentBegin.length, j); const comment = text.slice(i + htmlCommentBegin.length, j);
if ((comment.length > 0) && if ((comment.length > 0) &&

3
test/markdownlint-test.js
View file

@ -1329,7 +1329,8 @@ function clearHtmlCommentTextValid(test) {
"<!-- --><!-- -->", "<!-- --><!-- -->",
"text<!-- -->text<!-- -->text", "text<!-- -->text<!-- -->text",
"<!--", "<!--",
" \\" " \\",
""
]; ];
const actual = helpers.clearHtmlCommentText(validComments.join("\n")); const actual = helpers.clearHtmlCommentText(validComments.join("\n"));
const expected = validResult.join("\n"); const expected = validResult.join("\n");

3
test/unclosed-html-comment-in-code-span.md Normal file
View file

@ -0,0 +1,3 @@
# Heading
`<!--`

3
test/unclosed-html-comment.md Normal file
View file

@ -0,0 +1,3 @@
# Heading
<!--