Add MD049/emphasis-style (fixes #150).

test/break-all-the-rules.md

@@ -85,6 +85,10 @@ markdownLint {MD044}
 ![](image.jpg) {MD045}
 ## Heading 10 {MD022}
 
+Emphasis _with_ underscore style
+
+Emphasis *with* different style {MD049}
+
 Strong __with__ underscore style
 
 Strong **with** different style {MD050}

test/detailed-results-MD031-MD040.json

@@ -1,4 +1,5 @@
 {
   "default": true,
-  "MD041": false
+  "MD041": false,
+  "MD049": false
 }

test/emphasis-not-heading-in-blockquote.md

@@ -8,11 +8,11 @@ Text
 
 Text
 
-> *Text*
+> *Text* {MD049}
 
 Text
 
-> *Text text text*
+> *Text text text* {MD049}
 
 Text
 

test/emphasis_instead_of_headings.md

@@ -27,7 +27,7 @@ Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore
 eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt
 in culpa qui officia deserunt mollit anim id est laborum.
 
-_Section 3: oh no more sections {MD036}_
+_Section 3: oh no more sections {MD036} {MD049}_
 
 This is a normal paragraph
 **that just happens to have emphasized text in**

test/emphasis_style_asterisk.json

@@ -0,0 +1,6 @@
+{
+  "default": true,
+  "MD049": {
+    "style": "asterisk"
+  }
+}

test/emphasis_style_asterisk.md

@@ -0,0 +1,5 @@
+# Emphasis style asterisk
+
+This is *fine*
+
+This is _not_ {MD049}

test/emphasis_style_underscore.json

@@ -0,0 +1,6 @@
+{
+  "default": true,
+  "MD049": {
+    "style": "underscore"
+  }
+}

test/emphasis_style_underscore.md

@@ -0,0 +1,5 @@
+# Emphasis style underscore
+
+This is _fine_
+
+This is *not* {MD049}

test/fix_102_extra_nodes_in_link_text.md

@@ -2,9 +2,9 @@
 
 [test _test_ test](www.test.com)
 [test `test` test](www.test.com)
-[test *test* test](www.test.com)
-[test *test* *test* test](www.test.com)
-[test *test* *test* *test* test](www.test.com)
+[test *test* test](www.test.com) {MD049}
+[test *test* *test* test](www.test.com) {MD049}
+[test *test* *test* *test* test](www.test.com) {MD049}
 [test **test** test](www.test.com)
 [test __test__ test](www.test.com) {MD050}
 [this should not raise](www.shouldnotraise.com)

test/links-with-markup.md

@@ -10,7 +10,7 @@
 
 [This link has `code` and right space ](link) {MD039}
 
-[ This link has _emphasis_ and left space](link) {MD039}
+[ This link has _emphasis_ and left space](link) {MD039} {MD049}
 
 [This](link) line has [multiple](link) links.
 

test/long_lines.md

@@ -32,15 +32,15 @@ This long line includes a simple [reference][label] link and is long enough to v
 
 *[This long line is comprised of an emphasized link](https://example.com "This is the long link's title")*
 
-_[This long line is comprised of an emphasized link](https://example.com "This is the long link's title")_
+_[This long line is comprised of an emphasized link {MD049}](https://example.com "This is the long link's title")_
 
 **[This long line is comprised of a bolded link](https://example.com "This is the long link's title")**
 
 __[This long line is comprised of a bolded link {MD050}](https://example.com "This is the long link's title")__
 
-_**[This long line is comprised of an emphasized and bolded link](https://example.com "This is the long link's title")**_
+_**[This long line is comprised of an emphasized and bolded link {MD049}](https://example.com "This is the long link's title")**_
 
-**_[This long line is comprised of an emphasized and bolded link](https://example.com "This is the long link's title")_**
+**_[This long line is comprised of an emphasized and bolded link {MD049}](https://example.com "This is the long link's title")_**
 
 *[](https://example.com "This long line is comprised of an emphasized link with empty text and a non-empty title")*
 

test/markdownlint-test-repos.js

@@ -110,7 +110,12 @@ test("https://github.com/mochajs/mocha", (t) => {
 
 test("https://github.com/pi-hole/docs", (t) => {
   const rootDir = "./test-repos/pi-hole-docs";
-  const globPatterns = [ join(rootDir, "**/*.md") ];
+  const globPatterns = [
+    join(rootDir, "**/*.md"),
+    "!" + join(rootDir, "docs/guides/dns/unbound.md"),
+    "!" + join(rootDir, "docs/index.md"),
+    "!" + join(rootDir, "docs/main/prerequisites.md")
+  ];
   const configPath = join(rootDir, ".markdownlint.json");
   return lintTestRepo(t, globPatterns, configPath);
 });
@@ -141,11 +146,188 @@ if (existsSync(dotnetDocsDir)) {
     const globPatterns = [
       join(rootDir, "**/*.md"),
       "!" + join(rootDir, "samples/**/*.md"),
+      "!" + join(rootDir, "docs/architecture/cloud-native/candidate-apps.md"),
+      "!" + join(
+        rootDir,
+        "docs/architecture/containerized-lifecycle/docker-devops-workflow" +
+          "/docker-application-outer-loop-devops-workflow.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/architecture/dapr-for-net-developers/getting-started.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/architecture/grpc-for-wcf-developers/channel-credentials.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/architecture/microservices/implement-resilient-applications" +
+          "/use-httpclientfactory-to-implement-resilient-http-requests.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/architecture/microservices" +
+          "/multi-container-microservice-net-applications" +
+          "/implement-api-gateways-with-ocelot.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/architecture/modern-web-apps-azure/architectural-principles.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/architecture/modern-web-apps-azure" +
+          "/azure-hosting-recommendations-for-asp-net-web-apps.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/architecture/modern-web-apps-azure" +
+          "/common-client-side-web-technologies.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/architecture/modern-web-apps-azure" +
+          "/develop-asp-net-core-mvc-apps.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/architecture/modern-web-apps-azure" +
+          "/development-process-for-azure.md"
+      ),
+      "!" + join(rootDir, "docs/architecture/modern-web-apps-azure/index.md"),
+      "!" + join(rootDir, "docs/core/additional-tools/dotnet-svcutil-guide.md"),
+      "!" + join(rootDir, "docs/core/dependency-loading/collect-details.md"),
+      "!" + join(rootDir, "docs/core/deploying/single-file.md"),
+      "!" + join(rootDir, "docs/core/deploying/trimming/trimming-options.md"),
+      "!" + join(rootDir, "docs/core/extensions/cloud-service.md"),
+      "!" + join(rootDir, "docs/core/extensions/console-log-formatter.md"),
+      "!" + join(rootDir, "docs/core/extensions/create-resource-files.md"),
+      "!" + join(rootDir, "docs/core/extensions/localization.md"),
+      "!" + join(rootDir, "docs/core/install/linux-alpine.md"),
+      "!" + join(rootDir, "docs/core/install/windows.md"),
+      "!" + join(rootDir, "docs/core/porting/third-party-deps.md"),
+      "!" + join(rootDir, "docs/core/project-sdk/msbuild-props-desktop.md"),
+      "!" + join(rootDir, "docs/core/testing/unit-testing-code-coverage.md"),
+      "!" + join(rootDir, "docs/core/tools/troubleshoot-usage-issues.md"),
+      "!" + join(
+        rootDir,
+        "docs/core/tutorials/cli-templates-create-item-template.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/core/tutorials/cli-templates-create-project-template.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/core/tutorials/cli-templates-create-template-pack.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/core/tutorials/cli-templates-create-item-template.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/core/tutorials/cli-templates-create-project-template.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/core/tutorials/cli-templates-create-template-pack.md"
+      ),
+      "!" + join(rootDir, "docs/core/whats-new/dotnet-core-3-0.md"),
+      "!" + join(
+        rootDir,
+        "docs/csharp/language-reference/compiler-options/code-generation.md"
+      ),
+      "!" + join(rootDir, "docs/csharp/linq/query-expression-basics.md"),
+      "!" + join(
+        rootDir,
+        "docs/csharp/programming-guide/classes-and-structs" +
+          "/named-and-optional-arguments.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/csharp/roslyn-sdk/tutorials" +
+          "/how-to-write-csharp-analyzer-code-fix.md"
+      ),
+      "!" + join(rootDir, "docs/csharp/tutorials/attributes.md"),
+      "!" + join(rootDir, "docs/csharp/whats-new/csharp-version-history.md"),
       "!" + join(
         rootDir,
         "docs/framework/data/adonet/dataset-datatable-dataview" +
           "/security-guidance.md"
       ),
+      "!" + join(
+        rootDir,
+        "docs/fsharp/language-reference/compiler-directives.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/fsharp/language-reference/exception-handling" +
+          "/the-try-with-expression.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/fsharp/language-reference/xml-documentation.md"
+      ),
+      "!" + join(rootDir, "docs/fsharp/style-guide/conventions.md"),
+      "!" + join(
+        rootDir,
+        "docs/fsharp/tutorials/asynchronous-and-concurrent-programming/async.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/fundamentals/code-analysis/configuration-files.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/fundamentals/code-analysis/style-rules/naming-rules.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/machine-learning/tutorials" +
+          "/health-violation-classification-model-builder.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/machine-learning/tutorials/object-detection-model-builder.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/machine-learning/tutorials/object-detection-onnx.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/machine-learning/tutorials/text-classification-tf.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/standard/asynchronous-programming-patterns" +
+          "/event-based-asynchronous-pattern-overview.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/standard/asynchronous-programming-patterns" +
+          "/implementing-the-event-based-asynchronous-pattern.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/standard/base-types/string-comparison-net-5-plus.md"
+      ),
+      "!" + join(rootDir, "docs/standard/delegates-lambdas.md"),
+      "!" + join(rootDir, "docs/standard/io/isolated-storage.md"),
+      "!" + join(
+        rootDir,
+        "docs/standard/native-interop/tutorial-comwrappers.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/standard/serialization/xml-schema-definition-tool-xsd-exe.md"
+      ),
+      "!" + join(
+        rootDir,
+        "docs/standard/serialization/xml-serializer-generator-tool-sgen-exe.md"
+      ),
       "!" + join(rootDir, "docs/standard/native-interop/best-practices.md"),
       "!" + join(
         rootDir,
@@ -154,7 +336,7 @@ if (existsSync(dotnetDocsDir)) {
       "!" + join(
         rootDir,
         "docs/framework/windows-workflow-foundation/authoring-workflows-" +
-        "activities-and-expressions-using-imperative-code.md"
+          "activities-and-expressions-using-imperative-code.md"
       ),
       "!" + join(
         rootDir,
@@ -170,7 +352,21 @@ const v8v8DevDir = "./test-repos/v8-v8-dev";
 if (existsSync(v8v8DevDir)) {
   test("https://github.com/v8/v8.dev", (t) => {
     const rootDir = v8v8DevDir;
-    const globPatterns = [ join(rootDir, "src/**/*.md") ];
+    const globPatterns = [
+      join(rootDir, "src/**/*.md"),
+      "!" + join(rootDir, "src/blog/array-sort.md"),
+      "!" + join(rootDir, "src/blog/code-caching-for-devs.md"),
+      "!" + join(rootDir, "src/blog/fast-async.md"),
+      "!" + join(rootDir, "src/blog/liftoff.md"),
+      "!" + join(rootDir, "src/blog/pointer-compression.md"),
+      "!" + join(rootDir, "src/blog/react-cliff.md"),
+      "!" + join(rootDir, "src/blog/slack-tracking.md"),
+      "!" + join(rootDir, "src/blog/v8-release-74.md"),
+      "!" + join(rootDir, "src/features/bigint.md"),
+      "!" + join(rootDir, "src/features/dynamic-import.md"),
+      "!" + join(rootDir, "src/features/globalthis.md"),
+      "!" + join(rootDir, "src/features/modules.md")
+    ];
     const configPath = join(rootDir, ".markdownlint.json");
     return lintTestRepo(t, globPatterns, configPath);
   });

test/markdownlint-test.js

@@ -492,9 +492,10 @@ test.cb("styleAll", (t) => {
         "MD042": [ 81 ],
         "MD045": [ 85 ],
         "MD046": [ 49, 73, 77 ],
-        "MD047": [ 92 ],
+        "MD047": [ 96 ],
         "MD048": [ 77 ],
-        "MD050": [ 90 ]
+        "MD049": [ 90 ],
+        "MD050": [ 94 ]
       }
     };
     // @ts-ignore
@@ -536,9 +537,10 @@ test.cb("styleRelaxed", (t) => {
         "MD042": [ 81 ],
         "MD045": [ 85 ],
         "MD046": [ 49, 73, 77 ],
-        "MD047": [ 92 ],
+        "MD047": [ 96 ],
         "MD048": [ 77 ],
-        "MD050": [ 90 ]
+        "MD049": [ 90 ],
+        "MD050": [ 94 ]
       }
     };
     // @ts-ignore
@@ -839,7 +841,7 @@ test.cb("customFileSystemAsync", (t) => {
   });
 });
 test.cb("readme", (t) => {
-  t.plan(117);
+  t.plan(119);
   const tagToRules = {};
   rules.forEach(function forRule(rule) {
     rule.tags.forEach(function forTag(tag) {
@@ -915,7 +917,7 @@ test.cb("readme", (t) => {
 });
 
 test.cb("rules", (t) => {
-  t.plan(344);
+  t.plan(352);
   fs.readFile("doc/Rules.md", "utf8",
     (err, contents) => {
       t.falsy(err);
@@ -1568,7 +1570,7 @@ test.cb("configBadFilePromise", (t) => {
 });
 
 test("allBuiltInRulesHaveValidUrl", (t) => {
-  t.plan(135);
+  t.plan(138);
   rules.forEach(function forRule(rule) {
     t.truthy(rule.information);
     t.true(Object.getPrototypeOf(rule.information) === URL.prototype);

test/mixed-emphasis-markers.md

@@ -1,17 +1,17 @@
 # Mixed Emphasis Markers
 
-This paragraph *uses* both _kinds_ of emphasis marker.
+This paragraph *uses* both _kinds_ of emphasis marker. {MD049}
 
-This paragraph _uses_ both *kinds* of emphasis marker.
+This paragraph _uses_ both *kinds* of emphasis marker. {MD049}
 
-This paragraph *nests both _kinds_ of emphasis* marker.
+This paragraph *nests both _kinds_ of emphasis* marker. {MD049}
 
 This paragraph *nests both __kinds__ of emphasis* marker.
 
 This paragraph **nests both __kinds__ of emphasis** marker. {MD050}
 
-This paragraph _nests both *kinds* of emphasis_ marker.
+This paragraph _nests both *kinds* of emphasis_ marker. {MD049}
 
-This paragraph _nests both **kinds** of emphasis_ marker. {MD050}
+This paragraph _nests both **kinds** of emphasis_ marker. {MD049} {MD050}
 
 This paragraph __nests both **kinds** of emphasis__ marker. {MD050}

test/proper-names-projects.md

@@ -40,7 +40,7 @@ Quoted "Vue" and "vue-router"
 
 Emphasized *Vue* and *vue-router*
 
-Underscored _Vue_ and _vue-router_
+Underscored _Vue_ and _vue-router_ {MD049}
 
 Call it npm
 But not Npm {MD044}

test/proper-names.md

@@ -6,7 +6,7 @@ Quoted "Markdownlint" {MD044}
 
 Emphasized *Markdownlint* {MD044}
 
-Emphasized _Markdownlint_ {MD044}
+Emphasized _Markdownlint_ {MD044} {MD049}
 
 JavaScript is a language
 

test/spaces-inside-emphasis-markers-multiple-lines.md

@@ -100,7 +100,7 @@ code
 
 Mixed `code_span`
 scenarios
-are _also_ okay.
+are _also_ okay. {MD049}
 
 Mixed `code*span`
 scenarios

test/spaces_inside_emphasis_markers.md

@@ -1,6 +1,6 @@
 # Heading
 
-<!-- markdownlint-disable-file strong-style -->
+<!-- markdownlint-disable-file emphasis-style strong-style -->
 
 Line with *Normal emphasis*