Andreas/markdownlint
1
0
Fork 0
mirror of https://github.com/DavidAnson/markdownlint.git synced 2025-12-17 06:20:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Fix null dereference in helpers.getPreferredLineEnding when running in browser (platform unknown, process object not available) and input string does not contain line endings.

Browse source
This commit is contained in:
David Anson 2022-05-04 22:09:11 -07:00
parent 580b7ed020
commit 295e481552
4 changed files with 51 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

17
helpers/helpers.js
View file

@ -789,6 +789,18 @@ function emphasisMarkersInContent(params) {
}
module.exports.emphasisMarkersInContent = emphasisMarkersInContent;
/**
* Gets the platform identifier from a string or process-like object.
*
* @param {string} platform Platform identifier (process.platform).
* @param {Object} process Node.js process object.
* @returns {string} Platform identifier.
*/
function getPlatformIdentifier(platform, process) {
return (platform || (process && process.platform) || "unknown");
}
module.exports.getPlatformIdentifier = getPlatformIdentifier;
/**
* Gets the most common line ending, falling back to the platform default.
*
@ -818,7 +830,10 @@ function getPreferredLineEnding(input, platform) {
let preferredLineEnding = null;
if (!cr && !lf && !crlf) {
preferredLineEnding =
((platform || process.platform) === "win32") ? "\r\n" : "\n";
// eslint-disable-next-line node/prefer-global/process
(getPlatformIdentifier(platform, require("process")) === "win32") ?
"\r\n" :
"\n";
} else if ((lf >= crlf) && (lf >= cr)) {
preferredLineEnding = "\n";
} else if (crlf >= cr) {