Reimplement inlineCodeSpanRanges as codeBlockAndSpanRanges to fix an issue with unterminated code spans (and for flexibility).

demo/markdownlint-browser.js

@@ -307,14 +307,20 @@ module.exports.getLineMetadata = function getLineMetadata(params) {
     });
     return lineMetadata;
 };
-// Calls the provided function for each line (with context)
+/**
-module.exports.forEachLine = function forEachLine(lineMetadata, handler) {
+ * Calls the provided function for each line.
+ *
+ * @param {Object} lineMetadata Line metadata object.
+ * @param {Function} handler Function taking (line, lineIndex, inCode, onFence,
+ * inTable, inItem, inBreak, inMath).
+ * @returns {void}
+ */
+function forEachLine(lineMetadata, handler) {
     lineMetadata.forEach(function forMetadata(metadata) {
-        // Parameters:
-        // line, lineIndex, inCode, onFence, inTable, inItem, inBreak, inMath
         handler.apply(void 0, metadata);
     });
-};
+}
+module.exports.forEachLine = forEachLine;
 // Returns (nested) lists as a flat array (in order)
 module.exports.flattenLists = function flattenLists(tokens) {
     var flattenedLists = [];
@@ -403,7 +409,8 @@ module.exports.forEachHeading = function forEachHeading(params, handler) {
  * Calls the provided function for each inline code span's content.
  *
  * @param {string} input Markdown content.
- * @param {Function} handler Callback function.
+ * @param {Function} handler Callback function taking (code, lineIndex,
+ * columnIndex, ticks).
  * @returns {void}
  */
 function forEachInlineCodeSpan(input, handler) {
@@ -533,19 +540,35 @@ module.exports.addErrorContext = function addErrorContext(onError, lineNumber, c
     addError(onError, lineNumber, null, context, range, fixInfo);
 };
 /**
- * Returns an array of code span ranges.
+ * Returns an array of code block and span content ranges.
  *
- * @param {string[]} lines Lines to scan for code span ranges.
+ * @param {Object} params RuleParams instance.
- * @returns {number[][]} Array of ranges (line, index, length).
+ * @param {Object} lineMetadata Line metadata object.
+ * @returns {number[][]} Array of ranges (lineIndex, columnIndex, length).
  */
-module.exports.inlineCodeSpanRanges = function (lines) {
+module.exports.codeBlockAndSpanRanges = function (params, lineMetadata) {
     var exclusions = [];
-    forEachInlineCodeSpan(lines.join("\n"), function (code, lineIndex, columnIndex) {
+    // Add code block ranges (excludes fences)
+    forEachLine(lineMetadata, function (line, lineIndex, inCode, onFence) {
+        if (inCode && !onFence) {
+            exclusions.push(lineIndex, 0, line.length);
+        }
+    });
+    // Add code span ranges (excludes ticks)
+    filterTokens(params, "inline", function (token) {
+        if (token.children.some(function (child) { return child.type === "code_inline"; })) {
+            var tokenLines = params.lines.slice(token.map[0], token.map[1]);
+            forEachInlineCodeSpan(tokenLines.join("\n"), function (code, lineIndex, columnIndex) {
                 var codeLines = code.split(newLineRe);
-        // eslint-disable-next-line unicorn/no-for-loop
+                for (var _i = 0, _a = codeLines.entries(); _i < _a.length; _i++) {
-        for (var i = 0; i < codeLines.length; i++) {
+                    var _b = _a[_i], i = _b[0], line = _b[1];
-            exclusions.push([lineIndex + i, columnIndex, codeLines[i].length]);
+                    exclusions.push([
-            columnIndex = 0;
+                        token.lineNumber - 1 + lineIndex + i,
+                        i ? 0 : columnIndex,
+                        line.length
+                    ]);
+                }
+            });
         }
     });
     return exclusions;
@@ -773,6 +796,13 @@ module.exports.applyFixes = function applyFixes(input, errors) {
 "use strict";
 // @ts-check
 
+var codeBlockAndSpanRanges = null;
+module.exports.codeBlockAndSpanRanges = function (value) {
+    if (value) {
+        codeBlockAndSpanRanges = value;
+    }
+    return codeBlockAndSpanRanges;
+};
 var flattenedLists = null;
 module.exports.flattenedLists = function (value) {
     if (value) {
@@ -780,13 +810,6 @@ module.exports.flattenedLists = function (value) {
     }
     return flattenedLists;
 };
-var inlineCodeSpanRanges = null;
-module.exports.inlineCodeSpanRanges = function (value) {
-    if (value) {
-        inlineCodeSpanRanges = value;
-    }
-    return inlineCodeSpanRanges;
-};
 var lineMetadata = null;
 module.exports.lineMetadata = function (value) {
     if (value) {
@@ -795,8 +818,8 @@ module.exports.lineMetadata = function (value) {
     return lineMetadata;
 };
 module.exports.clear = function () {
+    codeBlockAndSpanRanges = null;
     flattenedLists = null;
-    inlineCodeSpanRanges = null;
     lineMetadata = null;
 };
 
@@ -1305,7 +1328,7 @@ function lintContent(ruleList, name, content, md, config, frontMatter, handleRul
     };
     cache.lineMetadata(helpers.getLineMetadata(params));
     cache.flattenedLists(helpers.flattenLists(params.tokens));
-    cache.inlineCodeSpanRanges(helpers.inlineCodeSpanRanges(params.lines));
+    cache.codeBlockAndSpanRanges(helpers.codeBlockAndSpanRanges(params, cache.lineMetadata()));
     // Function to run for each rule
     var result = (resultVersion === 0) ? {} : [];
     // eslint-disable-next-line jsdoc/require-jsdoc
@@ -2287,14 +2310,14 @@ module.exports = {
 // @ts-check
 
 var _a = __webpack_require__(/*! ../helpers */ "../helpers/helpers.js"), addError = _a.addError, forEachLine = _a.forEachLine, overlapsAnyRange = _a.overlapsAnyRange;
-var _b = __webpack_require__(/*! ./cache */ "../lib/cache.js"), inlineCodeSpanRanges = _b.inlineCodeSpanRanges, lineMetadata = _b.lineMetadata;
+var _b = __webpack_require__(/*! ./cache */ "../lib/cache.js"), codeBlockAndSpanRanges = _b.codeBlockAndSpanRanges, lineMetadata = _b.lineMetadata;
 var reversedLinkRe = /(^|[^\\])\(([^)]+)\)\[([^\]^][^\]]*)](?!\()/g;
 module.exports = {
     "names": ["MD011", "no-reversed-links"],
     "description": "Reversed link syntax",
     "tags": ["links"],
     "function": function MD011(params, onError) {
-        var exclusions = inlineCodeSpanRanges();
+        var exclusions = codeBlockAndSpanRanges();
         forEachLine(lineMetadata(), function (line, lineIndex, inCode, onFence) {
             if (!inCode && !onFence) {
                 var match = null;
@@ -3175,7 +3198,7 @@ module.exports = {
 // @ts-check
 
 var _a = __webpack_require__(/*! ../helpers */ "../helpers/helpers.js"), addError = _a.addError, forEachLine = _a.forEachLine, overlapsAnyRange = _a.overlapsAnyRange, unescapeMarkdown = _a.unescapeMarkdown;
-var _b = __webpack_require__(/*! ./cache */ "../lib/cache.js"), inlineCodeSpanRanges = _b.inlineCodeSpanRanges, lineMetadata = _b.lineMetadata;
+var _b = __webpack_require__(/*! ./cache */ "../lib/cache.js"), codeBlockAndSpanRanges = _b.codeBlockAndSpanRanges, lineMetadata = _b.lineMetadata;
 var htmlElementRe = /<(([A-Za-z][A-Za-z0-9-]*)(?:\s[^>]*)?)\/?>/g;
 var linkDestinationRe = /]\(\s*$/;
 // See https://spec.commonmark.org/0.29/#autolinks
@@ -3190,7 +3213,7 @@ module.exports = {
         var allowedElements = params.config.allowed_elements;
         allowedElements = Array.isArray(allowedElements) ? allowedElements : [];
         allowedElements = allowedElements.map(function (element) { return element.toLowerCase(); });
-        var exclusions = inlineCodeSpanRanges();
+        var exclusions = codeBlockAndSpanRanges();
         forEachLine(lineMetadata(), function (line, lineIndex, inCode) {
             var match = null;
             // eslint-disable-next-line no-unmodified-loop-condition
@@ -3868,7 +3891,7 @@ module.exports = {
 // @ts-check
 
 var _a = __webpack_require__(/*! ../helpers */ "../helpers/helpers.js"), addErrorDetailIf = _a.addErrorDetailIf, bareUrlRe = _a.bareUrlRe, escapeForRegExp = _a.escapeForRegExp, forEachLine = _a.forEachLine, overlapsAnyRange = _a.overlapsAnyRange, linkRe = _a.linkRe, linkReferenceRe = _a.linkReferenceRe;
-var _b = __webpack_require__(/*! ./cache */ "../lib/cache.js"), inlineCodeSpanRanges = _b.inlineCodeSpanRanges, lineMetadata = _b.lineMetadata;
+var _b = __webpack_require__(/*! ./cache */ "../lib/cache.js"), codeBlockAndSpanRanges = _b.codeBlockAndSpanRanges, lineMetadata = _b.lineMetadata;
 module.exports = {
     "names": ["MD044", "proper-names"],
     "description": "Proper names should have the correct capitalization",
@@ -3898,7 +3921,7 @@ module.exports = {
             }
         });
         if (!includeCodeBlocks) {
-            exclusions.push.apply(exclusions, inlineCodeSpanRanges());
+            exclusions.push.apply(exclusions, codeBlockAndSpanRanges());
         }
         var _loop_1 = function (name) {
             var escapedName = escapeForRegExp(name);

doc/Rules.md

@@ -1762,7 +1762,8 @@ the proper capitalization, specify the desired letter case in the `names` array:
 ]
 ```
 
-Set the `code_blocks` parameter to `false` to disable this rule for code blocks.
+Set the `code_blocks` parameter to `false` to disable this rule for code blocks
+and spans.
 
 Rationale: Incorrect capitalization of proper names is usually a mistake.
 

helpers/helpers.js

@@ -309,14 +309,20 @@ module.exports.getLineMetadata = function getLineMetadata(params) {
   return lineMetadata;
 };
 
-// Calls the provided function for each line (with context)
+/**
-module.exports.forEachLine = function forEachLine(lineMetadata, handler) {
+ * Calls the provided function for each line.
+ *
+ * @param {Object} lineMetadata Line metadata object.
+ * @param {Function} handler Function taking (line, lineIndex, inCode, onFence,
+ * inTable, inItem, inBreak, inMath).
+ * @returns {void}
+ */
+function forEachLine(lineMetadata, handler) {
   lineMetadata.forEach(function forMetadata(metadata) {
-    // Parameters:
-    // line, lineIndex, inCode, onFence, inTable, inItem, inBreak, inMath
     handler(...metadata);
   });
-};
+}
+module.exports.forEachLine = forEachLine;
 
 // Returns (nested) lists as a flat array (in order)
 module.exports.flattenLists = function flattenLists(tokens) {
@@ -402,7 +408,8 @@ module.exports.forEachHeading = function forEachHeading(params, handler) {
  * Calls the provided function for each inline code span's content.
  *
  * @param {string} input Markdown content.
- * @param {Function} handler Callback function.
+ * @param {Function} handler Callback function taking (code, lineIndex,
+ * columnIndex, ticks).
  * @returns {void}
  */
 function forEachInlineCodeSpan(input, handler) {
@@ -537,26 +544,39 @@ module.exports.addErrorContext = function addErrorContext(
 };
 
 /**
- * Returns an array of code span ranges.
+ * Returns an array of code block and span content ranges.
  *
- * @param {string[]} lines Lines to scan for code span ranges.
+ * @param {Object} params RuleParams instance.
- * @returns {number[][]} Array of ranges (line, index, length).
+ * @param {Object} lineMetadata Line metadata object.
+ * @returns {number[][]} Array of ranges (lineIndex, columnIndex, length).
  */
-module.exports.inlineCodeSpanRanges = (lines) => {
+module.exports.codeBlockAndSpanRanges = (params, lineMetadata) => {
   const exclusions = [];
+  // Add code block ranges (excludes fences)
+  forEachLine(lineMetadata, (line, lineIndex, inCode, onFence) => {
+    if (inCode && !onFence) {
+      exclusions.push(lineIndex, 0, line.length);
+    }
+  });
+  // Add code span ranges (excludes ticks)
+  filterTokens(params, "inline", (token) => {
+    if (token.children.some((child) => child.type === "code_inline")) {
+      const tokenLines = params.lines.slice(token.map[0], token.map[1]);
       forEachInlineCodeSpan(
-    lines.join("\n"),
+        tokenLines.join("\n"),
         (code, lineIndex, columnIndex) => {
           const codeLines = code.split(newLineRe);
-      // eslint-disable-next-line unicorn/no-for-loop
+          for (const [ i, line ] of codeLines.entries()) {
-      for (let i = 0; i < codeLines.length; i++) {
+            exclusions.push([
-        exclusions.push(
+              token.lineNumber - 1 + lineIndex + i,
-          [ lineIndex + i, columnIndex, codeLines[i].length ]
+              i ? 0 : columnIndex,
-        );
+              line.length
-        columnIndex = 0;
+            ]);
           }
         }
       );
+    }
+  });
   return exclusions;
 };
 

lib/cache.js

@@ -2,6 +2,14 @@
 
 "use strict";
 
+let codeBlockAndSpanRanges = null;
+module.exports.codeBlockAndSpanRanges = (value) => {
+  if (value) {
+    codeBlockAndSpanRanges = value;
+  }
+  return codeBlockAndSpanRanges;
+};
+
 let flattenedLists = null;
 module.exports.flattenedLists = (value) => {
   if (value) {
@@ -10,14 +18,6 @@ module.exports.flattenedLists = (value) => {
   return flattenedLists;
 };
 
-let inlineCodeSpanRanges = null;
-module.exports.inlineCodeSpanRanges = (value) => {
-  if (value) {
-    inlineCodeSpanRanges = value;
-  }
-  return inlineCodeSpanRanges;
-};
-
 let lineMetadata = null;
 module.exports.lineMetadata = (value) => {
   if (value) {
@@ -27,7 +27,7 @@ module.exports.lineMetadata = (value) => {
 };
 
 module.exports.clear = () => {
+  codeBlockAndSpanRanges = null;
   flattenedLists = null;
-  inlineCodeSpanRanges = null;
   lineMetadata = null;
 };

lib/markdownlint.js

@@ -515,7 +515,9 @@ function lintContent(
   };
   cache.lineMetadata(helpers.getLineMetadata(params));
   cache.flattenedLists(helpers.flattenLists(params.tokens));
-  cache.inlineCodeSpanRanges(helpers.inlineCodeSpanRanges(params.lines));
+  cache.codeBlockAndSpanRanges(
+    helpers.codeBlockAndSpanRanges(params, cache.lineMetadata())
+  );
   // Function to run for each rule
   const result = (resultVersion === 0) ? {} : [];
   // eslint-disable-next-line jsdoc/require-jsdoc

lib/md011.js

@@ -3,7 +3,7 @@
 "use strict";
 
 const { addError, forEachLine, overlapsAnyRange } = require("../helpers");
-const { inlineCodeSpanRanges, lineMetadata } = require("./cache");
+const { codeBlockAndSpanRanges, lineMetadata } = require("./cache");
 
 const reversedLinkRe =
   /(^|[^\\])\(([^)]+)\)\[([^\]^][^\]]*)](?!\()/g;
@@ -13,7 +13,7 @@ module.exports = {
   "description": "Reversed link syntax",
   "tags": [ "links" ],
   "function": function MD011(params, onError) {
-    const exclusions = inlineCodeSpanRanges();
+    const exclusions = codeBlockAndSpanRanges();
     forEachLine(lineMetadata(), (line, lineIndex, inCode, onFence) => {
       if (!inCode && !onFence) {
         let match = null;

lib/md033.js

@@ -5,7 +5,7 @@
 const {
   addError, forEachLine, overlapsAnyRange, unescapeMarkdown
 } = require("../helpers");
-const { inlineCodeSpanRanges, lineMetadata } = require("./cache");
+const { codeBlockAndSpanRanges, lineMetadata } = require("./cache");
 
 const htmlElementRe = /<(([A-Za-z][A-Za-z0-9-]*)(?:\s[^>]*)?)\/?>/g;
 const linkDestinationRe = /]\(\s*$/;
@@ -22,7 +22,7 @@ module.exports = {
     let allowedElements = params.config.allowed_elements;
     allowedElements = Array.isArray(allowedElements) ? allowedElements : [];
     allowedElements = allowedElements.map((element) => element.toLowerCase());
-    const exclusions = inlineCodeSpanRanges();
+    const exclusions = codeBlockAndSpanRanges();
     forEachLine(lineMetadata(), (line, lineIndex, inCode) => {
       let match = null;
       // eslint-disable-next-line no-unmodified-loop-condition

lib/md044.js

@@ -4,7 +4,7 @@
 
 const { addErrorDetailIf, bareUrlRe, escapeForRegExp, forEachLine,
   overlapsAnyRange, linkRe, linkReferenceRe } = require("../helpers");
-const { inlineCodeSpanRanges, lineMetadata } = require("./cache");
+const { codeBlockAndSpanRanges, lineMetadata } = require("./cache");
 
 module.exports = {
   "names": [ "MD044", "proper-names" ],
@@ -36,7 +36,7 @@ module.exports = {
       }
     });
     if (!includeCodeBlocks) {
-      exclusions.push(...inlineCodeSpanRanges());
+      exclusions.push(...codeBlockAndSpanRanges());
     }
     for (const name of names) {
       const escapedName = escapeForRegExp(name);

test/code-blocks-and-spans.md

@@ -0,0 +1,38 @@
+# Code Blocks and Spans {MD044}
+
+Text CODE text {MD044}
+
+Text `CODE` text
+
+```lang
+CODE
+
+CODE
+```
+
+`CODE` text `CODE`
+
+    CODE
+    
+    CODE
+
+Text `CODE
+CODE` text
+text text
+text `CODE
+CODE CODE
+CODE` text
+
+Text `CODE {MD044}
+
+Text `CODE {MD044}
+
+<!-- markdownlint-configure-file {
+  "proper-names": {
+    "names": [
+      "code"
+    ],
+    "code_blocks": false
+  },
+  "code-block-style": false
+} -->

test/inline_html.md

@@ -96,3 +96,25 @@ Text **\<base directory>\another\directory\\<slash/directory>** text
 <a href="https://example.com" target="_blank">Google</a> {MD033}
 
 <a href="https://example.com:9999" target="_blank">Google</a> {MD033}
+
+## Unterminated code span followed by element in code span
+
+Text text `text text
+
+Text `<element>` text
+
+Text
+text `text
+text
+
+Text `code <element> code` text
+
+```lang
+code {MD046:112}
+
+<element>
+```
+
+Text `code <element> code` text
+
+Text <element> text {MD033}

test/markdownlint-test-repos.js

@@ -174,6 +174,7 @@ if (existsSync(dotnetDocsDir)) {
         "docs/core/dependency-loading/collect-details.md",
         "docs/core/deploying/single-file.md",
         "docs/core/deploying/trimming/trimming-options.md",
+        "docs/core/diagnostics/dotnet-dump.md",
         "docs/core/extensions/cloud-service.md",
         "docs/core/extensions/configuration-providers.md",
         "docs/core/extensions/console-log-formatter.md",

test/reversed-link-issue-with-markdownlint-12.md

@@ -2,7 +2,7 @@
 
 |Pattern|Description|
 |-------------|-----------------|
-|`(?:\["'\](?<1>\[^"'\]*)["']|(?<1>\S+))`|...|
+|`(?:\["'\](?<1>\[^"'\]*)["']|(?<1>\S+))`|{MD011}|
 
 |Pattern|Description|
 |-------------|-----------------|