From 788c9942ad9fc5fb2270da7c1971ae9a8df6b3f3 Mon Sep 17 00:00:00 2001 From: Manfred Touron Date: Mon, 12 Oct 2015 18:19:42 +0200 Subject: [PATCH 1/2] Log passed arguments i.e: 2015/10/12 18:14:11 127.0.0.1:56983 200 GET /auth_token.js 2015/10/12 18:14:11 New client connected: 127.0.0.1:56984 2015/10/12 18:14:11 127.0.0.1:56984 passed arguments are: "--server_id XXXXXXXXXXXXXXX --type serial --auth_token YYYYYYYYYYYYYYYY" 2015/10/12 18:14:11 Command is running for client 127.0.0.1:56984 with PID 95770 2015/10/12 18:14:11 127.0.0.1:56984 101 GET /ws 2015/10/12 18:14:11 Command exited for: 127.0.0.1:56984 --- app/app.go | 1 + 1 file changed, 1 insertion(+) diff --git a/app/app.go b/app/app.go index 4bab54a..826ff8c 100644 --- a/app/app.go +++ b/app/app.go @@ -317,6 +317,7 @@ func (app *App) handleWS(w http.ResponseWriter, r *http.Request) { } params := query.Query()["arg"] if len(params) != 0 { + log.Printf("%s passed arguments are: %q", r.RemoteAddr, strings.Join(params, " ")) argv = append(argv, params...) } } From d56157f1eec75d0efe957bca5f00787f71fa4169 Mon Sep 17 00:00:00 2001 From: Manfred Touron Date: Tue, 13 Oct 2015 19:04:45 +0200 Subject: [PATCH 2/2] Using already-existing log command to print passed arguments --- app/app.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/app.go b/app/app.go index 826ff8c..978d71a 100644 --- a/app/app.go +++ b/app/app.go @@ -317,7 +317,6 @@ func (app *App) handleWS(w http.ResponseWriter, r *http.Request) { } params := query.Query()["arg"] if len(params) != 0 { - log.Printf("%s passed arguments are: %q", r.RemoteAddr, strings.Join(params, " ")) argv = append(argv, params...) } } @@ -341,7 +340,7 @@ func (app *App) handleWS(w http.ResponseWriter, r *http.Request) { log.Print("Failed to execute command") return } - log.Printf("Command is running for client %s with PID %d", r.RemoteAddr, cmd.Process.Pid) + log.Printf("Command is running for client %s with PID %d (args=%q)", r.RemoteAddr, cmd.Process.Pid, strings.Join(argv, " ")) context := &clientContext{ app: app,