Enable strict mode on scripts, clean up some unremoved references

evennia/web/webclient/static/webclient/js/evennia.js

@@ -50,6 +50,7 @@ An "emitter" object must have a function
 */
 
 (function() {
+    "use strict"
     var cmdid = 0;
     var cmdmap = {};
 
@@ -237,7 +238,7 @@ An "emitter" object must have a function
 
     // AJAX/COMET Connector
     //
-    AjaxCometConnection = function() {
+    var AjaxCometConnection = function() {
         log("Trying ajax ...");
         var client_hash = '0';
 

evennia/web/webclient/static/webclient/js/webclient_gui.js

@@ -12,6 +12,9 @@
  *
  */
 
+(function () {
+"use strict"
+
 //
 // GUI Elements
 //
@@ -25,12 +28,12 @@ var input_history = function() {
 
     history[0] = ''; // the very latest input is empty for new entry.
 
-    var back = function (scratchInput) {
+    var back = function () {
         // step backwards in history stack
         history_pos = Math.min(++history_pos, history.length - 1);
         return history[history.length - 1 - history_pos];
     };
-    var fwd = function (scratchInput) {
+    var fwd = function () {
         // step forwards in history stack
         history_pos = Math.max(--history_pos, 0);
         return history[history.length - 1 - history_pos];
@@ -74,7 +77,6 @@ var input_history = function() {
 // Grab text from inputline and send to Evennia
 function doSendText() {
     inputfield = $("#inputfield");
-    isInputDirty = false;
     var outtext = inputfield.val();
     if (outtext.length > 7 && outtext.substr(0, 7) == "##send ") {
         // send a specific oob instruction
@@ -178,7 +180,7 @@ function doWindowResize() {
 function onText(args, kwargs) {
     // append message to previous ones, then scroll so latest is at
     // the bottom.
-    mwin = $("#messagewindow");
+    var mwin = $("#messagewindow");
     mwin.append("<div class='msg out'>" + args[0] + "</div>");
     mwin.animate({
         scrollTop: document.getElementById("messagewindow").scrollHeight
@@ -249,3 +251,4 @@ $(document).ready(function() {
     );
 });
 
+})();

evennia/web/webclient/templates/webclient/base.html

@@ -56,14 +56,18 @@ JQuery available.
         {% endblock %}
     </div>
 
-    <noscript class="err">
+    <div id="noscript" class="err">
         <h3>Javascript Error: The Evennia MUD client requires that you
             have Javascript activated.</h3>
             <p>Turn off eventual script blockers and/or switch to a
             web browser supporting javascript. <p>
             This error could also be due to not being able to access
             the online jQuery javascript library.</p>
-    </noscript>
+        <!-- This is will only fire if javascript is actually active -->
+        <script language="javascript" type="text/javascript">
+            $('#noscript').remove();
+        </script>
+    </div>
 
     <!-- main client -->
     <div id=clientwrapper>