Andreas/evennia
1
0
Fork 0
mirror of https://github.com/evennia/evennia.git synced 2026-03-27 18:26:32 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Printing traces to the user is usually bad.

Browse source 
This could, in theory, expose more information about how the server
works than would be advised, benefiting potential attackers.
This commit is contained in:
Ahmed Charles 2015-10-19 01:11:00 +00:00 • committed by Griatch
parent f890c8bddb
commit acdf2573b0
3 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
evennia/commands/default/unloggedin.py
View file

@ -140,8 +140,7 @@ class CmdUnconnectedConnect(MuxCommand):
# We are in the middle between logged in and -not, so we have
# to handle tracebacks ourselves at this point. If we don't,
# we won't see any errors at all.
string = "%s\nThis is a bug. Please e-mail an admin if the problem persists."
session.msg(string % (traceback.format_exc()))
session.msg("An error occurred. Please e-mail an admin if the problem persists.")
logger.log_errmsg(traceback.format_exc())
finally:
return
@ -287,8 +286,7 @@ class CmdUnconnectedCreate(MuxCommand):
# We are in the middle between logged in and -not, so we have
# to handle tracebacks ourselves at this point. If we don't,
# we won't see any errors at all.
string = "%s\nThis is a bug. Please e-mail an admin if the problem persists."
session.msg(string % (traceback.format_exc()))
session.msg("An error occurred. Please e-mail an admin if the problem persists.")
logger.log_errmsg(traceback.format_exc())

3
evennia/contrib/email_login.py
View file

@ -257,8 +257,7 @@ its and @/./+/-/_ only.") # this echoes the restrictions made by django's auth m
# We are in the middle between logged in and -not, so we have
# to handle tracebacks ourselves at this point. If we don't,
# we won't see any errors at all.
string = "%s\nThis is a bug. Please e-mail an admin if the problem persists."
session.msg(string % (traceback.format_exc()))
session.msg("An error occurred. Please e-mail an admin if the problem persists.")
logger.log_errmsg(traceback.format_exc())
class CmdUnconnectedQuit(MuxCommand):

3
evennia/contrib/menu_login.py
View file

@ -235,8 +235,7 @@ class CmdPasswordCreate(Command):
# We are in the middle between logged in and -not, so we have
# to handle tracebacks ourselves at this point. If we don't, we
# won't see any errors at all.
string = "%s\nThis is a bug. Please e-mail an admin if the problem persists."
self.caller.msg(string % (traceback.format_exc()))
self.caller.msg("An error occurred. Please e-mail an admin if the problem persists."
logger.log_errmsg(traceback.format_exc())