Fix regression in menu_login contrib. Resolve #3460

CHANGELOG.md

@@ -33,6 +33,8 @@
   range (chiizujin)
 - [Fix][issue3462]: EvEditor :UU and :DD etc commands were not properly
   differentiating from their lower-case alternatives (Griatch)
+- [Fix][issue3460]: The `menu_login` contrib regression caused it to error out
+  when creating a new character (Griatch)
 - Doc: Added Beginner Tutorial lessons for AI, Quests and Procedural dungeon (Griatch)
 - Doc fixes (Griatch, InspectorCaracal)
 
@@ -50,6 +52,7 @@
 [pull3467]: https://github.com/evennia/evennia/pull/3467
 [issue3450]: https://github.com/evennia/evennia/issues/3450
 [issue3462]: https://github.com/evennia/evennia/issues/3462
+[issue3460]: https://github.com/evennia/evennia/issues/3460
 
 ## Evennia 4.0.0
 

evennia/contrib/base_systems/menu_login/menu_login.py

@@ -21,14 +21,10 @@ called automatically when a new user connects.
 """
 
 from django.conf import settings
-
 from evennia import CmdSet, Command, syscmdkeys
 from evennia.utils.evmenu import EvMenu
-from evennia.utils.utils import (
-    callables_from_module,
-    class_from_module,
-    random_string_from_module,
-)
+from evennia.utils.utils import (callables_from_module, class_from_module,
+                                 random_string_from_module)
 
 _CONNECTION_SCREEN_MODULE = settings.CONNECTION_SCREEN_MODULE
 _GUEST_ENABLED = settings.GUEST_ENABLED
@@ -90,7 +86,7 @@ def node_enter_username(caller, raw_text, **kwargs):
         else:
             new_user = False
 
-        if new_user and not settings.ACCOUNT_REGISTRATION_ENABLED:
+        if new_user and not settings.NEW_ACCOUNT_REGISTRATION_ENABLED:
             caller.msg("Registration is currently disabled.")
             return None