From 5d15010dde32dcb03d5dcf8ec11b9f688c63e8a2 Mon Sep 17 00:00:00 2001 From: Griatch Date: Fri, 20 Mar 2020 21:56:30 +0100 Subject: [PATCH] Remove dummy@example.com as email fallback since django no longer requires an email to be set --- CHANGELOG.md | 2 ++ evennia/utils/create.py | 7 +++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 541978ec4c..5252f8f67a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -52,6 +52,8 @@ without arguments starts a full interactive Python console. fail e.g. for your inventory objs (since their loc is you), whereas this will pass. - RPSystem contrib's CmdRecog will now list all recogs if no arg is given. Also multiple bugfixes. +- Remove `dummy@example.com` as a default account email when unset, a string is no longer + required by Django. ## Evennia 0.9 (2018-2019) diff --git a/evennia/utils/create.py b/evennia/utils/create.py index 8e9d98b305..f4a5810fbd 100644 --- a/evennia/utils/create.py +++ b/evennia/utils/create.py @@ -486,9 +486,8 @@ def create_account( Args: key (str): The account's name. This should be unique. - email (str): Email on valid addr@addr.domain form. This is - technically required but if set to `None`, an email of - `dummy@example.com` will be used as a placeholder. + email (str or None): Email on valid addr@addr.domain form. If + the empty string, will be set to None. password (str): Password in cleartext. Kwargs: @@ -532,7 +531,7 @@ def create_account( # correctly when each object is recovered). if not email: - email = "dummy@example.com" + email = None if _AccountDB.objects.filter(username__iexact=key): raise ValueError("An Account with the name '%s' already exists." % key)