mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-03-22 15:46:33 +01:00
* fix: Add removePorts keyGenerator to all IP-based rate limiters Six IP-based rate limiters are missing the `keyGenerator: removePorts` option that is already used by the auth-related limiters (login, register, resetPassword, verifyEmail). Without it, reverse proxies that include ports in X-Forwarded-For headers cause ERR_ERL_INVALID_IP_ADDRESS errors from express-rate-limit. Fixes #12318 * fix: make removePorts IPv6-safe to prevent rate-limit key collisions The original regex `/:\d+[^:]*$/` treated the last colon-delimited segment of bare IPv6 addresses as a port, mangling valid IPs (e.g. `::1` → `::`, `2001:db8::1` → `2001:db8::`). Distinct IPv6 clients could collapse into the same rate-limit bucket. Use `net.isIP()` as a fast path for already-valid IPs, then match bracketed IPv6+port and IPv4+port explicitly. Bare IPv6 addresses are now returned unchanged. Also fixes pre-existing property ordering inconsistency in ttsLimiters.js userLimiterOptions (keyGenerator before store). * refactor: move removePorts to packages/api as TypeScript, fix import order - Move removePorts implementation to packages/api/src/utils/removePorts.ts with proper Express Request typing - Reduce api/server/utils/removePorts.js to a thin re-export from @librechat/api for backward compatibility - Consolidate removePorts import with limiterCache from @librechat/api in all 6 limiter files, fixing import order (package imports shortest to longest, local imports longest to shortest) - Remove narrating inline comments per code style guidelines --------- Co-authored-by: Danny Avila <danny@librechat.ai>
140 lines
3.8 KiB
JavaScript
140 lines
3.8 KiB
JavaScript
const { Keyv } = require('keyv');
|
|
const uap = require('ua-parser-js');
|
|
const { logger } = require('@librechat/data-schemas');
|
|
const { ViolationTypes } = require('librechat-data-provider');
|
|
const { isEnabled, keyvMongo, removePorts } = require('@librechat/api');
|
|
const { getLogStores } = require('~/cache');
|
|
const denyRequest = require('./denyRequest');
|
|
const { findUser } = require('~/models');
|
|
|
|
const banCache = new Keyv({ store: keyvMongo, namespace: ViolationTypes.BAN, ttl: 0 });
|
|
const message = 'Your account has been temporarily banned due to violations of our service.';
|
|
|
|
/**
|
|
* Respond to the request if the user is banned.
|
|
*
|
|
* @async
|
|
* @function
|
|
* @param {Object} req - Express Request object.
|
|
* @param {Object} res - Express Response object.
|
|
*
|
|
* @returns {Promise<Object>} - Returns a Promise which when resolved sends a response status of 403 with a specific message if request is not of api/agents/chat. If it is, calls `denyRequest()` function.
|
|
*/
|
|
const banResponse = async (req, res) => {
|
|
const ua = uap(req.headers['user-agent']);
|
|
const { baseUrl, originalUrl } = req;
|
|
if (!ua.browser.name) {
|
|
return res.status(403).json({ message });
|
|
} else if (baseUrl === '/api/agents' && originalUrl.startsWith('/api/agents/chat')) {
|
|
return await denyRequest(req, res, { type: ViolationTypes.BAN });
|
|
}
|
|
|
|
return res.status(403).json({ message });
|
|
};
|
|
|
|
/**
|
|
* Checks if the source IP or user is banned or not.
|
|
*
|
|
* @async
|
|
* @function
|
|
* @param {Object} req - Express request object.
|
|
* @param {Object} res - Express response object.
|
|
* @param {import('express').NextFunction} next - Next middleware function.
|
|
*
|
|
* @returns {Promise<function|Object>} - Returns a Promise which when resolved calls next middleware if user or source IP is not banned. Otherwise calls `banResponse()` and sets ban details in `banCache`.
|
|
*/
|
|
const checkBan = async (req, res, next = () => {}) => {
|
|
try {
|
|
const { BAN_VIOLATIONS } = process.env ?? {};
|
|
|
|
if (!isEnabled(BAN_VIOLATIONS)) {
|
|
return next();
|
|
}
|
|
|
|
req.ip = removePorts(req);
|
|
let userId = req.user?.id ?? req.user?._id ?? null;
|
|
|
|
if (!userId && req?.body?.email) {
|
|
const user = await findUser({ email: req.body.email }, '_id');
|
|
userId = user?._id ? user._id.toString() : userId;
|
|
}
|
|
|
|
if (!userId && !req.ip) {
|
|
return next();
|
|
}
|
|
|
|
let cachedIPBan;
|
|
let cachedUserBan;
|
|
|
|
let ipKey = '';
|
|
let userKey = '';
|
|
|
|
if (req.ip) {
|
|
ipKey = isEnabled(process.env.USE_REDIS) ? `ban_cache:ip:${req.ip}` : req.ip;
|
|
cachedIPBan = await banCache.get(ipKey);
|
|
}
|
|
|
|
if (userId) {
|
|
userKey = isEnabled(process.env.USE_REDIS) ? `ban_cache:user:${userId}` : userId;
|
|
cachedUserBan = await banCache.get(userKey);
|
|
}
|
|
|
|
const cachedBan = cachedIPBan || cachedUserBan;
|
|
|
|
if (cachedBan) {
|
|
req.banned = true;
|
|
return await banResponse(req, res);
|
|
}
|
|
|
|
const banLogs = getLogStores(ViolationTypes.BAN);
|
|
const duration = banLogs.opts.ttl;
|
|
|
|
if (duration <= 0) {
|
|
return next();
|
|
}
|
|
|
|
let ipBan;
|
|
let userBan;
|
|
|
|
if (req.ip) {
|
|
ipBan = await banLogs.get(req.ip);
|
|
}
|
|
|
|
if (userId) {
|
|
userBan = await banLogs.get(userId);
|
|
}
|
|
|
|
const isBanned = !!(ipBan || userBan);
|
|
|
|
if (!isBanned) {
|
|
return next();
|
|
}
|
|
|
|
const timeLeft = Number(isBanned.expiresAt) - Date.now();
|
|
|
|
if (timeLeft <= 0 && ipKey) {
|
|
await banLogs.delete(ipKey);
|
|
}
|
|
|
|
if (timeLeft <= 0 && userKey) {
|
|
await banLogs.delete(userKey);
|
|
return next();
|
|
}
|
|
|
|
if (ipKey) {
|
|
banCache.set(ipKey, isBanned, timeLeft);
|
|
}
|
|
|
|
if (userKey) {
|
|
banCache.set(userKey, isBanned, timeLeft);
|
|
}
|
|
|
|
req.banned = true;
|
|
return await banResponse(req, res);
|
|
} catch (error) {
|
|
logger.error('Error in checkBan middleware:', error);
|
|
return next(error);
|
|
}
|
|
};
|
|
|
|
module.exports = checkBan;
|