mirror of
https://github.com/danny-avila/LibreChat.git
synced 2025-12-17 00:40:14 +01:00
da473bf43a
* refactor(mcp): simplify registry to two-repository architecture with explicit storage
* Chore: address AI Review comments
* Simplify MCP config cache architecture and remove legacy code:
Follow-up cleanup to commit d2bfdd033 which refactored MCP registry to two-repository architecture. This removes leftover legacy abstractions that were no longer used.
What changed:
- Simplified ServerConfigsCacheFactory.create() from 3 params to 2 (namespace, leaderOnly)
- Removed unused scope: 'Shared' | 'Private' parameter (only 'Shared' was ever used)
- Removed dead set() and getNamespace() methods from cache classes
- Updated JSDoc to reflect two-repository architecture (Cache + DB) instead of old three-tier system
- Fixed stale mocks and comments referencing removed sharedAppServers, sharedUserServers, privateServersCache
Files changed:
- ServerConfigsCacheFactory.ts - Simplified factory signature
- ServerConfigsCacheRedis.ts - Removed scope, renamed owner→namespace
- ServerConfigsCacheInMemory.ts - Removed unused methods
- MCPServersRegistry.ts - Updated JSDoc, simplified factory call
- RegistryStatusCache.ts - Removed stale JSDoc reference
- MCPManager.test.ts - Fixed legacy mock
- ServerConfigsCacheFactory.test.ts - Updated test assertions
* fix: Update error message in MCPServersRegistry for clarity
---------
Co-authored-by: Atef Bellaaj <slalom.bellaaj@external.daimlertruck.com>
Co-authored-by: Danny Avila <danny@librechat.ai>
31 lines
1.4 KiB
TypeScript
31 lines
1.4 KiB
TypeScript
import { cacheConfig } from '~/cache';
|
|
import { ServerConfigsCacheInMemory } from './ServerConfigsCacheInMemory';
|
|
import { ServerConfigsCacheRedis } from './ServerConfigsCacheRedis';
|
|
|
|
export type ServerConfigsCache = ServerConfigsCacheInMemory | ServerConfigsCacheRedis;
|
|
|
|
/**
|
|
* Factory for creating the appropriate ServerConfigsCache implementation based on deployment mode.
|
|
* Automatically selects between in-memory and Redis-backed storage depending on USE_REDIS config.
|
|
* In single-instance mode (USE_REDIS=false), returns lightweight in-memory cache.
|
|
* In cluster mode (USE_REDIS=true), returns Redis-backed cache with distributed coordination.
|
|
* Provides a unified interface regardless of the underlying storage mechanism.
|
|
*/
|
|
export class ServerConfigsCacheFactory {
|
|
/**
|
|
* Create a ServerConfigsCache instance.
|
|
* Returns Redis implementation if Redis is configured, otherwise in-memory implementation.
|
|
*
|
|
* @param namespace - The namespace for the cache (e.g., 'App') - only used for Redis namespacing
|
|
* @param leaderOnly - Whether operations should only be performed by the leader (only applies to Redis)
|
|
* @returns ServerConfigsCache instance
|
|
*/
|
|
static create(namespace: string, leaderOnly: boolean): ServerConfigsCache {
|
|
if (cacheConfig.USE_REDIS) {
|
|
return new ServerConfigsCacheRedis(namespace, leaderOnly);
|
|
}
|
|
|
|
// In-memory mode uses a simple Map - doesn't need namespace
|
|
return new ServerConfigsCacheInMemory();
|
|
}
|
|
}
|