mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-02-19 00:48:08 +01:00
* chore: move database model methods to /packages/data-schemas * chore: add TypeScript ESLint rule to warn on unused variables * refactor: model imports to streamline access - Consolidated model imports across various files to improve code organization and reduce redundancy. - Updated imports for models such as Assistant, Message, Conversation, and others to a unified import path. - Adjusted middleware and service files to reflect the new import structure, ensuring functionality remains intact. - Enhanced test files to align with the new import paths, maintaining test coverage and integrity. * chore: migrate database models to packages/data-schemas and refactor all direct Mongoose Model usage outside of data-schemas * test: update agent model mocks in unit tests - Added `getAgent` mock to `client.test.js` to enhance test coverage for agent-related functionality. - Removed redundant `getAgent` and `getAgents` mocks from `openai.spec.js` and `responses.unit.spec.js` to streamline test setup and reduce duplication. - Ensured consistency in agent mock implementations across test files. * fix: update types in data-schemas * refactor: enhance type definitions in transaction and spending methods - Updated type definitions in `checkBalance.ts` to use specific request and response types. - Refined `spendTokens.ts` to utilize a new `SpendTxData` interface for better clarity and type safety. - Improved transaction handling in `transaction.ts` by introducing `TransactionResult` and `TxData` interfaces, ensuring consistent data structures across methods. - Adjusted unit tests in `transaction.spec.ts` to accommodate new type definitions and enhance robustness. * refactor: streamline model imports and enhance code organization - Consolidated model imports across various controllers and services to a unified import path, improving code clarity and reducing redundancy. - Updated multiple files to reflect the new import structure, ensuring all functionalities remain intact. - Enhanced overall code organization by removing duplicate import statements and optimizing the usage of model methods. * feat: implement loadAddedAgent and refactor agent loading logic - Introduced `loadAddedAgent` function to handle loading agents from added conversations, supporting multi-convo parallel execution. - Created a new `load.ts` file to encapsulate agent loading functionalities, including `loadEphemeralAgent` and `loadAgent`. - Updated the `index.ts` file to export the new `load` module instead of the deprecated `loadAgent`. - Enhanced type definitions and improved error handling in the agent loading process. - Adjusted unit tests to reflect changes in the agent loading structure and ensure comprehensive coverage. * refactor: enhance balance handling with new update interface - Introduced `IBalanceUpdate` interface to streamline balance update operations across the codebase. - Updated `upsertBalanceFields` method signatures in `balance.ts`, `transaction.ts`, and related tests to utilize the new interface for improved type safety. - Adjusted type imports in `balance.spec.ts` to include `IBalanceUpdate`, ensuring consistency in balance management functionalities. - Enhanced overall code clarity and maintainability by refining type definitions related to balance operations. * feat: add unit tests for loadAgent functionality and enhance agent loading logic - Introduced comprehensive unit tests for the `loadAgent` function, covering various scenarios including null and empty agent IDs, loading of ephemeral agents, and permission checks. - Enhanced the `initializeClient` function by moving `getConvoFiles` to the correct position in the database method exports, ensuring proper functionality. - Improved test coverage for agent loading, including handling of non-existent agents and user permissions. * chore: reorder memory method exports for consistency - Moved `deleteAllUserMemories` to the correct position in the exported memory methods, ensuring a consistent and logical order of method exports in `memory.ts`.
166 lines
4.6 KiB
TypeScript
166 lines
4.6 KiB
TypeScript
import { Types } from 'mongoose';
|
|
import {
|
|
ResourceType,
|
|
PrincipalType,
|
|
PermissionBits,
|
|
AccessRoleIds,
|
|
} from 'librechat-data-provider';
|
|
import type { PipelineStage, AnyBulkWriteOperation } from 'mongoose';
|
|
|
|
export interface Principal {
|
|
type: string;
|
|
id: string;
|
|
name: string;
|
|
email?: string;
|
|
avatar?: string;
|
|
source?: string;
|
|
idOnTheSource?: string;
|
|
accessRoleId: string;
|
|
isImplicit?: boolean;
|
|
}
|
|
|
|
export interface EnricherDependencies {
|
|
aggregateAclEntries: (pipeline: PipelineStage[]) => Promise<Record<string, unknown>[]>;
|
|
bulkWriteAclEntries: (
|
|
ops: AnyBulkWriteOperation<unknown>[],
|
|
options?: Record<string, unknown>,
|
|
) => Promise<unknown>;
|
|
findRoleByIdentifier: (
|
|
accessRoleId: string,
|
|
) => Promise<{ _id: Types.ObjectId; permBits: number } | null>;
|
|
logger: { error: (msg: string, ...args: unknown[]) => void };
|
|
}
|
|
|
|
export interface EnrichResult {
|
|
principals: Principal[];
|
|
entriesToBackfill: Types.ObjectId[];
|
|
}
|
|
|
|
/** Enriches REMOTE_AGENT principals with implicit AGENT owners */
|
|
export async function enrichRemoteAgentPrincipals(
|
|
deps: EnricherDependencies,
|
|
resourceId: string | Types.ObjectId,
|
|
principals: Principal[],
|
|
): Promise<EnrichResult> {
|
|
const resourceObjectId =
|
|
typeof resourceId === 'string' && /^[a-f\d]{24}$/i.test(resourceId)
|
|
? Types.ObjectId.createFromHexString(resourceId)
|
|
: resourceId;
|
|
|
|
const agentOwnerEntries = await deps.aggregateAclEntries([
|
|
{
|
|
$match: {
|
|
resourceType: ResourceType.AGENT,
|
|
resourceId: resourceObjectId,
|
|
principalType: PrincipalType.USER,
|
|
permBits: { $bitsAllSet: PermissionBits.SHARE },
|
|
},
|
|
},
|
|
{
|
|
$lookup: {
|
|
from: 'users',
|
|
localField: 'principalId',
|
|
foreignField: '_id',
|
|
as: 'userInfo',
|
|
},
|
|
},
|
|
{
|
|
$project: {
|
|
principalId: 1,
|
|
userInfo: { $arrayElemAt: ['$userInfo', 0] },
|
|
},
|
|
},
|
|
]);
|
|
|
|
const enrichedPrincipals = [...principals];
|
|
const entriesToBackfill: Types.ObjectId[] = [];
|
|
|
|
for (const entry of agentOwnerEntries) {
|
|
if (!entry.userInfo) {
|
|
continue;
|
|
}
|
|
|
|
const userInfo = entry.userInfo as Record<string, unknown>;
|
|
const principalId = entry.principalId as Types.ObjectId;
|
|
|
|
const alreadyIncluded = enrichedPrincipals.some(
|
|
(p) => p.type === PrincipalType.USER && p.id === principalId.toString(),
|
|
);
|
|
|
|
if (!alreadyIncluded) {
|
|
enrichedPrincipals.unshift({
|
|
type: PrincipalType.USER,
|
|
id: (userInfo._id as Types.ObjectId).toString(),
|
|
name: (userInfo.name || userInfo.username) as string,
|
|
email: userInfo.email as string,
|
|
avatar: userInfo.avatar as string,
|
|
source: 'local',
|
|
idOnTheSource:
|
|
(userInfo.idOnTheSource as string) || (userInfo._id as Types.ObjectId).toString(),
|
|
accessRoleId: AccessRoleIds.REMOTE_AGENT_OWNER,
|
|
isImplicit: true,
|
|
});
|
|
|
|
entriesToBackfill.push(principalId);
|
|
}
|
|
}
|
|
|
|
return { principals: enrichedPrincipals, entriesToBackfill };
|
|
}
|
|
|
|
/** Backfills REMOTE_AGENT ACL entries for AGENT owners (fire-and-forget) */
|
|
export function backfillRemoteAgentPermissions(
|
|
deps: EnricherDependencies,
|
|
resourceId: string | Types.ObjectId,
|
|
entriesToBackfill: Types.ObjectId[],
|
|
): void {
|
|
if (entriesToBackfill.length === 0) {
|
|
return;
|
|
}
|
|
|
|
const { logger } = deps;
|
|
|
|
const resourceObjectId =
|
|
typeof resourceId === 'string' && /^[a-f\d]{24}$/i.test(resourceId)
|
|
? Types.ObjectId.createFromHexString(resourceId)
|
|
: resourceId;
|
|
|
|
deps
|
|
.findRoleByIdentifier(AccessRoleIds.REMOTE_AGENT_OWNER)
|
|
.then((role) => {
|
|
if (!role) {
|
|
logger.error('[backfillRemoteAgentPermissions] REMOTE_AGENT_OWNER role not found');
|
|
return;
|
|
}
|
|
|
|
const bulkOps = entriesToBackfill.map((principalId) => ({
|
|
updateOne: {
|
|
filter: {
|
|
principalType: PrincipalType.USER,
|
|
principalId,
|
|
resourceType: ResourceType.REMOTE_AGENT,
|
|
resourceId: resourceObjectId,
|
|
},
|
|
update: {
|
|
$setOnInsert: {
|
|
principalType: PrincipalType.USER,
|
|
principalId,
|
|
principalModel: 'User',
|
|
resourceType: ResourceType.REMOTE_AGENT,
|
|
resourceId: resourceObjectId,
|
|
permBits: role.permBits,
|
|
roleId: role._id,
|
|
grantedBy: principalId,
|
|
grantedAt: new Date(),
|
|
},
|
|
},
|
|
upsert: true,
|
|
},
|
|
}));
|
|
|
|
return deps.bulkWriteAclEntries(bulkOps, { ordered: false });
|
|
})
|
|
.catch((err: unknown) => {
|
|
logger.error('[backfillRemoteAgentPermissions] Failed to backfill:', err);
|
|
});
|
|
}
|