LibreChat/api/test/services/Files/processFileCitations.test.js
Danny Avila a6fb257bcf
📦 refactor: Consolidate DB models, encapsulating Mongoose usage in data-schemas (#11830)
* chore: move database model methods to /packages/data-schemas

* chore: add TypeScript ESLint rule to warn on unused variables

* refactor: model imports to streamline access

- Consolidated model imports across various files to improve code organization and reduce redundancy.
- Updated imports for models such as Assistant, Message, Conversation, and others to a unified import path.
- Adjusted middleware and service files to reflect the new import structure, ensuring functionality remains intact.
- Enhanced test files to align with the new import paths, maintaining test coverage and integrity.

* chore: migrate database models to packages/data-schemas and refactor all direct Mongoose Model usage outside of data-schemas

* test: update agent model mocks in unit tests

- Added `getAgent` mock to `client.test.js` to enhance test coverage for agent-related functionality.
- Removed redundant `getAgent` and `getAgents` mocks from `openai.spec.js` and `responses.unit.spec.js` to streamline test setup and reduce duplication.
- Ensured consistency in agent mock implementations across test files.

* fix: update types in data-schemas

* refactor: enhance type definitions in transaction and spending methods

- Updated type definitions in `checkBalance.ts` to use specific request and response types.
- Refined `spendTokens.ts` to utilize a new `SpendTxData` interface for better clarity and type safety.
- Improved transaction handling in `transaction.ts` by introducing `TransactionResult` and `TxData` interfaces, ensuring consistent data structures across methods.
- Adjusted unit tests in `transaction.spec.ts` to accommodate new type definitions and enhance robustness.

* refactor: streamline model imports and enhance code organization

- Consolidated model imports across various controllers and services to a unified import path, improving code clarity and reducing redundancy.
- Updated multiple files to reflect the new import structure, ensuring all functionalities remain intact.
- Enhanced overall code organization by removing duplicate import statements and optimizing the usage of model methods.

* feat: implement loadAddedAgent and refactor agent loading logic

- Introduced `loadAddedAgent` function to handle loading agents from added conversations, supporting multi-convo parallel execution.
- Created a new `load.ts` file to encapsulate agent loading functionalities, including `loadEphemeralAgent` and `loadAgent`.
- Updated the `index.ts` file to export the new `load` module instead of the deprecated `loadAgent`.
- Enhanced type definitions and improved error handling in the agent loading process.
- Adjusted unit tests to reflect changes in the agent loading structure and ensure comprehensive coverage.

* refactor: enhance balance handling with new update interface

- Introduced `IBalanceUpdate` interface to streamline balance update operations across the codebase.
- Updated `upsertBalanceFields` method signatures in `balance.ts`, `transaction.ts`, and related tests to utilize the new interface for improved type safety.
- Adjusted type imports in `balance.spec.ts` to include `IBalanceUpdate`, ensuring consistency in balance management functionalities.
- Enhanced overall code clarity and maintainability by refining type definitions related to balance operations.

* feat: add unit tests for loadAgent functionality and enhance agent loading logic

- Introduced comprehensive unit tests for the `loadAgent` function, covering various scenarios including null and empty agent IDs, loading of ephemeral agents, and permission checks.
- Enhanced the `initializeClient` function by moving `getConvoFiles` to the correct position in the database method exports, ensuring proper functionality.
- Improved test coverage for agent loading, including handling of non-existent agents and user permissions.

* chore: reorder memory method exports for consistency

- Moved `deleteAllUserMemories` to the correct position in the exported memory methods, ensuring a consistent and logical order of method exports in `memory.ts`.
2026-02-18 00:31:36 -05:00

347 lines
8.7 KiB
JavaScript

const { Tools } = require('librechat-data-provider');
const {
processFileCitations,
applyCitationLimits,
enhanceSourcesWithMetadata,
} = require('~/server/services/Files/Citations');
// Mock dependencies
jest.mock('~/models', () => ({
getFiles: jest.fn().mockResolvedValue([]),
getRoleByName: jest.fn(),
}));
jest.mock('@librechat/api', () => ({
checkAccess: jest.fn().mockResolvedValue(true),
}));
jest.mock('~/cache/getLogStores', () => () => ({
get: jest.fn().mockResolvedValue({
agents: {
maxCitations: 30,
maxCitationsPerFile: 5,
minRelevanceScore: 0.45,
},
fileStrategy: 'local',
}),
set: jest.fn(),
delete: jest.fn(),
}));
jest.mock('~/config', () => ({
logger: {
debug: jest.fn(),
error: jest.fn(),
warn: jest.fn(),
},
}));
describe('processFileCitations', () => {
const mockReq = {
user: {
id: 'user123',
},
};
const mockAppConfig = {
endpoints: {
agents: {
maxCitations: 30,
maxCitationsPerFile: 5,
minRelevanceScore: 0.45,
},
},
fileStrategy: 'local',
};
const mockMetadata = {
run_id: 'run123',
thread_id: 'conv123',
};
describe('file search artifact processing', () => {
it('should process file search artifacts correctly', async () => {
const toolArtifact = {
[Tools.file_search]: {
sources: [
{
fileId: 'file_123',
fileName: 'example.pdf',
pages: [5],
relevance: 0.85,
type: 'file',
pageRelevance: { 5: 0.85 },
content: 'This is the content',
},
{
fileId: 'file_456',
fileName: 'document.txt',
pages: [],
relevance: 0.72,
type: 'file',
pageRelevance: {},
content: 'Another document',
},
],
},
};
const result = await processFileCitations({
toolArtifact,
toolCallId: 'call_123',
metadata: mockMetadata,
user: mockReq.user,
appConfig: mockAppConfig,
});
expect(result).toBeTruthy();
expect(result.type).toBe('file_search');
expect(result.file_search.sources).toHaveLength(2);
expect(result.file_search.sources[0].fileId).toBe('file_123');
expect(result.file_search.sources[0].relevance).toBe(0.85);
});
it('should return null for non-file_search tools', async () => {
const result = await processFileCitations({
toolArtifact: { other_tool: {} },
toolCallId: 'call_123',
metadata: mockMetadata,
user: mockReq.user,
appConfig: mockAppConfig,
});
expect(result).toBeNull();
});
it('should filter results below relevance threshold', async () => {
const toolArtifact = {
[Tools.file_search]: {
sources: [
{
fileId: 'file_789',
fileName: 'low_relevance.pdf',
pages: [],
relevance: 0.2,
type: 'file',
pageRelevance: {},
content: 'Low relevance content',
},
],
},
};
const result = await processFileCitations({
toolArtifact,
toolCallId: 'call_123',
metadata: mockMetadata,
user: mockReq.user,
appConfig: mockAppConfig,
});
expect(result).toBeNull();
});
it('should return null when artifact is missing file_search data', async () => {
const result = await processFileCitations({
toolArtifact: {},
toolCallId: 'call_123',
metadata: mockMetadata,
user: mockReq.user,
appConfig: mockAppConfig,
});
expect(result).toBeNull();
});
});
describe('applyCitationLimits', () => {
it('should limit citations per file and total', () => {
const sources = [
{ fileId: 'file1', relevance: 0.9 },
{ fileId: 'file1', relevance: 0.8 },
{ fileId: 'file1', relevance: 0.7 },
{ fileId: 'file2', relevance: 0.85 },
{ fileId: 'file2', relevance: 0.75 },
];
const result = applyCitationLimits(sources, 3, 2);
expect(result).toHaveLength(3);
expect(result[0].relevance).toBe(0.9);
expect(result[1].relevance).toBe(0.85);
expect(result[2].relevance).toBe(0.8);
});
});
describe('enhanceSourcesWithMetadata', () => {
const { getFiles } = require('~/models');
const mockCustomConfig = {
fileStrategy: 'local',
};
beforeEach(() => {
jest.clearAllMocks();
});
it('should enhance sources with file metadata from database', async () => {
const sources = [
{
fileId: 'file_123',
fileName: 'example.pdf',
relevance: 0.85,
type: 'file',
},
{
fileId: 'file_456',
fileName: 'document.txt',
relevance: 0.72,
type: 'file',
},
];
getFiles.mockResolvedValue([
{
file_id: 'file_123',
filename: 'example_from_db.pdf',
source: 's3',
},
{
file_id: 'file_456',
filename: 'document_from_db.txt',
source: 'local',
},
]);
const result = await enhanceSourcesWithMetadata(sources, mockCustomConfig);
expect(getFiles).toHaveBeenCalledWith({ file_id: { $in: ['file_123', 'file_456'] } });
expect(result).toHaveLength(2);
expect(result[0]).toEqual({
fileId: 'file_123',
fileName: 'example_from_db.pdf',
relevance: 0.85,
type: 'file',
metadata: {
storageType: 's3',
},
});
expect(result[1]).toEqual({
fileId: 'file_456',
fileName: 'document_from_db.txt',
relevance: 0.72,
type: 'file',
metadata: {
storageType: 'local',
},
});
});
it('should preserve existing metadata and source data', async () => {
const sources = [
{
fileId: 'file_123',
fileName: 'example.pdf',
relevance: 0.85,
type: 'file',
pages: [1, 2, 3],
content: 'Some content',
metadata: {
existingField: 'value',
},
},
];
getFiles.mockResolvedValue([
{
file_id: 'file_123',
filename: 'example_from_db.pdf',
source: 'gcs',
},
]);
const result = await enhanceSourcesWithMetadata(sources, mockCustomConfig);
expect(result[0]).toEqual({
fileId: 'file_123',
fileName: 'example_from_db.pdf',
relevance: 0.85,
type: 'file',
pages: [1, 2, 3],
content: 'Some content',
metadata: {
existingField: 'value',
storageType: 'gcs',
},
});
});
it('should handle missing file metadata gracefully', async () => {
const sources = [
{
fileId: 'file_789',
fileName: 'missing.pdf',
relevance: 0.9,
type: 'file',
},
];
getFiles.mockResolvedValue([]);
const result = await enhanceSourcesWithMetadata(sources, mockCustomConfig);
expect(result[0]).toEqual({
fileId: 'file_789',
fileName: 'missing.pdf',
relevance: 0.9,
type: 'file',
metadata: {
storageType: 'local', // Falls back to customConfig.fileStrategy
},
});
});
it('should handle database errors gracefully', async () => {
const sources = [
{
fileId: 'file_123',
fileName: 'example.pdf',
relevance: 0.85,
type: 'file',
},
];
getFiles.mockRejectedValue(new Error('Database error'));
const result = await enhanceSourcesWithMetadata(sources, mockCustomConfig);
expect(result[0]).toEqual({
fileId: 'file_123',
fileName: 'example.pdf',
relevance: 0.85,
type: 'file',
metadata: {
storageType: 'local',
},
});
});
it('should deduplicate file IDs when querying database', async () => {
const sources = [
{ fileId: 'file_123', fileName: 'doc1.pdf', relevance: 0.9, type: 'file' },
{ fileId: 'file_123', fileName: 'doc1.pdf', relevance: 0.8, type: 'file' },
{ fileId: 'file_456', fileName: 'doc2.pdf', relevance: 0.7, type: 'file' },
];
getFiles.mockResolvedValue([
{ file_id: 'file_123', filename: 'document1.pdf', source: 's3' },
{ file_id: 'file_456', filename: 'document2.pdf', source: 'local' },
]);
await enhanceSourcesWithMetadata(sources, mockCustomConfig);
expect(getFiles).toHaveBeenCalledWith({ file_id: { $in: ['file_123', 'file_456'] } });
});
});
});