mirror of
https://github.com/danny-avila/LibreChat.git
synced 2025-09-22 08:12:00 +02:00

bugfix: Enhance Agent and AgentCategory schemas with new fields for category, support contact, and promotion status refactored and moved agent category methods and schema to data-schema package 🔧 fix: Merge and Rebase Conflicts - Move AgentCategory from api/models to @packages/data-schemas structure - Add schema, types, methods, and model following codebase conventions - Implement auto-seeding of default categories during AppService startup - Update marketplace controller to use new data-schemas methods - Remove old model file and standalone seed script refactor: unify agent marketplace to single endpoint with cursor pagination - Replace multiple marketplace routes with unified /marketplace endpoint - Add query string controls: category, search, limit, cursor, promoted, requiredPermission - Implement cursor-based pagination replacing page-based system - Integrate ACL permissions for proper access control - Fix ObjectId constructor error in Agent model - Update React components to use unified useGetMarketplaceAgentsQuery hook - Enhance type safety and remove deprecated useDynamicAgentQuery - Update tests for new marketplace architecture -Known issues: see more button after category switching + Unit tests feat: add icon property to ProcessedAgentCategory interface - Add useMarketplaceAgentsInfiniteQuery and useGetAgentCategoriesQuery to client/src/data-provider/Agents/ - Replace manual pagination in AgentGrid with infinite query pattern - Update imports to use local data provider instead of librechat-data-provider - Add proper permission handling with PERMISSION_BITS.VIEW/EDIT constants - Improve agent access control by adding requiredPermission validation in backend - Remove manual cursor/state management in favor of infinite query built-ins - Maintain existing search and category filtering functionality refactor: consolidate agent marketplace endpoints into main agents API and improve data management consistency - Remove dedicated marketplace controller and routes, merging functionality into main agents v1 API - Add countPromotedAgents function to Agent model for promoted agents count - Enhance getListAgents handler with marketplace filtering (category, search, promoted status) - Move getAgentCategories from marketplace to v1 controller with same functionality - Update agent mutations to invalidate marketplace queries and handle multiple permission levels - Improve cache management by updating all agent query variants (VIEW/EDIT permissions) - Consolidate agent data access patterns for better maintainability and consistency - Remove duplicate marketplace route definitions and middleware selected view only agents injected in the drop down fix: remove minlength validation for support contact name in agent schema feat: add validation and error messages for agent name in AgentConfig and AgentPanel fix: update agent permission check logic in AgentPanel to simplify condition Fix linting WIP Fix Unit tests WIP ESLint fixes eslint fix refactor: enhance isDuplicateVersion function in Agent model for improved comparison logic - Introduced handling for undefined/null values in array and object comparisons. - Normalized array comparisons to treat undefined/null as empty arrays. - Added deep comparison for objects and improved handling of primitive values. - Enhanced projectIds comparison to ensure consistent MongoDB ObjectId handling. refactor: remove redundant properties from IAgent interface in agent schema chore: update localization for agent detail component and clean up imports ci: update access middleware tests chore: remove unused PermissionTypes import from Role model ci: update AclEntry model tests ci: update button accessibility labels in AgentDetail tests refactor: update exhaustive dep. lint warning 🔧 fix: Fixed agent actions access feat: Add role-level permissions for agent sharing people picker - Add PEOPLE_PICKER permission type with VIEW_USERS and VIEW_GROUPS permissions - Create custom middleware for query-aware permission validation - Implement permission-based type filtering in PeoplePicker component - Hide people picker UI when user lacks permissions, show only public toggle - Support granular access: users-only, groups-only, or mixed search modes refactor: Replace marketplace interface config with permission-based system - Add MARKETPLACE permission type to handle marketplace access control - Update interface configuration to use role-based marketplace settings (admin/user) - Replace direct marketplace boolean config with permission-based checks - Modify frontend components to use marketplace permissions instead of interface config - Update agent query hooks to use marketplace permissions for determining permission levels - Add marketplace configuration structure similar to peoplePicker in YAML config - Backend now sets MARKETPLACE permissions based on interface configuration - When marketplace enabled: users get agents with EDIT permissions in dropdown lists (builder mode) - When marketplace disabled: users get agents with VIEW permissions in dropdown lists (browse mode) 🔧 fix: Redirect to New Chat if No Marketplace Access and Required Agent Name Placeholder (#8213) * Fix: Fix the redirect to new chat page if access to marketplace is denied * Fixed the required agent name placeholder --------- Co-authored-by: Atef Bellaaj <slalom.bellaaj@external.daimlertruck.com> chore: fix tests, remove unnecessary imports refactor: Implement permission checks for file access via agents - Updated `hasAccessToFilesViaAgent` to utilize permission checks for VIEW and EDIT access. - Replaced project-based access validation with permission-based checks. - Enhanced tests to cover new permission logic and ensure proper access control for files associated with agents. - Cleaned up imports and initialized models in test files for consistency. refactor: Enhance test setup and cleanup for file access control - Introduced modelsToCleanup array to track models added during tests for proper cleanup. - Updated afterAll hooks in test files to ensure all collections are cleared and only added models are deleted. - Improved consistency in model initialization across test files. - Added comments for clarity on cleanup processes and test data management. chore: Update Jest configuration and test setup for improved timeout handling - Added a global test timeout of 30 seconds in jest.config.js. - Configured jest.setTimeout in jestSetup.js to allow individual test overrides if needed. - Enhanced test reliability by ensuring consistent timeout settings across all tests. refactor: Implement file access filtering based on agent permissions - Introduced `filterFilesByAgentAccess` function to filter files based on user access through agents. - Updated `getFiles` and `primeFiles` functions to utilize the new filtering logic. - Moved `hasAccessToFilesViaAgent` function from the File model to permission services, adjusting imports accordingly - Enhanced tests to ensure proper access control and filtering behavior for files associated with agents. fix: make support_contact field a nested object rather than a sub-document refactor: Update support_contact field initialization in agent model - Removed handling for empty support_contact object in createAgent function. - Changed default value of support_contact in agent schema to undefined. test: Add comprehensive tests for support_contact field handling and versioning refactor: remove unused avatar upload mutation field and add informational toast for success chore: add missing SidePanelProvider for AgentMarketplace and organize imports fix: resolve agent selection race condition in marketplace HandleStartChat - Set agent in localStorage before newConversation to prevent useSelectorEffects from auto-selecting previous agent fix: resolve agent dropdown showing raw ID instead of agent info from URL - Add proactive agent fetching when agent_id is present in URL parameters - Inject fetched agent into agents cache so dropdowns display proper name/avatar - Use useAgentsMap dependency to ensure proper cache initialization timing - Prevents raw agent IDs from showing in UI when visiting shared agent links Fix: Agents endpoint renamed to "My Agent" for less confusion with the Marketplace agents. chore: fix ESLint issues and Test Mocks ci: update permissions structure in loadDefaultInterface tests - Refactored permissions for MEMORY and added new permissions for MARKETPLACE and PEOPLE_PICKER. - Ensured consistent structure for permissions across different types. feat: support_contact validation to allow empty email strings
373 lines
11 KiB
JavaScript
373 lines
11 KiB
JavaScript
const mongoose = require('mongoose');
|
|
const { v4: uuidv4 } = require('uuid');
|
|
const { MongoMemoryServer } = require('mongodb-memory-server');
|
|
const { createModels } = require('@librechat/data-schemas');
|
|
const { getFiles, createFile } = require('./File');
|
|
const { createAgent } = require('./Agent');
|
|
const { grantPermission } = require('~/server/services/PermissionService');
|
|
const { seedDefaultRoles } = require('~/models');
|
|
|
|
let File;
|
|
let Agent;
|
|
let AclEntry;
|
|
let User;
|
|
let modelsToCleanup = [];
|
|
|
|
describe('File Access Control', () => {
|
|
let mongoServer;
|
|
|
|
beforeAll(async () => {
|
|
mongoServer = await MongoMemoryServer.create();
|
|
const mongoUri = mongoServer.getUri();
|
|
await mongoose.connect(mongoUri);
|
|
|
|
// Initialize all models
|
|
const models = createModels(mongoose);
|
|
|
|
// Track which models we're adding
|
|
modelsToCleanup = Object.keys(models);
|
|
|
|
// Register models on mongoose.models so methods can access them
|
|
const dbModels = require('~/db/models');
|
|
Object.assign(mongoose.models, dbModels);
|
|
|
|
File = dbModels.File;
|
|
Agent = dbModels.Agent;
|
|
AclEntry = dbModels.AclEntry;
|
|
User = dbModels.User;
|
|
|
|
// Seed default roles
|
|
await seedDefaultRoles();
|
|
});
|
|
|
|
afterAll(async () => {
|
|
// Clean up all collections before disconnecting
|
|
const collections = mongoose.connection.collections;
|
|
for (const key in collections) {
|
|
await collections[key].deleteMany({});
|
|
}
|
|
|
|
// Clear only the models we added
|
|
for (const modelName of modelsToCleanup) {
|
|
if (mongoose.models[modelName]) {
|
|
delete mongoose.models[modelName];
|
|
}
|
|
}
|
|
|
|
await mongoose.disconnect();
|
|
await mongoServer.stop();
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
await File.deleteMany({});
|
|
await Agent.deleteMany({});
|
|
await AclEntry.deleteMany({});
|
|
await User.deleteMany({});
|
|
// Don't delete AccessRole as they are seeded defaults needed for tests
|
|
});
|
|
|
|
describe('hasAccessToFilesViaAgent', () => {
|
|
it('should efficiently check access for multiple files at once', async () => {
|
|
const userId = new mongoose.Types.ObjectId();
|
|
const authorId = new mongoose.Types.ObjectId();
|
|
const agentId = uuidv4();
|
|
const fileIds = [uuidv4(), uuidv4(), uuidv4(), uuidv4()];
|
|
|
|
// Create users
|
|
await User.create({
|
|
_id: userId,
|
|
email: 'user@example.com',
|
|
emailVerified: true,
|
|
provider: 'local',
|
|
});
|
|
|
|
await User.create({
|
|
_id: authorId,
|
|
email: 'author@example.com',
|
|
emailVerified: true,
|
|
provider: 'local',
|
|
});
|
|
|
|
// Create files
|
|
for (const fileId of fileIds) {
|
|
await createFile({
|
|
user: authorId,
|
|
file_id: fileId,
|
|
filename: `file-${fileId}.txt`,
|
|
filepath: `/uploads/${fileId}`,
|
|
});
|
|
}
|
|
|
|
// Create agent with only first two files attached
|
|
const agent = await createAgent({
|
|
id: agentId,
|
|
name: 'Test Agent',
|
|
author: authorId,
|
|
model: 'gpt-4',
|
|
provider: 'openai',
|
|
tool_resources: {
|
|
file_search: {
|
|
file_ids: [fileIds[0], fileIds[1]],
|
|
},
|
|
},
|
|
});
|
|
|
|
// Grant EDIT permission to user on the agent
|
|
await grantPermission({
|
|
principalType: 'user',
|
|
principalId: userId,
|
|
resourceType: 'agent',
|
|
resourceId: agent._id,
|
|
accessRoleId: 'agent_editor',
|
|
grantedBy: authorId,
|
|
});
|
|
|
|
// Check access for all files
|
|
const { hasAccessToFilesViaAgent } = require('~/server/services/Files/permissions');
|
|
const accessMap = await hasAccessToFilesViaAgent(userId.toString(), fileIds, agentId);
|
|
|
|
// Should have access only to the first two files
|
|
expect(accessMap.get(fileIds[0])).toBe(true);
|
|
expect(accessMap.get(fileIds[1])).toBe(true);
|
|
expect(accessMap.get(fileIds[2])).toBe(false);
|
|
expect(accessMap.get(fileIds[3])).toBe(false);
|
|
});
|
|
|
|
it('should grant access to all files when user is the agent author', async () => {
|
|
const authorId = new mongoose.Types.ObjectId();
|
|
const agentId = uuidv4();
|
|
const fileIds = [uuidv4(), uuidv4(), uuidv4()];
|
|
|
|
// Create author user
|
|
await User.create({
|
|
_id: authorId,
|
|
email: 'author@example.com',
|
|
emailVerified: true,
|
|
provider: 'local',
|
|
});
|
|
|
|
// Create agent
|
|
await createAgent({
|
|
id: agentId,
|
|
name: 'Test Agent',
|
|
author: authorId,
|
|
model: 'gpt-4',
|
|
provider: 'openai',
|
|
tool_resources: {
|
|
file_search: {
|
|
file_ids: [fileIds[0]], // Only one file attached
|
|
},
|
|
},
|
|
});
|
|
|
|
// Check access as the author
|
|
const { hasAccessToFilesViaAgent } = require('~/server/services/Files/permissions');
|
|
const accessMap = await hasAccessToFilesViaAgent(authorId.toString(), fileIds, agentId);
|
|
|
|
// Author should have access to all files
|
|
expect(accessMap.get(fileIds[0])).toBe(true);
|
|
expect(accessMap.get(fileIds[1])).toBe(true);
|
|
expect(accessMap.get(fileIds[2])).toBe(true);
|
|
});
|
|
|
|
it('should handle non-existent agent gracefully', async () => {
|
|
const userId = new mongoose.Types.ObjectId();
|
|
const fileIds = [uuidv4(), uuidv4()];
|
|
|
|
// Create user
|
|
await User.create({
|
|
_id: userId,
|
|
email: 'user@example.com',
|
|
emailVerified: true,
|
|
provider: 'local',
|
|
});
|
|
|
|
const { hasAccessToFilesViaAgent } = require('~/server/services/Files/permissions');
|
|
const accessMap = await hasAccessToFilesViaAgent(
|
|
userId.toString(),
|
|
fileIds,
|
|
'non-existent-agent',
|
|
);
|
|
|
|
// Should have no access to any files
|
|
expect(accessMap.get(fileIds[0])).toBe(false);
|
|
expect(accessMap.get(fileIds[1])).toBe(false);
|
|
});
|
|
|
|
it('should deny access when user only has VIEW permission', async () => {
|
|
const userId = new mongoose.Types.ObjectId();
|
|
const authorId = new mongoose.Types.ObjectId();
|
|
const agentId = uuidv4();
|
|
const fileIds = [uuidv4(), uuidv4()];
|
|
|
|
// Create users
|
|
await User.create({
|
|
_id: userId,
|
|
email: 'user@example.com',
|
|
emailVerified: true,
|
|
provider: 'local',
|
|
});
|
|
|
|
await User.create({
|
|
_id: authorId,
|
|
email: 'author@example.com',
|
|
emailVerified: true,
|
|
provider: 'local',
|
|
});
|
|
|
|
// Create agent with files
|
|
const agent = await createAgent({
|
|
id: agentId,
|
|
name: 'View-Only Agent',
|
|
author: authorId,
|
|
model: 'gpt-4',
|
|
provider: 'openai',
|
|
tool_resources: {
|
|
file_search: {
|
|
file_ids: fileIds,
|
|
},
|
|
},
|
|
});
|
|
|
|
// Grant only VIEW permission to user on the agent
|
|
await grantPermission({
|
|
principalType: 'user',
|
|
principalId: userId,
|
|
resourceType: 'agent',
|
|
resourceId: agent._id,
|
|
accessRoleId: 'agent_viewer',
|
|
grantedBy: authorId,
|
|
});
|
|
|
|
// Check access for files
|
|
const { hasAccessToFilesViaAgent } = require('~/server/services/Files/permissions');
|
|
const accessMap = await hasAccessToFilesViaAgent(userId.toString(), fileIds, agentId);
|
|
|
|
// Should have no access to any files when only VIEW permission
|
|
expect(accessMap.get(fileIds[0])).toBe(false);
|
|
expect(accessMap.get(fileIds[1])).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('getFiles with agent access control', () => {
|
|
test('should return files owned by user and files accessible through agent', async () => {
|
|
const authorId = new mongoose.Types.ObjectId();
|
|
const userId = new mongoose.Types.ObjectId();
|
|
const agentId = `agent_${uuidv4()}`;
|
|
const ownedFileId = `file_${uuidv4()}`;
|
|
const sharedFileId = `file_${uuidv4()}`;
|
|
const inaccessibleFileId = `file_${uuidv4()}`;
|
|
|
|
// Create users
|
|
await User.create({
|
|
_id: userId,
|
|
email: 'user@example.com',
|
|
emailVerified: true,
|
|
provider: 'local',
|
|
});
|
|
|
|
await User.create({
|
|
_id: authorId,
|
|
email: 'author@example.com',
|
|
emailVerified: true,
|
|
provider: 'local',
|
|
});
|
|
|
|
// Create agent with shared file
|
|
const agent = await createAgent({
|
|
id: agentId,
|
|
name: 'Shared Agent',
|
|
provider: 'test',
|
|
model: 'test-model',
|
|
author: authorId,
|
|
tool_resources: {
|
|
file_search: {
|
|
file_ids: [sharedFileId],
|
|
},
|
|
},
|
|
});
|
|
|
|
// Grant EDIT permission to user on the agent
|
|
await grantPermission({
|
|
principalType: 'user',
|
|
principalId: userId,
|
|
resourceType: 'agent',
|
|
resourceId: agent._id,
|
|
accessRoleId: 'agent_editor',
|
|
grantedBy: authorId,
|
|
});
|
|
|
|
// Create files
|
|
await createFile({
|
|
file_id: ownedFileId,
|
|
user: userId,
|
|
filename: 'owned.txt',
|
|
filepath: '/uploads/owned.txt',
|
|
type: 'text/plain',
|
|
bytes: 100,
|
|
});
|
|
|
|
await createFile({
|
|
file_id: sharedFileId,
|
|
user: authorId,
|
|
filename: 'shared.txt',
|
|
filepath: '/uploads/shared.txt',
|
|
type: 'text/plain',
|
|
bytes: 200,
|
|
embedded: true,
|
|
});
|
|
|
|
await createFile({
|
|
file_id: inaccessibleFileId,
|
|
user: authorId,
|
|
filename: 'inaccessible.txt',
|
|
filepath: '/uploads/inaccessible.txt',
|
|
type: 'text/plain',
|
|
bytes: 300,
|
|
});
|
|
|
|
// Get all files first
|
|
const allFiles = await getFiles(
|
|
{ file_id: { $in: [ownedFileId, sharedFileId, inaccessibleFileId] } },
|
|
null,
|
|
{ text: 0 },
|
|
);
|
|
|
|
// Then filter by access control
|
|
const { filterFilesByAgentAccess } = require('~/server/services/Files/permissions');
|
|
const files = await filterFilesByAgentAccess(allFiles, userId.toString(), agentId);
|
|
|
|
expect(files).toHaveLength(2);
|
|
expect(files.map((f) => f.file_id)).toContain(ownedFileId);
|
|
expect(files.map((f) => f.file_id)).toContain(sharedFileId);
|
|
expect(files.map((f) => f.file_id)).not.toContain(inaccessibleFileId);
|
|
});
|
|
|
|
test('should return all files when no userId/agentId provided', async () => {
|
|
const userId = new mongoose.Types.ObjectId();
|
|
const fileId1 = `file_${uuidv4()}`;
|
|
const fileId2 = `file_${uuidv4()}`;
|
|
|
|
await createFile({
|
|
file_id: fileId1,
|
|
user: userId,
|
|
filename: 'file1.txt',
|
|
filepath: '/uploads/file1.txt',
|
|
type: 'text/plain',
|
|
bytes: 100,
|
|
});
|
|
|
|
await createFile({
|
|
file_id: fileId2,
|
|
user: new mongoose.Types.ObjectId(),
|
|
filename: 'file2.txt',
|
|
filepath: '/uploads/file2.txt',
|
|
type: 'text/plain',
|
|
bytes: 200,
|
|
});
|
|
|
|
const files = await getFiles({ file_id: { $in: [fileId1, fileId2] } });
|
|
expect(files).toHaveLength(2);
|
|
});
|
|
});
|
|
});
|