mirror of
https://github.com/danny-avila/LibreChat.git
synced 2025-09-22 08:12:00 +02:00

* fix: prevent crash on duplicate message ID Added error handling for MongoDB error code 11000 (duplicate key error) in saveMessage function. This prevents the application from crashing when trying to save messages with duplicate IDs, which can happen during aborted requests. Now logs a warning and continues execution safely. Closes: #5774 Closes: #5776 * fix: address ESLint issues in Message.js --------- Co-authored-by: odrec <odrec@users.noreply.github.com>
358 lines
12 KiB
JavaScript
358 lines
12 KiB
JavaScript
const { z } = require('zod');
|
|
const Message = require('./schema/messageSchema');
|
|
const { logger } = require('~/config');
|
|
|
|
const idSchema = z.string().uuid();
|
|
|
|
/**
|
|
* Saves a message in the database.
|
|
*
|
|
* @async
|
|
* @function saveMessage
|
|
* @param {Express.Request} req - The request object containing user information.
|
|
* @param {Object} params - The message data object.
|
|
* @param {string} params.endpoint - The endpoint where the message originated.
|
|
* @param {string} params.iconURL - The URL of the sender's icon.
|
|
* @param {string} params.messageId - The unique identifier for the message.
|
|
* @param {string} params.newMessageId - The new unique identifier for the message (if applicable).
|
|
* @param {string} params.conversationId - The identifier of the conversation.
|
|
* @param {string} [params.parentMessageId] - The identifier of the parent message, if any.
|
|
* @param {string} params.sender - The identifier of the sender.
|
|
* @param {string} params.text - The text content of the message.
|
|
* @param {boolean} params.isCreatedByUser - Indicates if the message was created by the user.
|
|
* @param {string} [params.error] - Any error associated with the message.
|
|
* @param {boolean} [params.unfinished] - Indicates if the message is unfinished.
|
|
* @param {Object[]} [params.files] - An array of files associated with the message.
|
|
* @param {string} [params.finish_reason] - Reason for finishing the message.
|
|
* @param {number} [params.tokenCount] - The number of tokens in the message.
|
|
* @param {string} [params.plugin] - Plugin associated with the message.
|
|
* @param {string[]} [params.plugins] - An array of plugins associated with the message.
|
|
* @param {string} [params.model] - The model used to generate the message.
|
|
* @param {Object} [metadata] - Additional metadata for this operation
|
|
* @param {string} [metadata.context] - The context of the operation
|
|
* @returns {Promise<TMessage>} The updated or newly inserted message document.
|
|
* @throws {Error} If there is an error in saving the message.
|
|
*/
|
|
async function saveMessage(req, params, metadata) {
|
|
if (!req?.user?.id) {
|
|
throw new Error('User not authenticated');
|
|
}
|
|
|
|
const validConvoId = idSchema.safeParse(params.conversationId);
|
|
if (!validConvoId.success) {
|
|
logger.warn(`Invalid conversation ID: ${params.conversationId}`);
|
|
logger.info(`---\`saveMessage\` context: ${metadata?.context}`);
|
|
logger.info(`---Invalid conversation ID Params: ${JSON.stringify(params, null, 2)}`);
|
|
return;
|
|
}
|
|
|
|
try {
|
|
const update = {
|
|
...params,
|
|
user: req.user.id,
|
|
messageId: params.newMessageId || params.messageId,
|
|
};
|
|
|
|
if (req?.body?.isTemporary) {
|
|
const expiredAt = new Date();
|
|
expiredAt.setDate(expiredAt.getDate() + 30);
|
|
update.expiredAt = expiredAt;
|
|
} else {
|
|
update.expiredAt = null;
|
|
}
|
|
|
|
const message = await Message.findOneAndUpdate(
|
|
{ messageId: params.messageId, user: req.user.id },
|
|
update,
|
|
{ upsert: true, new: true },
|
|
);
|
|
|
|
return message.toObject();
|
|
} catch (err) {
|
|
logger.error('Error saving message:', err);
|
|
logger.info(`---\`saveMessage\` context: ${metadata?.context}`);
|
|
|
|
// Check if this is a duplicate key error (MongoDB error code 11000)
|
|
if (err.code === 11000 && err.message.includes('duplicate key error')) {
|
|
// Log the duplicate key error but don't crash the application
|
|
logger.warn(`Duplicate messageId detected: ${params.messageId}. Continuing execution.`);
|
|
|
|
try {
|
|
// Try to find the existing message with this ID
|
|
const existingMessage = await Message.findOne({
|
|
messageId: params.messageId,
|
|
user: req.user.id,
|
|
});
|
|
|
|
// If we found it, return it
|
|
if (existingMessage) {
|
|
return existingMessage.toObject();
|
|
}
|
|
|
|
// If we can't find it (unlikely but possible in race conditions)
|
|
return {
|
|
...params,
|
|
messageId: params.messageId,
|
|
user: req.user.id,
|
|
};
|
|
} catch (findError) {
|
|
// If the findOne also fails, log it but don't crash
|
|
logger.warn(`Could not retrieve existing message with ID ${params.messageId}: ${findError.message}`);
|
|
return {
|
|
...params,
|
|
messageId: params.messageId,
|
|
user: req.user.id,
|
|
};
|
|
}
|
|
}
|
|
|
|
throw err; // Re-throw other errors
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Saves multiple messages in the database in bulk.
|
|
*
|
|
* @async
|
|
* @function bulkSaveMessages
|
|
* @param {Object[]} messages - An array of message objects to save.
|
|
* @param {boolean} [overrideTimestamp=false] - Indicates whether to override the timestamps of the messages. Defaults to false.
|
|
* @returns {Promise<Object>} The result of the bulk write operation.
|
|
* @throws {Error} If there is an error in saving messages in bulk.
|
|
*/
|
|
async function bulkSaveMessages(messages, overrideTimestamp = false) {
|
|
try {
|
|
const bulkOps = messages.map((message) => ({
|
|
updateOne: {
|
|
filter: { messageId: message.messageId },
|
|
update: message,
|
|
timestamps: !overrideTimestamp,
|
|
upsert: true,
|
|
},
|
|
}));
|
|
|
|
const result = await Message.bulkWrite(bulkOps);
|
|
return result;
|
|
} catch (err) {
|
|
logger.error('Error saving messages in bulk:', err);
|
|
throw err;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Records a message in the database.
|
|
*
|
|
* @async
|
|
* @function recordMessage
|
|
* @param {Object} params - The message data object.
|
|
* @param {string} params.user - The identifier of the user.
|
|
* @param {string} params.endpoint - The endpoint where the message originated.
|
|
* @param {string} params.messageId - The unique identifier for the message.
|
|
* @param {string} params.conversationId - The identifier of the conversation.
|
|
* @param {string} [params.parentMessageId] - The identifier of the parent message, if any.
|
|
* @param {Partial<TMessage>} rest - Any additional properties from the TMessage typedef not explicitly listed.
|
|
* @returns {Promise<Object>} The updated or newly inserted message document.
|
|
* @throws {Error} If there is an error in saving the message.
|
|
*/
|
|
async function recordMessage({
|
|
user,
|
|
endpoint,
|
|
messageId,
|
|
conversationId,
|
|
parentMessageId,
|
|
...rest
|
|
}) {
|
|
try {
|
|
// No parsing of convoId as may use threadId
|
|
const message = {
|
|
user,
|
|
endpoint,
|
|
messageId,
|
|
conversationId,
|
|
parentMessageId,
|
|
...rest,
|
|
};
|
|
|
|
return await Message.findOneAndUpdate({ user, messageId }, message, {
|
|
upsert: true,
|
|
new: true,
|
|
});
|
|
} catch (err) {
|
|
logger.error('Error recording message:', err);
|
|
throw err;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Updates the text of a message.
|
|
*
|
|
* @async
|
|
* @function updateMessageText
|
|
* @param {Object} params - The update data object.
|
|
* @param {Object} req - The request object.
|
|
* @param {string} params.messageId - The unique identifier for the message.
|
|
* @param {string} params.text - The new text content of the message.
|
|
* @returns {Promise<void>}
|
|
* @throws {Error} If there is an error in updating the message text.
|
|
*/
|
|
async function updateMessageText(req, { messageId, text }) {
|
|
try {
|
|
await Message.updateOne({ messageId, user: req.user.id }, { text });
|
|
} catch (err) {
|
|
logger.error('Error updating message text:', err);
|
|
throw err;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Updates a message.
|
|
*
|
|
* @async
|
|
* @function updateMessage
|
|
* @param {Object} req - The request object.
|
|
* @param {Object} message - The message object containing update data.
|
|
* @param {string} message.messageId - The unique identifier for the message.
|
|
* @param {string} [message.text] - The new text content of the message.
|
|
* @param {Object[]} [message.files] - The files associated with the message.
|
|
* @param {boolean} [message.isCreatedByUser] - Indicates if the message was created by the user.
|
|
* @param {string} [message.sender] - The identifier of the sender.
|
|
* @param {number} [message.tokenCount] - The number of tokens in the message.
|
|
* @param {Object} [metadata] - The operation metadata
|
|
* @param {string} [metadata.context] - The operation metadata
|
|
* @returns {Promise<TMessage>} The updated message document.
|
|
* @throws {Error} If there is an error in updating the message or if the message is not found.
|
|
*/
|
|
async function updateMessage(req, message, metadata) {
|
|
try {
|
|
const { messageId, ...update } = message;
|
|
const updatedMessage = await Message.findOneAndUpdate(
|
|
{ messageId, user: req.user.id },
|
|
update,
|
|
{
|
|
new: true,
|
|
},
|
|
);
|
|
|
|
if (!updatedMessage) {
|
|
throw new Error('Message not found or user not authorized.');
|
|
}
|
|
|
|
return {
|
|
messageId: updatedMessage.messageId,
|
|
conversationId: updatedMessage.conversationId,
|
|
parentMessageId: updatedMessage.parentMessageId,
|
|
sender: updatedMessage.sender,
|
|
text: updatedMessage.text,
|
|
isCreatedByUser: updatedMessage.isCreatedByUser,
|
|
tokenCount: updatedMessage.tokenCount,
|
|
};
|
|
} catch (err) {
|
|
logger.error('Error updating message:', err);
|
|
if (metadata && metadata?.context) {
|
|
logger.info(`---\`updateMessage\` context: ${metadata.context}`);
|
|
}
|
|
throw err;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Deletes messages in a conversation since a specific message.
|
|
*
|
|
* @async
|
|
* @function deleteMessagesSince
|
|
* @param {Object} params - The parameters object.
|
|
* @param {Object} req - The request object.
|
|
* @param {string} params.messageId - The unique identifier for the message.
|
|
* @param {string} params.conversationId - The identifier of the conversation.
|
|
* @returns {Promise<Number>} The number of deleted messages.
|
|
* @throws {Error} If there is an error in deleting messages.
|
|
*/
|
|
async function deleteMessagesSince(req, { messageId, conversationId }) {
|
|
try {
|
|
const message = await Message.findOne({ messageId, user: req.user.id }).lean();
|
|
|
|
if (message) {
|
|
const query = Message.find({ conversationId, user: req.user.id });
|
|
return await query.deleteMany({
|
|
createdAt: { $gt: message.createdAt },
|
|
});
|
|
}
|
|
return undefined;
|
|
} catch (err) {
|
|
logger.error('Error deleting messages:', err);
|
|
throw err;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Retrieves messages from the database.
|
|
* @async
|
|
* @function getMessages
|
|
* @param {Record<string, unknown>} filter - The filter criteria.
|
|
* @param {string | undefined} [select] - The fields to select.
|
|
* @returns {Promise<TMessage[]>} The messages that match the filter criteria.
|
|
* @throws {Error} If there is an error in retrieving messages.
|
|
*/
|
|
async function getMessages(filter, select) {
|
|
try {
|
|
if (select) {
|
|
return await Message.find(filter).select(select).sort({ createdAt: 1 }).lean();
|
|
}
|
|
|
|
return await Message.find(filter).sort({ createdAt: 1 }).lean();
|
|
} catch (err) {
|
|
logger.error('Error getting messages:', err);
|
|
throw err;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Retrieves a single message from the database.
|
|
* @async
|
|
* @function getMessage
|
|
* @param {{ user: string, messageId: string }} params - The search parameters
|
|
* @returns {Promise<TMessage | null>} The message that matches the criteria or null if not found
|
|
* @throws {Error} If there is an error in retrieving the message
|
|
*/
|
|
async function getMessage({ user, messageId }) {
|
|
try {
|
|
return await Message.findOne({
|
|
user,
|
|
messageId,
|
|
}).lean();
|
|
} catch (err) {
|
|
logger.error('Error getting message:', err);
|
|
throw err;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Deletes messages from the database.
|
|
*
|
|
* @async
|
|
* @function deleteMessages
|
|
* @param {Object} filter - The filter criteria to find messages to delete.
|
|
* @returns {Promise<Object>} The metadata with count of deleted messages.
|
|
* @throws {Error} If there is an error in deleting messages.
|
|
*/
|
|
async function deleteMessages(filter) {
|
|
try {
|
|
return await Message.deleteMany(filter);
|
|
} catch (err) {
|
|
logger.error('Error deleting messages:', err);
|
|
throw err;
|
|
}
|
|
}
|
|
|
|
module.exports = {
|
|
Message,
|
|
saveMessage,
|
|
bulkSaveMessages,
|
|
recordMessage,
|
|
updateMessageText,
|
|
updateMessage,
|
|
deleteMessagesSince,
|
|
getMessages,
|
|
getMessage,
|
|
deleteMessages,
|
|
};
|