mirror of
https://github.com/danny-avila/LibreChat.git
synced 2025-12-20 10:20:15 +01:00
bugfix: Enhance Agent and AgentCategory schemas with new fields for category, support contact, and promotion status refactored and moved agent category methods and schema to data-schema package 🔧 fix: Merge and Rebase Conflicts - Move AgentCategory from api/models to @packages/data-schemas structure - Add schema, types, methods, and model following codebase conventions - Implement auto-seeding of default categories during AppService startup - Update marketplace controller to use new data-schemas methods - Remove old model file and standalone seed script refactor: unify agent marketplace to single endpoint with cursor pagination - Replace multiple marketplace routes with unified /marketplace endpoint - Add query string controls: category, search, limit, cursor, promoted, requiredPermission - Implement cursor-based pagination replacing page-based system - Integrate ACL permissions for proper access control - Fix ObjectId constructor error in Agent model - Update React components to use unified useGetMarketplaceAgentsQuery hook - Enhance type safety and remove deprecated useDynamicAgentQuery - Update tests for new marketplace architecture -Known issues: see more button after category switching + Unit tests feat: add icon property to ProcessedAgentCategory interface - Add useMarketplaceAgentsInfiniteQuery and useGetAgentCategoriesQuery to client/src/data-provider/Agents/ - Replace manual pagination in AgentGrid with infinite query pattern - Update imports to use local data provider instead of librechat-data-provider - Add proper permission handling with PERMISSION_BITS.VIEW/EDIT constants - Improve agent access control by adding requiredPermission validation in backend - Remove manual cursor/state management in favor of infinite query built-ins - Maintain existing search and category filtering functionality refactor: consolidate agent marketplace endpoints into main agents API and improve data management consistency - Remove dedicated marketplace controller and routes, merging functionality into main agents v1 API - Add countPromotedAgents function to Agent model for promoted agents count - Enhance getListAgents handler with marketplace filtering (category, search, promoted status) - Move getAgentCategories from marketplace to v1 controller with same functionality - Update agent mutations to invalidate marketplace queries and handle multiple permission levels - Improve cache management by updating all agent query variants (VIEW/EDIT permissions) - Consolidate agent data access patterns for better maintainability and consistency - Remove duplicate marketplace route definitions and middleware selected view only agents injected in the drop down fix: remove minlength validation for support contact name in agent schema feat: add validation and error messages for agent name in AgentConfig and AgentPanel fix: update agent permission check logic in AgentPanel to simplify condition Fix linting WIP Fix Unit tests WIP ESLint fixes eslint fix refactor: enhance isDuplicateVersion function in Agent model for improved comparison logic - Introduced handling for undefined/null values in array and object comparisons. - Normalized array comparisons to treat undefined/null as empty arrays. - Added deep comparison for objects and improved handling of primitive values. - Enhanced projectIds comparison to ensure consistent MongoDB ObjectId handling. refactor: remove redundant properties from IAgent interface in agent schema chore: update localization for agent detail component and clean up imports ci: update access middleware tests chore: remove unused PermissionTypes import from Role model ci: update AclEntry model tests ci: update button accessibility labels in AgentDetail tests refactor: update exhaustive dep. lint warning 🔧 fix: Fixed agent actions access feat: Add role-level permissions for agent sharing people picker - Add PEOPLE_PICKER permission type with VIEW_USERS and VIEW_GROUPS permissions - Create custom middleware for query-aware permission validation - Implement permission-based type filtering in PeoplePicker component - Hide people picker UI when user lacks permissions, show only public toggle - Support granular access: users-only, groups-only, or mixed search modes refactor: Replace marketplace interface config with permission-based system - Add MARKETPLACE permission type to handle marketplace access control - Update interface configuration to use role-based marketplace settings (admin/user) - Replace direct marketplace boolean config with permission-based checks - Modify frontend components to use marketplace permissions instead of interface config - Update agent query hooks to use marketplace permissions for determining permission levels - Add marketplace configuration structure similar to peoplePicker in YAML config - Backend now sets MARKETPLACE permissions based on interface configuration - When marketplace enabled: users get agents with EDIT permissions in dropdown lists (builder mode) - When marketplace disabled: users get agents with VIEW permissions in dropdown lists (browse mode) 🔧 fix: Redirect to New Chat if No Marketplace Access and Required Agent Name Placeholder (#8213) * Fix: Fix the redirect to new chat page if access to marketplace is denied * Fixed the required agent name placeholder --------- Co-authored-by: Atef Bellaaj <slalom.bellaaj@external.daimlertruck.com> chore: fix tests, remove unnecessary imports refactor: Implement permission checks for file access via agents - Updated `hasAccessToFilesViaAgent` to utilize permission checks for VIEW and EDIT access. - Replaced project-based access validation with permission-based checks. - Enhanced tests to cover new permission logic and ensure proper access control for files associated with agents. - Cleaned up imports and initialized models in test files for consistency. refactor: Enhance test setup and cleanup for file access control - Introduced modelsToCleanup array to track models added during tests for proper cleanup. - Updated afterAll hooks in test files to ensure all collections are cleared and only added models are deleted. - Improved consistency in model initialization across test files. - Added comments for clarity on cleanup processes and test data management. chore: Update Jest configuration and test setup for improved timeout handling - Added a global test timeout of 30 seconds in jest.config.js. - Configured jest.setTimeout in jestSetup.js to allow individual test overrides if needed. - Enhanced test reliability by ensuring consistent timeout settings across all tests. refactor: Implement file access filtering based on agent permissions - Introduced `filterFilesByAgentAccess` function to filter files based on user access through agents. - Updated `getFiles` and `primeFiles` functions to utilize the new filtering logic. - Moved `hasAccessToFilesViaAgent` function from the File model to permission services, adjusting imports accordingly - Enhanced tests to ensure proper access control and filtering behavior for files associated with agents. fix: make support_contact field a nested object rather than a sub-document refactor: Update support_contact field initialization in agent model - Removed handling for empty support_contact object in createAgent function. - Changed default value of support_contact in agent schema to undefined. test: Add comprehensive tests for support_contact field handling and versioning refactor: remove unused avatar upload mutation field and add informational toast for success chore: add missing SidePanelProvider for AgentMarketplace and organize imports fix: resolve agent selection race condition in marketplace HandleStartChat - Set agent in localStorage before newConversation to prevent useSelectorEffects from auto-selecting previous agent fix: resolve agent dropdown showing raw ID instead of agent info from URL - Add proactive agent fetching when agent_id is present in URL parameters - Inject fetched agent into agents cache so dropdowns display proper name/avatar - Use useAgentsMap dependency to ensure proper cache initialization timing - Prevents raw agent IDs from showing in UI when visiting shared agent links Fix: Agents endpoint renamed to "My Agent" for less confusion with the Marketplace agents. chore: fix ESLint issues and Test Mocks ci: update permissions structure in loadDefaultInterface tests - Refactored permissions for MEMORY and added new permissions for MARKETPLACE and PEOPLE_PICKER. - Ensured consistent structure for permissions across different types. feat: support_contact validation to allow empty email strings
210 lines
6.6 KiB
TypeScript
210 lines
6.6 KiB
TypeScript
import React from 'react';
|
|
import { render, screen, fireEvent } from '@testing-library/react';
|
|
import '@testing-library/jest-dom';
|
|
import AgentCard from '../AgentCard';
|
|
import type t from 'librechat-data-provider';
|
|
|
|
// Mock useLocalize hook
|
|
jest.mock('~/hooks/useLocalize', () => () => (key: string) => {
|
|
const mockTranslations: Record<string, string> = {
|
|
com_agents_created_by: 'Created by',
|
|
};
|
|
return mockTranslations[key] || key;
|
|
});
|
|
|
|
describe('AgentCard', () => {
|
|
const mockAgent: t.Agent = {
|
|
id: '1',
|
|
name: 'Test Agent',
|
|
description: 'A test agent for testing purposes',
|
|
support_contact: {
|
|
name: 'Test Support',
|
|
email: 'test@example.com',
|
|
},
|
|
avatar: { filepath: '/test-avatar.png', source: 'local' },
|
|
created_at: 1672531200000,
|
|
instructions: 'Test instructions',
|
|
provider: 'openai' as const,
|
|
model: 'gpt-4',
|
|
model_parameters: {
|
|
temperature: 0.7,
|
|
maxContextTokens: 4096,
|
|
max_context_tokens: 4096,
|
|
max_output_tokens: 1024,
|
|
top_p: 1,
|
|
frequency_penalty: 0,
|
|
presence_penalty: 0,
|
|
},
|
|
};
|
|
|
|
const mockOnClick = jest.fn();
|
|
|
|
beforeEach(() => {
|
|
mockOnClick.mockClear();
|
|
});
|
|
|
|
it('renders agent information correctly', () => {
|
|
render(<AgentCard agent={mockAgent} onClick={mockOnClick} />);
|
|
|
|
expect(screen.getByText('Test Agent')).toBeInTheDocument();
|
|
expect(screen.getByText('A test agent for testing purposes')).toBeInTheDocument();
|
|
expect(screen.getByText('Created by')).toBeInTheDocument();
|
|
expect(screen.getByText('Test Support')).toBeInTheDocument();
|
|
});
|
|
|
|
it('displays avatar when provided as object', () => {
|
|
render(<AgentCard agent={mockAgent} onClick={mockOnClick} />);
|
|
|
|
const avatarImg = screen.getByAltText('Test Agent avatar');
|
|
expect(avatarImg).toBeInTheDocument();
|
|
expect(avatarImg).toHaveAttribute('src', '/test-avatar.png');
|
|
});
|
|
|
|
it('displays avatar when provided as string', () => {
|
|
const agentWithStringAvatar = {
|
|
...mockAgent,
|
|
avatar: '/string-avatar.png' as any, // Legacy support for string avatars
|
|
};
|
|
|
|
render(<AgentCard agent={agentWithStringAvatar} onClick={mockOnClick} />);
|
|
|
|
const avatarImg = screen.getByAltText('Test Agent avatar');
|
|
expect(avatarImg).toBeInTheDocument();
|
|
expect(avatarImg).toHaveAttribute('src', '/string-avatar.png');
|
|
});
|
|
|
|
it('displays Bot icon fallback when no avatar is provided', () => {
|
|
const agentWithoutAvatar = {
|
|
...mockAgent,
|
|
avatar: undefined,
|
|
};
|
|
|
|
render(<AgentCard agent={agentWithoutAvatar as any as t.Agent} onClick={mockOnClick} />);
|
|
|
|
// Check for Bot icon presence by looking for the svg with lucide-bot class
|
|
const botIcon = document.querySelector('.lucide-bot');
|
|
expect(botIcon).toBeInTheDocument();
|
|
});
|
|
|
|
it('calls onClick when card is clicked', () => {
|
|
render(<AgentCard agent={mockAgent} onClick={mockOnClick} />);
|
|
|
|
const card = screen.getByRole('button');
|
|
fireEvent.click(card);
|
|
|
|
expect(mockOnClick).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it('calls onClick when Enter key is pressed', () => {
|
|
render(<AgentCard agent={mockAgent} onClick={mockOnClick} />);
|
|
|
|
const card = screen.getByRole('button');
|
|
fireEvent.keyDown(card, { key: 'Enter' });
|
|
|
|
expect(mockOnClick).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it('calls onClick when Space key is pressed', () => {
|
|
render(<AgentCard agent={mockAgent} onClick={mockOnClick} />);
|
|
|
|
const card = screen.getByRole('button');
|
|
fireEvent.keyDown(card, { key: ' ' });
|
|
|
|
expect(mockOnClick).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it('does not call onClick for other keys', () => {
|
|
render(<AgentCard agent={mockAgent} onClick={mockOnClick} />);
|
|
|
|
const card = screen.getByRole('button');
|
|
fireEvent.keyDown(card, { key: 'Escape' });
|
|
|
|
expect(mockOnClick).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('applies additional className when provided', () => {
|
|
render(<AgentCard agent={mockAgent} onClick={mockOnClick} className="custom-class" />);
|
|
|
|
const card = screen.getByRole('button');
|
|
expect(card).toHaveClass('custom-class');
|
|
});
|
|
|
|
it('handles missing support contact gracefully', () => {
|
|
const agentWithoutContact = {
|
|
...mockAgent,
|
|
support_contact: undefined,
|
|
authorName: undefined,
|
|
};
|
|
|
|
render(<AgentCard agent={agentWithoutContact} onClick={mockOnClick} />);
|
|
|
|
expect(screen.getByText('Test Agent')).toBeInTheDocument();
|
|
expect(screen.getByText('A test agent for testing purposes')).toBeInTheDocument();
|
|
expect(screen.queryByText(/Created by/)).not.toBeInTheDocument();
|
|
});
|
|
|
|
it('displays authorName when support_contact is missing', () => {
|
|
const agentWithAuthorName = {
|
|
...mockAgent,
|
|
support_contact: undefined,
|
|
authorName: 'John Doe',
|
|
};
|
|
|
|
render(<AgentCard agent={agentWithAuthorName} onClick={mockOnClick} />);
|
|
|
|
expect(screen.getByText('Created by')).toBeInTheDocument();
|
|
expect(screen.getByText('John Doe')).toBeInTheDocument();
|
|
});
|
|
|
|
it('displays support_contact email when name is missing', () => {
|
|
const agentWithEmailOnly = {
|
|
...mockAgent,
|
|
support_contact: { email: 'contact@example.com' },
|
|
authorName: undefined,
|
|
};
|
|
|
|
render(<AgentCard agent={agentWithEmailOnly} onClick={mockOnClick} />);
|
|
|
|
expect(screen.getByText('Created by')).toBeInTheDocument();
|
|
expect(screen.getByText('contact@example.com')).toBeInTheDocument();
|
|
});
|
|
|
|
it('prioritizes support_contact name over authorName', () => {
|
|
const agentWithBoth = {
|
|
...mockAgent,
|
|
support_contact: { name: 'Support Team' },
|
|
authorName: 'John Doe',
|
|
};
|
|
|
|
render(<AgentCard agent={agentWithBoth} onClick={mockOnClick} />);
|
|
|
|
expect(screen.getByText('Created by')).toBeInTheDocument();
|
|
expect(screen.getByText('Support Team')).toBeInTheDocument();
|
|
expect(screen.queryByText('John Doe')).not.toBeInTheDocument();
|
|
});
|
|
|
|
it('prioritizes name over email in support_contact', () => {
|
|
const agentWithNameAndEmail = {
|
|
...mockAgent,
|
|
support_contact: {
|
|
name: 'Support Team',
|
|
email: 'support@example.com',
|
|
},
|
|
authorName: undefined,
|
|
};
|
|
|
|
render(<AgentCard agent={agentWithNameAndEmail} onClick={mockOnClick} />);
|
|
|
|
expect(screen.getByText('Created by')).toBeInTheDocument();
|
|
expect(screen.getByText('Support Team')).toBeInTheDocument();
|
|
expect(screen.queryByText('support@example.com')).not.toBeInTheDocument();
|
|
});
|
|
|
|
it('has proper accessibility attributes', () => {
|
|
render(<AgentCard agent={mockAgent} onClick={mockOnClick} />);
|
|
|
|
const card = screen.getByRole('button');
|
|
expect(card).toHaveAttribute('tabIndex', '0');
|
|
expect(card).toHaveAttribute('aria-label', 'com_agents_agent_card_label');
|
|
});
|
|
});
|