mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-02-24 19:34:08 +01:00
bugfix: Enhance Agent and AgentCategory schemas with new fields for category, support contact, and promotion status refactored and moved agent category methods and schema to data-schema package 🔧 fix: Merge and Rebase Conflicts - Move AgentCategory from api/models to @packages/data-schemas structure - Add schema, types, methods, and model following codebase conventions - Implement auto-seeding of default categories during AppService startup - Update marketplace controller to use new data-schemas methods - Remove old model file and standalone seed script refactor: unify agent marketplace to single endpoint with cursor pagination - Replace multiple marketplace routes with unified /marketplace endpoint - Add query string controls: category, search, limit, cursor, promoted, requiredPermission - Implement cursor-based pagination replacing page-based system - Integrate ACL permissions for proper access control - Fix ObjectId constructor error in Agent model - Update React components to use unified useGetMarketplaceAgentsQuery hook - Enhance type safety and remove deprecated useDynamicAgentQuery - Update tests for new marketplace architecture -Known issues: see more button after category switching + Unit tests feat: add icon property to ProcessedAgentCategory interface - Add useMarketplaceAgentsInfiniteQuery and useGetAgentCategoriesQuery to client/src/data-provider/Agents/ - Replace manual pagination in AgentGrid with infinite query pattern - Update imports to use local data provider instead of librechat-data-provider - Add proper permission handling with PERMISSION_BITS.VIEW/EDIT constants - Improve agent access control by adding requiredPermission validation in backend - Remove manual cursor/state management in favor of infinite query built-ins - Maintain existing search and category filtering functionality refactor: consolidate agent marketplace endpoints into main agents API and improve data management consistency - Remove dedicated marketplace controller and routes, merging functionality into main agents v1 API - Add countPromotedAgents function to Agent model for promoted agents count - Enhance getListAgents handler with marketplace filtering (category, search, promoted status) - Move getAgentCategories from marketplace to v1 controller with same functionality - Update agent mutations to invalidate marketplace queries and handle multiple permission levels - Improve cache management by updating all agent query variants (VIEW/EDIT permissions) - Consolidate agent data access patterns for better maintainability and consistency - Remove duplicate marketplace route definitions and middleware selected view only agents injected in the drop down fix: remove minlength validation for support contact name in agent schema feat: add validation and error messages for agent name in AgentConfig and AgentPanel fix: update agent permission check logic in AgentPanel to simplify condition Fix linting WIP Fix Unit tests WIP ESLint fixes eslint fix refactor: enhance isDuplicateVersion function in Agent model for improved comparison logic - Introduced handling for undefined/null values in array and object comparisons. - Normalized array comparisons to treat undefined/null as empty arrays. - Added deep comparison for objects and improved handling of primitive values. - Enhanced projectIds comparison to ensure consistent MongoDB ObjectId handling. refactor: remove redundant properties from IAgent interface in agent schema chore: update localization for agent detail component and clean up imports ci: update access middleware tests chore: remove unused PermissionTypes import from Role model ci: update AclEntry model tests ci: update button accessibility labels in AgentDetail tests refactor: update exhaustive dep. lint warning 🔧 fix: Fixed agent actions access feat: Add role-level permissions for agent sharing people picker - Add PEOPLE_PICKER permission type with VIEW_USERS and VIEW_GROUPS permissions - Create custom middleware for query-aware permission validation - Implement permission-based type filtering in PeoplePicker component - Hide people picker UI when user lacks permissions, show only public toggle - Support granular access: users-only, groups-only, or mixed search modes refactor: Replace marketplace interface config with permission-based system - Add MARKETPLACE permission type to handle marketplace access control - Update interface configuration to use role-based marketplace settings (admin/user) - Replace direct marketplace boolean config with permission-based checks - Modify frontend components to use marketplace permissions instead of interface config - Update agent query hooks to use marketplace permissions for determining permission levels - Add marketplace configuration structure similar to peoplePicker in YAML config - Backend now sets MARKETPLACE permissions based on interface configuration - When marketplace enabled: users get agents with EDIT permissions in dropdown lists (builder mode) - When marketplace disabled: users get agents with VIEW permissions in dropdown lists (browse mode) 🔧 fix: Redirect to New Chat if No Marketplace Access and Required Agent Name Placeholder (#8213) * Fix: Fix the redirect to new chat page if access to marketplace is denied * Fixed the required agent name placeholder --------- Co-authored-by: Atef Bellaaj <slalom.bellaaj@external.daimlertruck.com> chore: fix tests, remove unnecessary imports refactor: Implement permission checks for file access via agents - Updated `hasAccessToFilesViaAgent` to utilize permission checks for VIEW and EDIT access. - Replaced project-based access validation with permission-based checks. - Enhanced tests to cover new permission logic and ensure proper access control for files associated with agents. - Cleaned up imports and initialized models in test files for consistency. refactor: Enhance test setup and cleanup for file access control - Introduced modelsToCleanup array to track models added during tests for proper cleanup. - Updated afterAll hooks in test files to ensure all collections are cleared and only added models are deleted. - Improved consistency in model initialization across test files. - Added comments for clarity on cleanup processes and test data management. chore: Update Jest configuration and test setup for improved timeout handling - Added a global test timeout of 30 seconds in jest.config.js. - Configured jest.setTimeout in jestSetup.js to allow individual test overrides if needed. - Enhanced test reliability by ensuring consistent timeout settings across all tests. refactor: Implement file access filtering based on agent permissions - Introduced `filterFilesByAgentAccess` function to filter files based on user access through agents. - Updated `getFiles` and `primeFiles` functions to utilize the new filtering logic. - Moved `hasAccessToFilesViaAgent` function from the File model to permission services, adjusting imports accordingly - Enhanced tests to ensure proper access control and filtering behavior for files associated with agents. fix: make support_contact field a nested object rather than a sub-document refactor: Update support_contact field initialization in agent model - Removed handling for empty support_contact object in createAgent function. - Changed default value of support_contact in agent schema to undefined. test: Add comprehensive tests for support_contact field handling and versioning refactor: remove unused avatar upload mutation field and add informational toast for success chore: add missing SidePanelProvider for AgentMarketplace and organize imports fix: resolve agent selection race condition in marketplace HandleStartChat - Set agent in localStorage before newConversation to prevent useSelectorEffects from auto-selecting previous agent fix: resolve agent dropdown showing raw ID instead of agent info from URL - Add proactive agent fetching when agent_id is present in URL parameters - Inject fetched agent into agents cache so dropdowns display proper name/avatar - Use useAgentsMap dependency to ensure proper cache initialization timing - Prevents raw agent IDs from showing in UI when visiting shared agent links Fix: Agents endpoint renamed to "My Agent" for less confusion with the Marketplace agents. chore: fix ESLint issues and Test Mocks ci: update permissions structure in loadDefaultInterface tests - Refactored permissions for MEMORY and added new permissions for MARKETPLACE and PEOPLE_PICKER. - Ensured consistent structure for permissions across different types. feat: support_contact validation to allow empty email strings
430 lines
14 KiB
TypeScript
430 lines
14 KiB
TypeScript
/* eslint-disable @typescript-eslint/no-require-imports */
|
|
import React from 'react';
|
|
import { render, screen, waitFor } from '@testing-library/react';
|
|
import userEvent from '@testing-library/user-event';
|
|
import { MemoryRouter, useNavigate } from 'react-router-dom';
|
|
import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
|
|
import { RecoilRoot } from 'recoil';
|
|
|
|
import type t from 'librechat-data-provider';
|
|
import { Constants, EModelEndpoint } from 'librechat-data-provider';
|
|
|
|
import AgentDetail from '../AgentDetail';
|
|
import { useToast } from '~/hooks';
|
|
|
|
// Mock dependencies
|
|
jest.mock('react-router-dom', () => ({
|
|
...jest.requireActual('react-router-dom'),
|
|
useNavigate: jest.fn(),
|
|
}));
|
|
|
|
jest.mock('~/hooks', () => ({
|
|
useToast: jest.fn(),
|
|
useMediaQuery: jest.fn(() => false), // Mock as desktop by default
|
|
useLocalize: jest.fn(),
|
|
}));
|
|
|
|
jest.mock('~/utils/agents', () => ({
|
|
renderAgentAvatar: jest.fn((agent, options) => (
|
|
<div data-testid="agent-avatar" data-size={options?.size} />
|
|
)),
|
|
}));
|
|
|
|
jest.mock('~/Providers', () => ({
|
|
useChatContext: jest.fn(),
|
|
}));
|
|
|
|
jest.mock('@tanstack/react-query', () => ({
|
|
...jest.requireActual('@tanstack/react-query'),
|
|
useQueryClient: jest.fn(),
|
|
}));
|
|
|
|
// Mock clipboard API
|
|
const mockWriteText = jest.fn();
|
|
|
|
const mockNavigate = jest.fn();
|
|
const mockShowToast = jest.fn();
|
|
const mockLocalize = jest.fn((key: string) => key);
|
|
|
|
const mockAgent: t.Agent = {
|
|
id: 'test-agent-id',
|
|
name: 'Test Agent',
|
|
description: 'This is a test agent for unit testing',
|
|
avatar: {
|
|
filepath: '/path/to/avatar.png',
|
|
source: 'local' as const,
|
|
},
|
|
model: 'gpt-4',
|
|
provider: 'openai',
|
|
instructions: 'You are a helpful test agent',
|
|
tools: [],
|
|
author: 'test-user-id',
|
|
created_at: new Date().getTime(),
|
|
version: 1,
|
|
support_contact: {
|
|
name: 'Support Team',
|
|
email: 'support@test.com',
|
|
},
|
|
model_parameters: {
|
|
model: undefined,
|
|
temperature: null,
|
|
maxContextTokens: null,
|
|
max_context_tokens: null,
|
|
max_output_tokens: null,
|
|
top_p: null,
|
|
frequency_penalty: null,
|
|
presence_penalty: null,
|
|
},
|
|
};
|
|
|
|
// Helper function to render with providers
|
|
const renderWithProviders = (ui: React.ReactElement, options = {}) => {
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: {
|
|
queries: { retry: false },
|
|
mutations: { retry: false },
|
|
},
|
|
});
|
|
|
|
const Wrapper = ({ children }: { children: React.ReactNode }) => (
|
|
<QueryClientProvider client={queryClient}>
|
|
<RecoilRoot>
|
|
<MemoryRouter>{children}</MemoryRouter>
|
|
</RecoilRoot>
|
|
</QueryClientProvider>
|
|
);
|
|
|
|
return render(ui, { wrapper: Wrapper, ...options });
|
|
};
|
|
|
|
describe('AgentDetail', () => {
|
|
beforeEach(() => {
|
|
jest.clearAllMocks();
|
|
(useNavigate as jest.Mock).mockReturnValue(mockNavigate);
|
|
(useToast as jest.Mock).mockReturnValue({ showToast: mockShowToast });
|
|
const { useLocalize } = require('~/hooks');
|
|
(useLocalize as jest.Mock).mockReturnValue(mockLocalize);
|
|
|
|
// Mock useChatContext
|
|
const { useChatContext } = require('~/Providers');
|
|
(useChatContext as jest.Mock).mockReturnValue({
|
|
conversation: { conversationId: 'test-convo-id' },
|
|
newConversation: jest.fn(),
|
|
});
|
|
|
|
// Mock useQueryClient
|
|
const { useQueryClient } = require('@tanstack/react-query');
|
|
(useQueryClient as jest.Mock).mockReturnValue({
|
|
getQueryData: jest.fn(),
|
|
setQueryData: jest.fn(),
|
|
invalidateQueries: jest.fn(),
|
|
});
|
|
|
|
// Setup clipboard mock if it doesn't exist
|
|
if (!navigator.clipboard) {
|
|
Object.defineProperty(navigator, 'clipboard', {
|
|
value: {
|
|
writeText: mockWriteText,
|
|
},
|
|
configurable: true,
|
|
});
|
|
} else {
|
|
// If clipboard exists, spy on it
|
|
jest.spyOn(navigator.clipboard, 'writeText').mockImplementation(mockWriteText);
|
|
}
|
|
mockWriteText.mockResolvedValue(undefined);
|
|
});
|
|
|
|
const defaultProps = {
|
|
agent: mockAgent,
|
|
isOpen: true,
|
|
onClose: jest.fn(),
|
|
};
|
|
|
|
describe('Rendering', () => {
|
|
it('should render agent details correctly', () => {
|
|
renderWithProviders(<AgentDetail {...defaultProps} />);
|
|
|
|
expect(screen.getByText('Test Agent')).toBeInTheDocument();
|
|
expect(screen.getByText('This is a test agent for unit testing')).toBeInTheDocument();
|
|
expect(screen.getByTestId('agent-avatar')).toBeInTheDocument();
|
|
expect(screen.getByTestId('agent-avatar')).toHaveAttribute('data-size', 'xl');
|
|
});
|
|
|
|
it('should render contact information when available', () => {
|
|
renderWithProviders(<AgentDetail {...defaultProps} />);
|
|
|
|
expect(screen.getByText('com_agents_contact:')).toBeInTheDocument();
|
|
expect(screen.getByRole('link', { name: 'Support Team' })).toBeInTheDocument();
|
|
expect(screen.getByRole('link', { name: 'Support Team' })).toHaveAttribute(
|
|
'href',
|
|
'mailto:support@test.com',
|
|
);
|
|
});
|
|
|
|
it('should not render contact information when not available', () => {
|
|
const agentWithoutContact = { ...mockAgent };
|
|
delete (agentWithoutContact as any).support_contact;
|
|
|
|
renderWithProviders(<AgentDetail {...defaultProps} agent={agentWithoutContact} />);
|
|
|
|
expect(screen.queryByText('com_agents_contact:')).not.toBeInTheDocument();
|
|
});
|
|
|
|
it('should render loading state when agent is null', () => {
|
|
renderWithProviders(<AgentDetail {...defaultProps} agent={null as any} />);
|
|
|
|
expect(screen.getByText('com_agents_loading')).toBeInTheDocument();
|
|
expect(screen.getByText('com_agents_no_description')).toBeInTheDocument();
|
|
});
|
|
|
|
it('should render 3-dot menu button', () => {
|
|
renderWithProviders(<AgentDetail {...defaultProps} />);
|
|
|
|
const menuButton = screen.getByRole('button', { name: 'com_agents_more_options' });
|
|
expect(menuButton).toBeInTheDocument();
|
|
expect(menuButton).toHaveAttribute('aria-haspopup', 'menu');
|
|
});
|
|
|
|
it('should render Start Chat button', () => {
|
|
renderWithProviders(<AgentDetail {...defaultProps} />);
|
|
|
|
const startChatButton = screen.getByRole('button', { name: 'com_agents_start_chat' });
|
|
expect(startChatButton).toBeInTheDocument();
|
|
expect(startChatButton).not.toBeDisabled();
|
|
});
|
|
});
|
|
|
|
describe('Interactions', () => {
|
|
it('should navigate to chat when Start Chat button is clicked', async () => {
|
|
const user = userEvent.setup();
|
|
const mockNewConversation = jest.fn();
|
|
const mockQueryClient = {
|
|
getQueryData: jest.fn().mockReturnValue(null),
|
|
setQueryData: jest.fn(),
|
|
invalidateQueries: jest.fn(),
|
|
};
|
|
|
|
// Update mocks for this test
|
|
const { useChatContext } = require('~/Providers');
|
|
(useChatContext as jest.Mock).mockReturnValue({
|
|
conversation: { conversationId: 'test-convo-id' },
|
|
newConversation: mockNewConversation,
|
|
});
|
|
|
|
const { useQueryClient } = require('@tanstack/react-query');
|
|
(useQueryClient as jest.Mock).mockReturnValue(mockQueryClient);
|
|
|
|
renderWithProviders(<AgentDetail {...defaultProps} />);
|
|
|
|
const startChatButton = screen.getByRole('button', { name: 'com_agents_start_chat' });
|
|
await user.click(startChatButton);
|
|
|
|
expect(mockNewConversation).toHaveBeenCalledWith({
|
|
template: {
|
|
conversationId: Constants.NEW_CONVO,
|
|
endpoint: EModelEndpoint.agents,
|
|
agent_id: 'test-agent-id',
|
|
title: 'Chat with Test Agent',
|
|
},
|
|
});
|
|
});
|
|
|
|
it('should not navigate when agent is null', async () => {
|
|
const user = userEvent.setup();
|
|
renderWithProviders(<AgentDetail {...defaultProps} agent={null as any} />);
|
|
|
|
const startChatButton = screen.getByRole('button', { name: 'com_agents_start_chat' });
|
|
expect(startChatButton).toBeDisabled();
|
|
|
|
await user.click(startChatButton);
|
|
expect(mockNavigate).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('should open dropdown when 3-dot menu is clicked', async () => {
|
|
const user = userEvent.setup();
|
|
renderWithProviders(<AgentDetail {...defaultProps} />);
|
|
|
|
const menuButton = screen.getByRole('button', { name: 'com_agents_more_options' });
|
|
await user.click(menuButton);
|
|
|
|
expect(screen.getByRole('button', { name: 'com_agents_copy_link' })).toBeInTheDocument();
|
|
});
|
|
|
|
it('should close dropdown when clicking outside', async () => {
|
|
const user = userEvent.setup();
|
|
renderWithProviders(<AgentDetail {...defaultProps} />);
|
|
|
|
// Open dropdown
|
|
const menuButton = screen.getByRole('button', { name: 'com_agents_more_options' });
|
|
await user.click(menuButton);
|
|
|
|
expect(screen.getByRole('button', { name: 'com_agents_copy_link' })).toBeInTheDocument();
|
|
|
|
// Click outside (on the agent name)
|
|
const agentName = screen.getByText('Test Agent');
|
|
await user.click(agentName);
|
|
|
|
await waitFor(() => {
|
|
expect(
|
|
screen.queryByRole('button', { name: 'com_agents_copy_link' }),
|
|
).not.toBeInTheDocument();
|
|
});
|
|
});
|
|
|
|
it('should copy link and show success toast when Copy Link is clicked', async () => {
|
|
const user = userEvent.setup();
|
|
renderWithProviders(<AgentDetail {...defaultProps} />);
|
|
|
|
// Open dropdown
|
|
const menuButton = screen.getByRole('button', { name: 'com_agents_more_options' });
|
|
await user.click(menuButton);
|
|
|
|
// Click copy link
|
|
const copyLinkButton = screen.getByRole('button', { name: 'com_agents_copy_link' });
|
|
await user.click(copyLinkButton);
|
|
|
|
// Wait for async clipboard operation to complete
|
|
await waitFor(() => {
|
|
expect(mockWriteText).toHaveBeenCalledWith(
|
|
`${window.location.origin}/c/new?agent_id=test-agent-id`,
|
|
);
|
|
});
|
|
|
|
await waitFor(() => {
|
|
expect(mockShowToast).toHaveBeenCalledWith({
|
|
message: 'com_agents_link_copied',
|
|
});
|
|
});
|
|
|
|
// Dropdown should close
|
|
await waitFor(() => {
|
|
expect(
|
|
screen.queryByRole('button', { name: 'com_agents_copy_link' }),
|
|
).not.toBeInTheDocument();
|
|
});
|
|
});
|
|
|
|
it('should show error toast when clipboard write fails', async () => {
|
|
const user = userEvent.setup();
|
|
mockWriteText.mockRejectedValue(new Error('Clipboard error'));
|
|
|
|
renderWithProviders(<AgentDetail {...defaultProps} />);
|
|
|
|
// Open dropdown and click copy link
|
|
const menuButton = screen.getByRole('button', { name: 'com_agents_more_options' });
|
|
await user.click(menuButton);
|
|
|
|
const copyLinkButton = screen.getByRole('button', { name: 'com_agents_copy_link' });
|
|
await user.click(copyLinkButton);
|
|
|
|
// Wait for clipboard operation to fail and error toast to show
|
|
await waitFor(() => {
|
|
expect(mockWriteText).toHaveBeenCalled();
|
|
});
|
|
|
|
await waitFor(() => {
|
|
expect(mockShowToast).toHaveBeenCalledWith({
|
|
message: 'com_agents_link_copy_failed',
|
|
});
|
|
});
|
|
});
|
|
|
|
it('should call onClose when dialog is closed', () => {
|
|
const mockOnClose = jest.fn();
|
|
renderWithProviders(<AgentDetail {...defaultProps} onClose={mockOnClose} isOpen={false} />);
|
|
|
|
// Since we're testing the onOpenChange callback, we need to trigger it
|
|
// This would normally be done by the Dialog component when ESC is pressed or overlay is clicked
|
|
// We'll test this by checking that onClose is properly passed to the Dialog
|
|
expect(mockOnClose).toBeDefined();
|
|
});
|
|
});
|
|
|
|
describe('Accessibility', () => {
|
|
it('should have proper ARIA attributes', () => {
|
|
renderWithProviders(<AgentDetail {...defaultProps} />);
|
|
|
|
const menuButton = screen.getByRole('button', { name: 'com_agents_more_options' });
|
|
expect(menuButton).toHaveAttribute('aria-haspopup', 'menu');
|
|
expect(menuButton).toHaveAttribute('aria-label', 'com_agents_more_options');
|
|
});
|
|
|
|
it('should support keyboard navigation for dropdown', async () => {
|
|
const user = userEvent.setup();
|
|
renderWithProviders(<AgentDetail {...defaultProps} />);
|
|
|
|
const menuButton = screen.getByRole('button', { name: 'com_agents_more_options' });
|
|
|
|
// Focus and open with Enter key
|
|
menuButton.focus();
|
|
await user.keyboard('{Enter}');
|
|
|
|
expect(screen.getByRole('button', { name: 'com_agents_copy_link' })).toBeInTheDocument();
|
|
});
|
|
|
|
it('should have proper focus management', async () => {
|
|
const user = userEvent.setup();
|
|
renderWithProviders(<AgentDetail {...defaultProps} />);
|
|
|
|
const menuButton = screen.getByRole('button', { name: 'com_agents_more_options' });
|
|
await user.click(menuButton);
|
|
|
|
const copyLinkButton = screen.getByRole('button', { name: 'com_agents_copy_link' });
|
|
expect(copyLinkButton).toHaveClass('focus:bg-surface-hover', 'focus:outline-none');
|
|
});
|
|
});
|
|
|
|
describe('Edge Cases', () => {
|
|
it('should handle agent with only email contact', () => {
|
|
const agentWithEmailOnly = {
|
|
...mockAgent,
|
|
support_contact: {
|
|
email: 'support@test.com',
|
|
},
|
|
};
|
|
|
|
renderWithProviders(<AgentDetail {...defaultProps} agent={agentWithEmailOnly} />);
|
|
|
|
expect(screen.getByRole('link', { name: 'support@test.com' })).toBeInTheDocument();
|
|
});
|
|
|
|
it('should handle agent with only name contact', () => {
|
|
const agentWithNameOnly = {
|
|
...mockAgent,
|
|
support_contact: {
|
|
name: 'Support Team',
|
|
},
|
|
};
|
|
|
|
renderWithProviders(<AgentDetail {...defaultProps} agent={agentWithNameOnly} />);
|
|
|
|
expect(screen.getByText('Support Team')).toBeInTheDocument();
|
|
expect(screen.queryByRole('link')).not.toBeInTheDocument();
|
|
});
|
|
|
|
it('should handle very long description with proper text wrapping', () => {
|
|
const agentWithLongDescription = {
|
|
...mockAgent,
|
|
description:
|
|
'This is a very long description that should wrap properly and be displayed in multiple lines when the content exceeds the available width of the container.',
|
|
};
|
|
|
|
renderWithProviders(<AgentDetail {...defaultProps} agent={agentWithLongDescription} />);
|
|
|
|
const description = screen.getByText(agentWithLongDescription.description);
|
|
expect(description).toHaveClass('whitespace-pre-wrap');
|
|
});
|
|
|
|
it('should handle special characters in agent name', () => {
|
|
const agentWithSpecialChars = {
|
|
...mockAgent,
|
|
name: 'Test Agent™ & Co. (v2.0)',
|
|
};
|
|
|
|
renderWithProviders(<AgentDetail {...defaultProps} agent={agentWithSpecialChars} />);
|
|
|
|
expect(screen.getByText('Test Agent™ & Co. (v2.0)')).toBeInTheDocument();
|
|
});
|
|
});
|
|
});
|