mirror of
https://github.com/danny-avila/LibreChat.git
synced 2025-09-22 06:00:56 +02:00

WIP: Role as Permission Principal Type WIP: add user role check optimization to user principal check, update type comparisons WIP: cover edge cases for string vs ObjectId handling in permission granting and checking chore: Update people picker access middleware to use PrincipalType constants feat: Enhance people picker access control to include roles permissions chore: add missing default role schema values for people picker perms, cleanup typing feat: Enhance PeoplePicker component with role-specific UI and localization updates chore: Add missing `VIEW_ROLES` permission to role schema
125 lines
3.8 KiB
JavaScript
125 lines
3.8 KiB
JavaScript
const { logger } = require('@librechat/data-schemas');
|
|
const { PermissionBits, hasPermissions, ResourceType } = require('librechat-data-provider');
|
|
const { getEffectivePermissions } = require('~/server/services/PermissionService');
|
|
const { getAgent } = require('~/models/Agent');
|
|
const { getFiles } = require('~/models/File');
|
|
|
|
/**
|
|
* Checks if user has access to a file through agent permissions
|
|
* Files inherit permissions from agents - if you can view the agent, you can access its files
|
|
*/
|
|
const checkAgentBasedFileAccess = async ({ userId, role, fileId }) => {
|
|
try {
|
|
// Find agents that have this file in their tool_resources
|
|
const agentsWithFile = await getAgent({
|
|
$or: [
|
|
{ 'tool_resources.file_search.file_ids': fileId },
|
|
{ 'tool_resources.execute_code.file_ids': fileId },
|
|
{ 'tool_resources.ocr.file_ids': fileId },
|
|
],
|
|
});
|
|
|
|
if (!agentsWithFile || agentsWithFile.length === 0) {
|
|
return false;
|
|
}
|
|
|
|
// Check if user has access to any of these agents
|
|
for (const agent of Array.isArray(agentsWithFile) ? agentsWithFile : [agentsWithFile]) {
|
|
// Check if user is the agent author
|
|
if (agent.author && agent.author.toString() === userId) {
|
|
logger.debug(`[fileAccess] User is author of agent ${agent.id}`);
|
|
return true;
|
|
}
|
|
|
|
// Check ACL permissions for VIEW access on the agent
|
|
try {
|
|
const permissions = await getEffectivePermissions({
|
|
userId,
|
|
role,
|
|
resourceType: ResourceType.AGENT,
|
|
resourceId: agent._id || agent.id,
|
|
});
|
|
|
|
if (hasPermissions(permissions, PermissionBits.VIEW)) {
|
|
logger.debug(`[fileAccess] User ${userId} has VIEW permissions on agent ${agent.id}`);
|
|
return true;
|
|
}
|
|
} catch (permissionError) {
|
|
logger.warn(
|
|
`[fileAccess] Permission check failed for agent ${agent.id}:`,
|
|
permissionError.message,
|
|
);
|
|
// Continue checking other agents
|
|
}
|
|
}
|
|
|
|
return false;
|
|
} catch (error) {
|
|
logger.error('[fileAccess] Error checking agent-based access:', error);
|
|
return false;
|
|
}
|
|
};
|
|
|
|
/**
|
|
* Middleware to check if user can access a file
|
|
* Checks: 1) File ownership, 2) Agent-based access (file inherits agent permissions)
|
|
*/
|
|
const fileAccess = async (req, res, next) => {
|
|
try {
|
|
const fileId = req.params.file_id;
|
|
const userId = req.user?.id;
|
|
const userRole = req.user?.role;
|
|
if (!fileId) {
|
|
return res.status(400).json({
|
|
error: 'Bad Request',
|
|
message: 'file_id is required',
|
|
});
|
|
}
|
|
|
|
if (!userId) {
|
|
return res.status(401).json({
|
|
error: 'Unauthorized',
|
|
message: 'Authentication required',
|
|
});
|
|
}
|
|
|
|
// Get the file
|
|
const [file] = await getFiles({ file_id: fileId });
|
|
if (!file) {
|
|
return res.status(404).json({
|
|
error: 'Not Found',
|
|
message: 'File not found',
|
|
});
|
|
}
|
|
|
|
// Check if user owns the file
|
|
if (file.user && file.user.toString() === userId) {
|
|
req.fileAccess = { file };
|
|
return next();
|
|
}
|
|
|
|
// Check agent-based access (file inherits agent permissions)
|
|
const hasAgentAccess = await checkAgentBasedFileAccess({ userId, role: userRole, fileId });
|
|
if (hasAgentAccess) {
|
|
req.fileAccess = { file };
|
|
return next();
|
|
}
|
|
|
|
// No access
|
|
logger.warn(`[fileAccess] User ${userId} denied access to file ${fileId}`);
|
|
return res.status(403).json({
|
|
error: 'Forbidden',
|
|
message: 'Insufficient permissions to access this file',
|
|
});
|
|
} catch (error) {
|
|
logger.error('[fileAccess] Error checking file access:', error);
|
|
return res.status(500).json({
|
|
error: 'Internal Server Error',
|
|
message: 'Failed to check file access permissions',
|
|
});
|
|
}
|
|
};
|
|
|
|
module.exports = {
|
|
fileAccess,
|
|
};
|