mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-03-22 07:36:33 +01:00
* fix: preserve ban data object in checkBan to prevent permanent cache The !! operator on line 108 coerces the ban data object to a boolean, losing the expiresAt property. This causes: 1. Number(true.expiresAt) = NaN → expired bans never cleaned from banLogs 2. banCache.set(key, true, NaN) → Keyv stores with expires: null (permanent) 3. IP-based cache entries persist indefinitely, blocking unrelated users Fix: replace isBanned (boolean) with banData (original object) so that expiresAt is accessible for TTL calculation and proper cache expiry. * fix: address checkBan cleanup defects exposed by ban data fix The prior commit correctly replaced boolean coercion with the ban data object, but activated previously-dead cleanup code with several defects: - IP-only expired bans fell through cleanup without returning next(), re-caching with negative TTL (permanent entry) and blocking the user - Redis deployments used cache-prefixed keys for banLogs.delete(), silently failing since bans are stored at raw keys - banCache.set() calls were fire-and-forget, silently dropping errors - No guard for missing/invalid expiresAt reproduced the NaN TTL bug on legacy ban records Consolidate expired-ban cleanup into a single block that always returns next(), use raw keys (req.ip, userId) for banLogs.delete(), add an expiresAt validity guard, await cache writes with error logging, and parallelize independent I/O with Promise.all. Add 25 tests covering all checkBan code paths including the specific regressions for IP-only cleanup, Redis key mismatch, missing expiresAt, and cache write failures. --------- Co-authored-by: Danny Avila <danny@librechat.ai>
145 lines
4.3 KiB
JavaScript
145 lines
4.3 KiB
JavaScript
const { Keyv } = require('keyv');
|
|
const uap = require('ua-parser-js');
|
|
const { logger } = require('@librechat/data-schemas');
|
|
const { ViolationTypes } = require('librechat-data-provider');
|
|
const { isEnabled, keyvMongo, removePorts } = require('@librechat/api');
|
|
const { getLogStores } = require('~/cache');
|
|
const denyRequest = require('./denyRequest');
|
|
const { findUser } = require('~/models');
|
|
|
|
const banCache = new Keyv({ store: keyvMongo, namespace: ViolationTypes.BAN, ttl: 0 });
|
|
const message = 'Your account has been temporarily banned due to violations of our service.';
|
|
|
|
/** @returns {string} Cache key for ban lookups, prefixed for Redis or raw for MongoDB */
|
|
const getBanCacheKey = (prefix, value, useRedis) => {
|
|
if (!value) {
|
|
return '';
|
|
}
|
|
return useRedis ? `ban_cache:${prefix}:${value}` : value;
|
|
};
|
|
|
|
/**
|
|
* Respond to the request if the user is banned.
|
|
*
|
|
* @async
|
|
* @function
|
|
* @param {Object} req - Express Request object.
|
|
* @param {Object} res - Express Response object.
|
|
*
|
|
* @returns {Promise<Object>} - Returns a Promise which when resolved sends a response status of 403 with a specific message if request is not of api/agents/chat. If it is, calls `denyRequest()` function.
|
|
*/
|
|
const banResponse = async (req, res) => {
|
|
const ua = uap(req.headers['user-agent']);
|
|
const { baseUrl, originalUrl } = req;
|
|
if (!ua.browser.name) {
|
|
return res.status(403).json({ message });
|
|
} else if (baseUrl === '/api/agents' && originalUrl.startsWith('/api/agents/chat')) {
|
|
return await denyRequest(req, res, { type: ViolationTypes.BAN });
|
|
}
|
|
|
|
return res.status(403).json({ message });
|
|
};
|
|
|
|
/**
|
|
* Checks if the source IP or user is banned or not.
|
|
*
|
|
* @async
|
|
* @function
|
|
* @param {Object} req - Express request object.
|
|
* @param {Object} res - Express response object.
|
|
* @param {import('express').NextFunction} next - Next middleware function.
|
|
*
|
|
* @returns {Promise<function|Object>} - Returns a Promise which when resolved calls next middleware if user or source IP is not banned. Otherwise calls `banResponse()` and sets ban details in `banCache`.
|
|
*/
|
|
const checkBan = async (req, res, next = () => {}) => {
|
|
try {
|
|
const { BAN_VIOLATIONS } = process.env ?? {};
|
|
|
|
if (!isEnabled(BAN_VIOLATIONS)) {
|
|
return next();
|
|
}
|
|
|
|
req.ip = removePorts(req);
|
|
let userId = req.user?.id ?? req.user?._id ?? null;
|
|
|
|
if (!userId && req?.body?.email) {
|
|
const user = await findUser({ email: req.body.email }, '_id');
|
|
userId = user?._id ? user._id.toString() : userId;
|
|
}
|
|
|
|
if (!userId && !req.ip) {
|
|
return next();
|
|
}
|
|
|
|
const useRedis = isEnabled(process.env.USE_REDIS);
|
|
const ipKey = getBanCacheKey('ip', req.ip, useRedis);
|
|
const userKey = getBanCacheKey('user', userId, useRedis);
|
|
|
|
const [cachedIPBan, cachedUserBan] = await Promise.all([
|
|
ipKey ? banCache.get(ipKey) : undefined,
|
|
userKey ? banCache.get(userKey) : undefined,
|
|
]);
|
|
|
|
if (cachedIPBan || cachedUserBan) {
|
|
req.banned = true;
|
|
return await banResponse(req, res);
|
|
}
|
|
|
|
const banLogs = getLogStores(ViolationTypes.BAN);
|
|
const duration = banLogs.opts.ttl;
|
|
|
|
if (duration <= 0) {
|
|
return next();
|
|
}
|
|
|
|
const [ipBan, userBan] = await Promise.all([
|
|
req.ip ? banLogs.get(req.ip) : undefined,
|
|
userId ? banLogs.get(userId) : undefined,
|
|
]);
|
|
|
|
const banData = ipBan || userBan;
|
|
|
|
if (!banData) {
|
|
return next();
|
|
}
|
|
|
|
const expiresAt = Number(banData.expiresAt);
|
|
if (!banData.expiresAt || isNaN(expiresAt)) {
|
|
req.banned = true;
|
|
return await banResponse(req, res);
|
|
}
|
|
|
|
const timeLeft = expiresAt - Date.now();
|
|
|
|
if (timeLeft <= 0) {
|
|
const cleanups = [];
|
|
if (ipBan) {
|
|
cleanups.push(banLogs.delete(req.ip));
|
|
}
|
|
if (userBan) {
|
|
cleanups.push(banLogs.delete(userId));
|
|
}
|
|
await Promise.all(cleanups);
|
|
return next();
|
|
}
|
|
|
|
const cacheWrites = [];
|
|
if (ipKey) {
|
|
cacheWrites.push(banCache.set(ipKey, banData, timeLeft));
|
|
}
|
|
if (userKey) {
|
|
cacheWrites.push(banCache.set(userKey, banData, timeLeft));
|
|
}
|
|
await Promise.all(cacheWrites).catch((err) =>
|
|
logger.warn('[checkBan] Failed to write ban cache:', err),
|
|
);
|
|
|
|
req.banned = true;
|
|
return await banResponse(req, res);
|
|
} catch (error) {
|
|
logger.error('Error in checkBan middleware:', error);
|
|
return next(error);
|
|
}
|
|
};
|
|
|
|
module.exports = checkBan;
|