mirror of
https://github.com/danny-avila/LibreChat.git
synced 2025-09-22 06:00:56 +02:00

* 🚨 fix: Critical Redis CA file handling bug that could crash app 🔧 Added safe error handling for Redis CA certificate file reading in cacheConfig.js ## 🐛 Problem - fs.readFileSync() was called directly without error handling - Missing or inaccessible REDIS_CA files would throw unhandled exceptions - 💥 Application would crash during startup with cryptic filesystem errors - ❌ No validation of file existence before attempting to read ## ✅ Solution - ➕ Added getRedisCA() helper function with comprehensive error handling - 🔍 Implemented fs.existsSync() check before file reading attempts - 🛡️ Added try-catch block to handle filesystem errors gracefully - 📝 Added informative warning/error logging for troubleshooting - 🔄 Function returns null safely on any error condition ## 🎯 Benefits - 🚫 Prevents application crashes from misconfigured CA certificate paths - 🔍 Provides clear error messages for debugging certificate issues - ✅ Maintains backward compatibility for valid certificate configurations - 🚀 Improves production stability and deployment reliability ## 🧪 Testing Results - ✅ Verified handling of missing REDIS_CA environment variable - ✅ Tested with non-existent file paths (returns null with warning) - ✅ Confirmed valid certificate files are read correctly - ✅ Validated error handling for permission/access issues 🎉 This fix ensures LibreChat continues running regardless of Redis CA certificate configuration problems, improving overall system reliability. 🏷️ Type: 🐛 Bug Fix 📊 Impact: 🔴 High (prevents application crashes) 🎯 Area: Cache Configuration, Redis Integration * chore: Redis CA certificate handling with proper logging + JSDocs * chore: Improve error logging for Redis CA certificate file read failure --------- Co-authored-by: Danny Avila <danny@librechat.ai>
89 lines
3.8 KiB
JavaScript
89 lines
3.8 KiB
JavaScript
const fs = require('fs');
|
|
const { logger } = require('@librechat/data-schemas');
|
|
const { math, isEnabled } = require('@librechat/api');
|
|
const { CacheKeys } = require('librechat-data-provider');
|
|
|
|
// To ensure that different deployments do not interfere with each other's cache, we use a prefix for the Redis keys.
|
|
// This prefix is usually the deployment ID, which is often passed to the container or pod as an env var.
|
|
// Set REDIS_KEY_PREFIX_VAR to the env var that contains the deployment ID.
|
|
const REDIS_KEY_PREFIX_VAR = process.env.REDIS_KEY_PREFIX_VAR;
|
|
const REDIS_KEY_PREFIX = process.env.REDIS_KEY_PREFIX;
|
|
if (REDIS_KEY_PREFIX_VAR && REDIS_KEY_PREFIX) {
|
|
throw new Error('Only either REDIS_KEY_PREFIX_VAR or REDIS_KEY_PREFIX can be set.');
|
|
}
|
|
|
|
const USE_REDIS = isEnabled(process.env.USE_REDIS);
|
|
if (USE_REDIS && !process.env.REDIS_URI) {
|
|
throw new Error('USE_REDIS is enabled but REDIS_URI is not set.');
|
|
}
|
|
|
|
// Comma-separated list of cache namespaces that should be forced to use in-memory storage
|
|
// even when Redis is enabled. This allows selective performance optimization for specific caches.
|
|
const FORCED_IN_MEMORY_CACHE_NAMESPACES = process.env.FORCED_IN_MEMORY_CACHE_NAMESPACES
|
|
? process.env.FORCED_IN_MEMORY_CACHE_NAMESPACES.split(',').map((key) => key.trim())
|
|
: [];
|
|
|
|
// Validate against CacheKeys enum
|
|
if (FORCED_IN_MEMORY_CACHE_NAMESPACES.length > 0) {
|
|
const validKeys = Object.values(CacheKeys);
|
|
const invalidKeys = FORCED_IN_MEMORY_CACHE_NAMESPACES.filter((key) => !validKeys.includes(key));
|
|
|
|
if (invalidKeys.length > 0) {
|
|
throw new Error(
|
|
`Invalid cache keys in FORCED_IN_MEMORY_CACHE_NAMESPACES: ${invalidKeys.join(', ')}. Valid keys: ${validKeys.join(', ')}`,
|
|
);
|
|
}
|
|
}
|
|
|
|
/** Helper function to safely read Redis CA certificate from file
|
|
* @returns {string|null} The contents of the CA certificate file, or null if not set or on error
|
|
*/
|
|
const getRedisCA = () => {
|
|
const caPath = process.env.REDIS_CA;
|
|
if (!caPath) {
|
|
return null;
|
|
}
|
|
|
|
try {
|
|
if (fs.existsSync(caPath)) {
|
|
return fs.readFileSync(caPath, 'utf8');
|
|
} else {
|
|
logger.warn(`Redis CA certificate file not found: ${caPath}`);
|
|
return null;
|
|
}
|
|
} catch (error) {
|
|
logger.error(`Failed to read Redis CA certificate file '${caPath}':`, error);
|
|
return null;
|
|
}
|
|
};
|
|
|
|
const cacheConfig = {
|
|
FORCED_IN_MEMORY_CACHE_NAMESPACES,
|
|
USE_REDIS,
|
|
REDIS_URI: process.env.REDIS_URI,
|
|
REDIS_USERNAME: process.env.REDIS_USERNAME,
|
|
REDIS_PASSWORD: process.env.REDIS_PASSWORD,
|
|
REDIS_CA: getRedisCA(),
|
|
REDIS_KEY_PREFIX: process.env[REDIS_KEY_PREFIX_VAR] || REDIS_KEY_PREFIX || '',
|
|
REDIS_MAX_LISTENERS: math(process.env.REDIS_MAX_LISTENERS, 40),
|
|
REDIS_PING_INTERVAL: math(process.env.REDIS_PING_INTERVAL, 0),
|
|
/** Max delay between reconnection attempts in ms */
|
|
REDIS_RETRY_MAX_DELAY: math(process.env.REDIS_RETRY_MAX_DELAY, 3000),
|
|
/** Max number of reconnection attempts (0 = infinite) */
|
|
REDIS_RETRY_MAX_ATTEMPTS: math(process.env.REDIS_RETRY_MAX_ATTEMPTS, 10),
|
|
/** Connection timeout in ms */
|
|
REDIS_CONNECT_TIMEOUT: math(process.env.REDIS_CONNECT_TIMEOUT, 10000),
|
|
/** Queue commands when disconnected */
|
|
REDIS_ENABLE_OFFLINE_QUEUE: isEnabled(process.env.REDIS_ENABLE_OFFLINE_QUEUE ?? 'true'),
|
|
/** flag to modify redis connection by adding dnsLookup this is required when connecting to elasticache for ioredis
|
|
* see "Special Note: Aws Elasticache Clusters with TLS" on this webpage: https://www.npmjs.com/package/ioredis **/
|
|
REDIS_USE_ALTERNATIVE_DNS_LOOKUP: isEnabled(process.env.REDIS_USE_ALTERNATIVE_DNS_LOOKUP),
|
|
/** Enable redis cluster without the need of multiple URIs */
|
|
USE_REDIS_CLUSTER: isEnabled(process.env.USE_REDIS_CLUSTER ?? 'false'),
|
|
CI: isEnabled(process.env.CI),
|
|
DEBUG_MEMORY_CACHE: isEnabled(process.env.DEBUG_MEMORY_CACHE),
|
|
|
|
BAN_DURATION: math(process.env.BAN_DURATION, 7200000), // 2 hours
|
|
};
|
|
|
|
module.exports = { cacheConfig };
|