mirror of
https://github.com/danny-avila/LibreChat.git
synced 2025-09-22 08:12:00 +02:00

* WIP: app.locals refactoring
WIP: appConfig
fix: update memory configuration retrieval to use getAppConfig based on user role
fix: update comment for AppConfig interface to clarify purpose
🏷️ refactor: Update tests to use getAppConfig for endpoint configurations
ci: Update AppService tests to initialize app config instead of app.locals
ci: Integrate getAppConfig into remaining tests
refactor: Update multer storage destination to use promise-based getAppConfig and improve error handling in tests
refactor: Rename initializeAppConfig to setAppConfig and update related tests
ci: Mock getAppConfig in various tests to provide default configurations
refactor: Update convertMCPToolsToPlugins to use mcpManager for server configuration and adjust related tests
chore: rename `Config/getAppConfig` -> `Config/app`
fix: streamline OpenAI image tools configuration by removing direct appConfig dependency and using function parameters
chore: correct parameter documentation for imageOutputType in ToolService.js
refactor: remove `getCustomConfig` dependency in config route
refactor: update domain validation to use appConfig for allowed domains
refactor: use appConfig registration property
chore: remove app parameter from AppService invocation
refactor: update AppConfig interface to correct registration and turnstile configurations
refactor: remove getCustomConfig dependency and use getAppConfig in PluginController, multer, and MCP services
refactor: replace getCustomConfig with getAppConfig in STTService, TTSService, and related files
refactor: replace getCustomConfig with getAppConfig in Conversation and Message models, update tempChatRetention functions to use AppConfig type
refactor: update getAppConfig calls in Conversation and Message models to include user role for temporary chat expiration
ci: update related tests
refactor: update getAppConfig call in getCustomConfigSpeech to include user role
fix: update appConfig usage to access allowedDomains from actions instead of registration
refactor: enhance AppConfig to include fileStrategies and update related file strategy logic
refactor: update imports to use normalizeEndpointName from @librechat/api and remove redundant definitions
chore: remove deprecated unused RunManager
refactor: get balance config primarily from appConfig
refactor: remove customConfig dependency for appConfig and streamline loadConfigModels logic
refactor: remove getCustomConfig usage and use app config in file citations
refactor: consolidate endpoint loading logic into loadEndpoints function
refactor: update appConfig access to use endpoints structure across various services
refactor: implement custom endpoints configuration and streamline endpoint loading logic
refactor: update getAppConfig call to include user role parameter
refactor: streamline endpoint configuration and enhance appConfig usage across services
refactor: replace getMCPAuthMap with getUserMCPAuthMap and remove unused getCustomConfig file
refactor: add type annotation for loadedEndpoints in loadEndpoints function
refactor: move /services/Files/images/parse to TS API
chore: add missing FILE_CITATIONS permission to IRole interface
refactor: restructure toolkits to TS API
refactor: separate manifest logic into its own module
refactor: consolidate tool loading logic into a new tools module for startup logic
refactor: move interface config logic to TS API
refactor: migrate checkEmailConfig to TypeScript and update imports
refactor: add FunctionTool interface and availableTools to AppConfig
refactor: decouple caching and DB operations from AppService, make part of consolidated `getAppConfig`
WIP: fix tests
* fix: rebase conflicts
* refactor: remove app.locals references
* refactor: replace getBalanceConfig with getAppConfig in various strategies and middleware
* refactor: replace appConfig?.balance with getBalanceConfig in various controllers and clients
* test: add balance configuration to titleConvo method in AgentClient tests
* chore: remove unused `openai-chat-tokens` package
* chore: remove unused imports in initializeMCPs.js
* refactor: update balance configuration to use getAppConfig instead of getBalanceConfig
* refactor: integrate configMiddleware for centralized configuration handling
* refactor: optimize email domain validation by removing unnecessary async calls
* refactor: simplify multer storage configuration by removing async calls
* refactor: reorder imports for better readability in user.js
* refactor: replace getAppConfig calls with req.config for improved performance
* chore: replace getAppConfig calls with req.config in tests for centralized configuration handling
* chore: remove unused override config
* refactor: add configMiddleware to endpoint route and replace getAppConfig with req.config
* chore: remove customConfig parameter from TTSService constructor
* refactor: pass appConfig from request to processFileCitations for improved configuration handling
* refactor: remove configMiddleware from endpoint route and retrieve appConfig directly in getEndpointsConfig if not in `req.config`
* test: add mockAppConfig to processFileCitations tests for improved configuration handling
* fix: pass req.config to hasCustomUserVars and call without await after synchronous refactor
* fix: type safety in useExportConversation
* refactor: retrieve appConfig using getAppConfig in PluginController and remove configMiddleware from plugins route, to avoid always retrieving when plugins are cached
* chore: change `MongoUser` typedef to `IUser`
* fix: Add `user` and `config` fields to ServerRequest and update JSDoc type annotations from Express.Request to ServerRequest
* fix: remove unused setAppConfig mock from Server configuration tests
289 lines
9.6 KiB
JavaScript
289 lines
9.6 KiB
JavaScript
const fs = require('fs');
|
|
const path = require('path');
|
|
const fetch = require('node-fetch');
|
|
const passport = require('passport');
|
|
const { getBalanceConfig } = require('@librechat/api');
|
|
const { ErrorTypes } = require('librechat-data-provider');
|
|
const { hashToken, logger } = require('@librechat/data-schemas');
|
|
const { Strategy: SamlStrategy } = require('@node-saml/passport-saml');
|
|
const { getStrategyFunctions } = require('~/server/services/Files/strategies');
|
|
const { findUser, createUser, updateUser } = require('~/models');
|
|
const { getAppConfig } = require('~/server/services/Config');
|
|
const paths = require('~/config/paths');
|
|
|
|
let crypto;
|
|
try {
|
|
crypto = require('node:crypto');
|
|
} catch (err) {
|
|
logger.error('[samlStrategy] crypto support is disabled!', err);
|
|
}
|
|
|
|
/**
|
|
* Retrieves the certificate content from the given value.
|
|
*
|
|
* This function determines whether the provided value is a certificate string (RFC7468 format or
|
|
* base64-encoded without a header) or a valid file path. If the value matches one of these formats,
|
|
* the certificate content is returned. Otherwise, an error is thrown.
|
|
*
|
|
* @see https://github.com/node-saml/node-saml/tree/master?tab=readme-ov-file#configuration-option-idpcert
|
|
* @param {string} value - The certificate string or file path.
|
|
* @returns {string} The certificate content if valid.
|
|
* @throws {Error} If the value is not a valid certificate string or file path.
|
|
*/
|
|
function getCertificateContent(value) {
|
|
if (typeof value !== 'string') {
|
|
throw new Error('Invalid input: SAML_CERT must be a string.');
|
|
}
|
|
|
|
// Check if it's an RFC7468 formatted PEM certificate
|
|
const pemRegex = new RegExp(
|
|
'-----BEGIN (CERTIFICATE|PUBLIC KEY)-----\n' + // header
|
|
'([A-Za-z0-9+/=]{64}\n)+' + // base64 content (64 characters per line)
|
|
'[A-Za-z0-9+/=]{1,64}\n' + // base64 content (last line)
|
|
'-----END (CERTIFICATE|PUBLIC KEY)-----', // footer
|
|
);
|
|
if (pemRegex.test(value)) {
|
|
logger.info('[samlStrategy] Detected RFC7468-formatted certificate string.');
|
|
return value;
|
|
}
|
|
|
|
// Check if it's a Base64-encoded certificate (no header)
|
|
if (/^[A-Za-z0-9+/=]+$/.test(value) && value.length % 4 === 0) {
|
|
logger.info('[samlStrategy] Detected base64-encoded certificate string (no header).');
|
|
return value;
|
|
}
|
|
|
|
// Check if file exists and is readable
|
|
const certPath = path.normalize(path.isAbsolute(value) ? value : path.join(paths.root, value));
|
|
if (fs.existsSync(certPath) && fs.statSync(certPath).isFile()) {
|
|
try {
|
|
logger.info(`[samlStrategy] Loading certificate from file: ${certPath}`);
|
|
return fs.readFileSync(certPath, 'utf8').trim();
|
|
} catch (error) {
|
|
throw new Error(`Error reading certificate file: ${error.message}`);
|
|
}
|
|
}
|
|
|
|
throw new Error('Invalid cert: SAML_CERT must be a valid file path or certificate string.');
|
|
}
|
|
|
|
/**
|
|
* Retrieves a SAML claim from a profile object based on environment configuration.
|
|
* @param {object} profile - Saml profile
|
|
* @param {string} envVar - Environment variable name (SAML_*)
|
|
* @param {string} defaultKey - Default key to use if the environment variable is not set
|
|
* @returns {string}
|
|
*/
|
|
function getSamlClaim(profile, envVar, defaultKey) {
|
|
const claimKey = process.env[envVar];
|
|
|
|
// Avoids accessing `profile[""]` when the environment variable is empty string.
|
|
if (claimKey) {
|
|
return profile[claimKey] ?? profile[defaultKey];
|
|
}
|
|
return profile[defaultKey];
|
|
}
|
|
|
|
function getEmail(profile) {
|
|
return getSamlClaim(profile, 'SAML_EMAIL_CLAIM', 'email');
|
|
}
|
|
|
|
function getUserName(profile) {
|
|
return getSamlClaim(profile, 'SAML_USERNAME_CLAIM', 'username');
|
|
}
|
|
|
|
function getGivenName(profile) {
|
|
return getSamlClaim(profile, 'SAML_GIVEN_NAME_CLAIM', 'given_name');
|
|
}
|
|
|
|
function getFamilyName(profile) {
|
|
return getSamlClaim(profile, 'SAML_FAMILY_NAME_CLAIM', 'family_name');
|
|
}
|
|
|
|
function getPicture(profile) {
|
|
return getSamlClaim(profile, 'SAML_PICTURE_CLAIM', 'picture');
|
|
}
|
|
|
|
/**
|
|
* Downloads an image from a URL using an access token.
|
|
* @param {string} url
|
|
* @returns {Promise<Buffer>}
|
|
*/
|
|
const downloadImage = async (url) => {
|
|
try {
|
|
const response = await fetch(url);
|
|
if (response.ok) {
|
|
return await response.buffer();
|
|
} else {
|
|
throw new Error(`${response.statusText} (HTTP ${response.status})`);
|
|
}
|
|
} catch (error) {
|
|
logger.error(`[samlStrategy] Error downloading image at URL "${url}": ${error}`);
|
|
return null;
|
|
}
|
|
};
|
|
|
|
/**
|
|
* Determines the full name of a user based on SAML profile and environment configuration.
|
|
*
|
|
* @param {Object} profile - The user profile object from SAML Connect
|
|
* @returns {string} The determined full name of the user
|
|
*/
|
|
function getFullName(profile) {
|
|
if (process.env.SAML_NAME_CLAIM) {
|
|
logger.info(
|
|
`[samlStrategy] Using SAML_NAME_CLAIM: ${process.env.SAML_NAME_CLAIM}, profile: ${profile[process.env.SAML_NAME_CLAIM]}`,
|
|
);
|
|
return profile[process.env.SAML_NAME_CLAIM];
|
|
}
|
|
|
|
const givenName = getGivenName(profile);
|
|
const familyName = getFamilyName(profile);
|
|
|
|
if (givenName && familyName) {
|
|
return `${givenName} ${familyName}`;
|
|
}
|
|
|
|
if (givenName) {
|
|
return givenName;
|
|
}
|
|
if (familyName) {
|
|
return familyName;
|
|
}
|
|
|
|
return getUserName(profile) || getEmail(profile);
|
|
}
|
|
|
|
/**
|
|
* Converts an input into a string suitable for a username.
|
|
* If the input is a string, it will be returned as is.
|
|
* If the input is an array, elements will be joined with underscores.
|
|
* In case of undefined or other falsy values, a default value will be returned.
|
|
*
|
|
* @param {string | string[] | undefined} input - The input value to be converted into a username.
|
|
* @param {string} [defaultValue=''] - The default value to return if the input is falsy.
|
|
* @returns {string} The processed input as a string suitable for a username.
|
|
*/
|
|
function convertToUsername(input, defaultValue = '') {
|
|
if (typeof input === 'string') {
|
|
return input;
|
|
} else if (Array.isArray(input)) {
|
|
return input.join('_');
|
|
}
|
|
|
|
return defaultValue;
|
|
}
|
|
|
|
async function setupSaml() {
|
|
try {
|
|
const samlConfig = {
|
|
entryPoint: process.env.SAML_ENTRY_POINT,
|
|
issuer: process.env.SAML_ISSUER,
|
|
callbackUrl: process.env.SAML_CALLBACK_URL,
|
|
idpCert: getCertificateContent(process.env.SAML_CERT),
|
|
wantAssertionsSigned: process.env.SAML_USE_AUTHN_RESPONSE_SIGNED === 'true' ? false : true,
|
|
wantAuthnResponseSigned: process.env.SAML_USE_AUTHN_RESPONSE_SIGNED === 'true' ? true : false,
|
|
};
|
|
|
|
passport.use(
|
|
'saml',
|
|
new SamlStrategy(samlConfig, async (profile, done) => {
|
|
try {
|
|
logger.info(`[samlStrategy] SAML authentication received for NameID: ${profile.nameID}`);
|
|
logger.debug('[samlStrategy] SAML profile:', profile);
|
|
|
|
let user = await findUser({ samlId: profile.nameID });
|
|
logger.info(
|
|
`[samlStrategy] User ${user ? 'found' : 'not found'} with SAML ID: ${profile.nameID}`,
|
|
);
|
|
|
|
if (!user) {
|
|
const email = getEmail(profile) || '';
|
|
user = await findUser({ email });
|
|
logger.info(
|
|
`[samlStrategy] User ${user ? 'found' : 'not found'} with email: ${profile.email}`,
|
|
);
|
|
}
|
|
|
|
if (user && user.provider !== 'saml') {
|
|
logger.info(
|
|
`[samlStrategy] User ${user.email} already exists with provider ${user.provider}`,
|
|
);
|
|
return done(null, false, {
|
|
message: ErrorTypes.AUTH_FAILED,
|
|
});
|
|
}
|
|
|
|
const fullName = getFullName(profile);
|
|
|
|
const username = convertToUsername(
|
|
getUserName(profile) || getGivenName(profile) || getEmail(profile),
|
|
);
|
|
|
|
if (!user) {
|
|
user = {
|
|
provider: 'saml',
|
|
samlId: profile.nameID,
|
|
username,
|
|
email: getEmail(profile) || '',
|
|
emailVerified: true,
|
|
name: fullName,
|
|
};
|
|
const appConfig = await getAppConfig();
|
|
const balanceConfig = getBalanceConfig(appConfig);
|
|
user = await createUser(user, balanceConfig, true, true);
|
|
} else {
|
|
user.provider = 'saml';
|
|
user.samlId = profile.nameID;
|
|
user.username = username;
|
|
user.name = fullName;
|
|
}
|
|
|
|
const picture = getPicture(profile);
|
|
if (picture && !user.avatar?.includes('manual=true')) {
|
|
const imageBuffer = await downloadImage(profile.picture);
|
|
if (imageBuffer) {
|
|
let fileName;
|
|
if (crypto) {
|
|
fileName = (await hashToken(profile.nameID)) + '.png';
|
|
} else {
|
|
fileName = profile.nameID + '.png';
|
|
}
|
|
|
|
const { saveBuffer } = getStrategyFunctions(process.env.CDN_PROVIDER);
|
|
const imagePath = await saveBuffer({
|
|
fileName,
|
|
userId: user._id.toString(),
|
|
buffer: imageBuffer,
|
|
});
|
|
user.avatar = imagePath ?? '';
|
|
}
|
|
}
|
|
|
|
user = await updateUser(user._id, user);
|
|
|
|
logger.info(
|
|
`[samlStrategy] Login success SAML ID: ${user.samlId} | email: ${user.email} | username: ${user.username}`,
|
|
{
|
|
user: {
|
|
samlId: user.samlId,
|
|
username: user.username,
|
|
email: user.email,
|
|
name: user.name,
|
|
},
|
|
},
|
|
);
|
|
|
|
done(null, user);
|
|
} catch (err) {
|
|
logger.error('[samlStrategy] Login failed', err);
|
|
done(err);
|
|
}
|
|
}),
|
|
);
|
|
} catch (err) {
|
|
logger.error('[samlStrategy]', err);
|
|
}
|
|
}
|
|
|
|
module.exports = { setupSaml, getCertificateContent };
|