Andreas/LibreChat
1
0
Fork 0
mirror of https://github.com/danny-avila/LibreChat.git synced 2026-01-18 08:25:30 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

🏷️ fix: Increment Tag Counters When Forking/Duplicating Conversations (#9737)

Browse source 
* fix: increment tag counters when forking/duplicating conversations

- Add bulkIncrementTagCounts to update existing tag counts in bulk
- Integrate tag count updates into importBatchBuilder.saveBatch() using Promise.all
- Update frontend mutations to directly update cache instead of invalidating queries
- Optimize bulkIncrementTagCounts to skip unnecessary database queries

Fixes issue where forked/duplicated conversations with bookmarks would not increment
tag counters, leading to negative counts when bookmarks were later removed.

* chore: reorder import statements for clarity in fork.spec.js
This commit is contained in:
Danny Avila 2025-09-19 22:02:09 -04:00 • committed by GitHub
parent aae3694b11
commit fcaf55143d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 196 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

30
client/src/data-provider/mutations.ts
View file

@ -96,7 +96,7 @@ export const useArchiveConvoMutation = (
const queryClient = useQueryClient();
const convoQueryKey = [QueryKeys.allConversations];
const archivedConvoQueryKey = [QueryKeys.archivedConversations];
const { onMutate, onError, onSettled, onSuccess, ..._options } = options || {};
const { onMutate, onError, onSuccess, ..._options } = options || {};
return useMutation(
(payload: t.TArchiveConversationRequest) => dataService.archiveConversation(payload),
@ -567,6 +567,19 @@ export const useDuplicateConversationMutation = (
queryKey: [QueryKeys.allConversations],
refetchPage: (_, index) => index === 0,
});
if (duplicatedConversation.tags && duplicatedConversation.tags.length > 0) {
queryClient.setQueryData<t.TConversationTag[]>([QueryKeys.conversationTags], (oldTags) => {
if (!oldTags) return oldTags;
return oldTags.map((tag) => {
if (duplicatedConversation.tags?.includes(tag.tag)) {
return { ...tag, count: tag.count + 1 };
}
return tag;
});
});
}
onSuccess?.(data, vars, context);
},
..._options,
@ -597,6 +610,19 @@ export const useForkConvoMutation = (
queryKey: [QueryKeys.allConversations],
refetchPage: (_, index) => index === 0,
});
if (forkedConversation.tags && forkedConversation.tags.length > 0) {
queryClient.setQueryData<t.TConversationTag[]>([QueryKeys.conversationTags], (oldTags) => {
if (!oldTags) return oldTags;
return oldTags.map((tag) => {
if (forkedConversation.tags?.includes(tag.tag)) {
return { ...tag, count: tag.count + 1 };
}
return tag;
});
});
}
onSuccess?.(data, vars, context);
},
..._options,
@ -871,7 +897,7 @@ export const useUploadAssistantAvatarMutation = (
unknown // context
> => {
return useMutation([MutationKeys.assistantAvatarUpload], {
mutationFn: ({ postCreation, ...variables }: t.AssistantAvatarVariables) =>
mutationFn: ({ postCreation: _postCreation, ...variables }: t.AssistantAvatarVariables) =>
dataService.uploadAssistantAvatar(variables),
...(options || {}),
});