Andreas/LibreChat
1
0
Fork 0
mirror of https://github.com/danny-avila/LibreChat.git synced 2026-02-22 18:34:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

🔧 feat: Add support for PKCE in OpenID strategy configuration

Browse source
This commit is contained in:
Ruben Talstra 2025-04-05 14:14:36 +02:00
parent f74b9a3018
commit ec5c9fef48
No known key found for this signature in database
GPG key ID: 2A5A7174A60F3BEA
3 changed files with 50 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

26
api/strategies/openidStrategy.spec.js
View file

@ -98,6 +98,7 @@ describe('setupOpenId', () => {
delete process.env.OPENID_USERNAME_CLAIM;
delete process.env.OPENID_NAME_CLAIM;
delete process.env.PROXY;
delete process.env.OPENID_USE_PKCE;
// By default, jwtDecode returns a token that includes the required role.
jwtDecode.mockReturnValue({
@ -393,4 +394,29 @@ describe('setupOpenId', () => {
);
expect(user.avatar).toBe(existingUser.avatar);
});
it('should pass usePKCE true and set code_challenge_method in params when OPENID_USE_PKCE is "true"', async () => {
process.env.OPENID_USE_PKCE = 'true';
await setupOpenId();
// Get the options from the last call of OpenIDStrategy
const callOptions = OpenIDStrategy.mock.calls[OpenIDStrategy.mock.calls.length - 1][0];
expect(callOptions.usePKCE).toBe(true);
expect(callOptions.params.code_challenge_method).toBe('S256');
});
it('should pass usePKCE false and not set code_challenge_method in params when OPENID_USE_PKCE is "false"', async () => {
process.env.OPENID_USE_PKCE = 'false';
await setupOpenId();
const callOptions = OpenIDStrategy.mock.calls[OpenIDStrategy.mock.calls.length - 1][0];
expect(callOptions.usePKCE).toBe(false);
expect(callOptions.params.code_challenge_method).toBeUndefined();
});
it('should default to usePKCE false when OPENID_USE_PKCE is not defined', async () => {
delete process.env.OPENID_USE_PKCE;
await setupOpenId();
const callOptions = OpenIDStrategy.mock.calls[OpenIDStrategy.mock.calls.length - 1][0];
expect(callOptions.usePKCE).toBe(false);
expect(callOptions.params.code_challenge_method).toBeUndefined();
});
});