From e54352e4c78f92f2e5f364931b6536ce42388170 Mon Sep 17 00:00:00 2001 From: Danny Avila Date: Tue, 3 Sep 2024 18:56:46 -0400 Subject: [PATCH] refactor: explicit typing for SharePrompt --- client/src/components/Prompts/SharePrompt.tsx | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/client/src/components/Prompts/SharePrompt.tsx b/client/src/components/Prompts/SharePrompt.tsx index 57de80ebe5..9a12553c46 100644 --- a/client/src/components/Prompts/SharePrompt.tsx +++ b/client/src/components/Prompts/SharePrompt.tsx @@ -31,7 +31,7 @@ const SharePrompt = ({ group, disabled }: { group?: TPromptGroup; disabled: bool const { data: startupConfig = {} as TStartupConfig, isFetching } = useGetStartupConfig(); const { instanceProjectId } = startupConfig; const groupIsGlobal = useMemo( - () => !!group?.projectIds?.includes(instanceProjectId), + () => !!(group?.projectIds ?? []).includes(instanceProjectId), [group, instanceProjectId], ); @@ -57,7 +57,8 @@ const SharePrompt = ({ group, disabled }: { group?: TPromptGroup; disabled: bool } const onSubmit = (data: FormValues) => { - if (!group._id || !instanceProjectId) { + const groupId = group._id ?? ''; + if (!groupId || !instanceProjectId) { return; } @@ -70,7 +71,7 @@ const SharePrompt = ({ group, disabled }: { group?: TPromptGroup; disabled: bool } updateGroup.mutate({ - id: group._id, + id: groupId, payload, }); };