From e4ac58012f0e399d9da63c65cc01e2f5501cadc2 Mon Sep 17 00:00:00 2001 From: Danny Avila Date: Wed, 20 Mar 2024 11:48:54 -0400 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=A7=20fix:=20Correct=20Handling=20of?= =?UTF-8?q?=20Self-Signed=20Certificates=20in=20`sendEmail`=20(#2148)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - note: To put it in a different way, if you put rejectUnauthorized: true, it means that self-signed certificates should not be allowed. This means, that EMAIL_ALLOW_SELFSIGNED is set to false --- api/server/utils/sendEmail.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/api/server/utils/sendEmail.js b/api/server/utils/sendEmail.js index 2f85f89dcd..d27b0409e1 100644 --- a/api/server/utils/sendEmail.js +++ b/api/server/utils/sendEmail.js @@ -2,6 +2,7 @@ const fs = require('fs'); const path = require('path'); const nodemailer = require('nodemailer'); const handlebars = require('handlebars'); +const { isEnabled } = require('~/server/utils'); const logger = require('~/config/winston'); const sendEmail = async (email, subject, payload, template) => { @@ -13,7 +14,7 @@ const sendEmail = async (email, subject, payload, template) => { requireTls: process.env.EMAIL_ENCRYPTION === 'starttls', tls: { // Whether to accept unsigned certificates - rejectUnauthorized: process.env.EMAIL_ALLOW_SELFSIGNED === 'true', + rejectUnauthorized: !isEnabled(process.env.EMAIL_ALLOW_SELFSIGNED), }, auth: { user: process.env.EMAIL_USERNAME,