mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-03-05 15:50:19 +01:00
🗝️ feat: Credential Variables for DB-Sourced MCP Servers (#12044)
* feat: Allow Credential Variables in Headers for DB-sourced MCP Servers - Removed the hasCustomUserVars check from ToolService.js, directly retrieving userMCPAuthMap. - Updated MCPConnectionFactory and related classes to include a dbSourced flag for better handling of database-sourced configurations. - Added integration tests to ensure proper behavior of dbSourced servers, verifying that sensitive placeholders are not resolved while allowing customUserVars. - Adjusted various MCP-related files to accommodate the new dbSourced logic, ensuring consistent handling across the codebase. * chore: MCPConnectionFactory Tests with Additional Flow Metadata for typing - Updated MCPConnectionFactory tests to include new fields in flowMetadata: serverUrl and state. - Enhanced mockFlowData in multiple test cases to reflect the updated structure, ensuring comprehensive coverage of the OAuth flow scenarios. - Added authorization_endpoint to metadata in the test setup for improved validation of the OAuth process. * refactor: Simplify MCPManager Configuration Handling - Removed unnecessary type assertions and streamlined the retrieval of server configuration in MCPManager. - Enhanced the handling of OAuth and database-sourced flags for improved clarity and efficiency. - Updated tests to reflect changes in user object structure and ensure proper processing of MCP environment variables. * refactor: Optimize User MCP Auth Map Retrieval in ToolService - Introduced conditional loading of userMCPAuthMap based on the presence of MCP-delimited tools, improving efficiency by avoiding unnecessary calls. - Updated the loadToolDefinitionsWrapper and loadAgentTools functions to reflect this change, enhancing overall performance and clarity. * test: Add userMCPAuthMap gating tests in ToolService - Introduced new tests to validate the logic for determining if MCP tools are present in the agent's tool list. - Implemented various scenarios to ensure accurate detection of MCP tools, including edge cases for empty, undefined, and null tool lists. - Enhanced clarity and coverage of the ToolService capability checking logic. * refactor: Enhance MCP Environment Variable Processing - Simplified the handling of the dbSourced parameter in the processMCPEnv function. - Introduced a failsafe mechanism to derive dbSourced from options if not explicitly provided, improving robustness and clarity in MCP environment variable processing. * refactor: Update Regex Patterns for Credential Placeholders in ServerConfigsDB - Modified regex patterns to include additional credential/env placeholders that should not be allowed in user-provided configurations. - Clarified comments to emphasize the security risks associated with credential exfiltration when MCP servers are shared between users. * chore: field order * refactor: Clean Up dbSourced Parameter Handling in processMCPEnv - Reintroduced the failsafe mechanism for deriving the dbSourced parameter from options, ensuring clarity and robustness in MCP environment variable processing. - Enhanced code readability by maintaining consistent comment structure. * refactor: Update MCPOptions Type to Include Optional dbId - Modified the processMCPEnv function to extend the MCPOptions type, allowing for an optional dbId property. - Simplified the logic for deriving the dbSourced parameter by directly checking the dbId property, enhancing code clarity and maintainability.
This commit is contained in:
parent
a2a09b556a
commit
d3c06052d7
16 changed files with 1060 additions and 70 deletions
|
|
@ -1,4 +1,8 @@
|
|||
const { AgentCapabilities, defaultAgentCapabilities } = require('librechat-data-provider');
|
||||
const {
|
||||
Constants,
|
||||
AgentCapabilities,
|
||||
defaultAgentCapabilities,
|
||||
} = require('librechat-data-provider');
|
||||
|
||||
/**
|
||||
* Tests for ToolService capability checking logic.
|
||||
|
|
@ -119,6 +123,55 @@ describe('ToolService - Capability Checking', () => {
|
|||
});
|
||||
});
|
||||
|
||||
describe('userMCPAuthMap gating', () => {
|
||||
/**
|
||||
* Simulates the guard condition used in both loadToolDefinitionsWrapper
|
||||
* and loadAgentTools to decide whether getUserMCPAuthMap should be called.
|
||||
*/
|
||||
const shouldFetchMCPAuth = (tools) =>
|
||||
tools?.some((t) => t.includes(Constants.mcp_delimiter)) ?? false;
|
||||
|
||||
it('should return true when agent has MCP tools', () => {
|
||||
const tools = ['web_search', `search${Constants.mcp_delimiter}my-mcp-server`, 'calculator'];
|
||||
expect(shouldFetchMCPAuth(tools)).toBe(true);
|
||||
});
|
||||
|
||||
it('should return false when agent has no MCP tools', () => {
|
||||
const tools = ['web_search', 'calculator', 'code_interpreter'];
|
||||
expect(shouldFetchMCPAuth(tools)).toBe(false);
|
||||
});
|
||||
|
||||
it('should return false when tools is empty', () => {
|
||||
expect(shouldFetchMCPAuth([])).toBe(false);
|
||||
});
|
||||
|
||||
it('should return false when tools is undefined', () => {
|
||||
expect(shouldFetchMCPAuth(undefined)).toBe(false);
|
||||
});
|
||||
|
||||
it('should return false when tools is null', () => {
|
||||
expect(shouldFetchMCPAuth(null)).toBe(false);
|
||||
});
|
||||
|
||||
it('should detect MCP tools with different server names', () => {
|
||||
const tools = [
|
||||
`listFiles${Constants.mcp_delimiter}file-server`,
|
||||
`query${Constants.mcp_delimiter}db-server`,
|
||||
];
|
||||
expect(shouldFetchMCPAuth(tools)).toBe(true);
|
||||
});
|
||||
|
||||
it('should return true even when only one tool is MCP', () => {
|
||||
const tools = [
|
||||
'web_search',
|
||||
'calculator',
|
||||
'code_interpreter',
|
||||
`echo${Constants.mcp_delimiter}test-server`,
|
||||
];
|
||||
expect(shouldFetchMCPAuth(tools)).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
describe('deferredToolsEnabled integration', () => {
|
||||
it('should correctly determine deferredToolsEnabled from capabilities set', () => {
|
||||
const createCheckCapability = (enabledCapabilities) => {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue