Andreas/LibreChat
1
0
Fork 0
mirror of https://github.com/danny-avila/LibreChat.git synced 2025-12-18 01:10:14 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

💫 fix: catch constant conditions in recoil state usage (#3513)

Browse source 
* chore: modify eslintrc

* fix: apply new rules, avoid using getter/setter tuples in conditions

---------

Co-authored-by: Alexandre Germain <nihilivin@gmail.com>
This commit is contained in:
Gerkin 2024-08-01 20:10:42 +02:00 • committed by GitHub
parent e15d0d354d
commit cd326c4cf0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 14 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.eslintrc.js
View file

@ -118,6 +118,8 @@ module.exports = {
], ],
rules: { rules: {
'@typescript-eslint/no-explicit-any': 'error', '@typescript-eslint/no-explicit-any': 'error',
'@typescript-eslint/no-unnecessary-condition': 'warn',
'@typescript-eslint/strict-boolean-expressions': 'warn',
}, },
}, },
{ {

6
client/src/components/Chat/Input/ChatForm.tsx
View file

@ -38,8 +38,8 @@ const ChatForm = ({ index = 0 }) => {
const submitButtonRef = useRef<HTMLButtonElement>(null); const submitButtonRef = useRef<HTMLButtonElement>(null);
const textAreaRef = useRef<HTMLTextAreaElement | null>(null); const textAreaRef = useRef<HTMLTextAreaElement | null>(null);
const SpeechToText = useRecoilState<boolean>(store.speechToText); const SpeechToText = useRecoilValue(store.speechToText);
const TextToSpeech = useRecoilState<boolean>(store.textToSpeech); const TextToSpeech = useRecoilValue(store.textToSpeech);
const automaticPlayback = useRecoilValue(store.automaticPlayback); const automaticPlayback = useRecoilValue(store.automaticPlayback);
const [showStopButton, setShowStopButton] = useRecoilState(store.showStopButtonByIndex(index)); const [showStopButton, setShowStopButton] = useRecoilState(store.showStopButtonByIndex(index));
@ -106,7 +106,7 @@ const ChatForm = ({ index = 0 }) => {
() => () =>
isAssistantsEndpoint(conversation?.endpoint) && isAssistantsEndpoint(conversation?.endpoint) &&
(!conversation?.assistant_id || (!conversation?.assistant_id ||
!assistantMap?.[conversation?.endpoint ?? '']?.[conversation?.assistant_id ?? '']), !assistantMap[conversation.endpoint ?? ''][conversation.assistant_id ?? '']),
[conversation?.assistant_id, conversation?.endpoint, assistantMap], [conversation?.assistant_id, conversation?.endpoint, assistantMap],
); );
const disableInputs = useMemo( const disableInputs = useMemo(

6
client/src/components/Nav/SettingsTabs/Speech/ConversationModeSwitch.tsx
View file

@ -1,4 +1,4 @@
import { useRecoilState } from 'recoil'; import { useRecoilState, useRecoilValue } from 'recoil';
import { Switch } from '~/components/ui'; import { Switch } from '~/components/ui';
import { useLocalize } from '~/hooks'; import { useLocalize } from '~/hooks';
import store from '~/store'; import store from '~/store';
@ -10,8 +10,8 @@ export default function ConversationModeSwitch({
}) { }) {
const localize = useLocalize(); const localize = useLocalize();
const [conversationMode, setConversationMode] = useRecoilState<boolean>(store.conversationMode); const [conversationMode, setConversationMode] = useRecoilState<boolean>(store.conversationMode);
const speechToText = useRecoilState<boolean>(store.speechToText); const speechToText = useRecoilValue(store.speechToText);
const textToSpeech = useRecoilState<boolean>(store.textToSpeech); const textToSpeech = useRecoilValue(store.textToSpeech);
const [, setAutoSendText] = useRecoilState(store.autoSendText); const [, setAutoSendText] = useRecoilState(store.autoSendText);
const [, setDecibelValue] = useRecoilState(store.decibelValue); const [, setDecibelValue] = useRecoilState(store.decibelValue);
const [, setAutoTranscribeAudio] = useRecoilState<boolean>(store.autoTranscribeAudio); const [, setAutoTranscribeAudio] = useRecoilState<boolean>(store.autoTranscribeAudio);

4
client/src/components/Nav/SettingsTabs/Speech/STT/AutoSendTextSelector.tsx
View file

@ -1,5 +1,5 @@
import React from 'react'; import React from 'react';
import { useRecoilState } from 'recoil'; import { useRecoilState, useRecoilValue } from 'recoil';
import { cn, defaultTextProps, optionText } from '~/utils/'; import { cn, defaultTextProps, optionText } from '~/utils/';
import { Slider, InputNumber } from '~/components/ui'; import { Slider, InputNumber } from '~/components/ui';
import { useLocalize } from '~/hooks'; import { useLocalize } from '~/hooks';
@ -8,7 +8,7 @@ import store from '~/store';
export default function AutoSendTextSelector() { export default function AutoSendTextSelector() {
const localize = useLocalize(); const localize = useLocalize();
const speechToText = useRecoilState<boolean>(store.speechToText); const speechToText = useRecoilValue(store.speechToText);
const [autoSendText, setAutoSendText] = useRecoilState(store.autoSendText); const [autoSendText, setAutoSendText] = useRecoilState(store.autoSendText);
return ( return (

4
client/src/components/Nav/SettingsTabs/Speech/STT/AutoTranscribeAudioSwitch.tsx
View file

@ -1,4 +1,4 @@
import { useRecoilState } from 'recoil'; import { useRecoilState, useRecoilValue } from 'recoil';
import { Switch } from '~/components/ui'; import { Switch } from '~/components/ui';
import { useLocalize } from '~/hooks'; import { useLocalize } from '~/hooks';
import store from '~/store'; import store from '~/store';
@ -12,7 +12,7 @@ export default function AutoTranscribeAudioSwitch({
const [autoTranscribeAudio, setAutoTranscribeAudio] = useRecoilState<boolean>( const [autoTranscribeAudio, setAutoTranscribeAudio] = useRecoilState<boolean>(
store.autoTranscribeAudio, store.autoTranscribeAudio,
); );
const speechToText = useRecoilState<boolean>(store.speechToText); const speechToText = useRecoilValue(store.speechToText);
const handleCheckedChange = (value: boolean) => { const handleCheckedChange = (value: boolean) => {
setAutoTranscribeAudio(value); setAutoTranscribeAudio(value);

4
client/src/components/Nav/SettingsTabs/Speech/STT/DecibelSelector.tsx
View file

@ -1,5 +1,5 @@
import React from 'react'; import React from 'react';
import { useRecoilState } from 'recoil'; import { useRecoilState, useRecoilValue } from 'recoil';
import { Slider, InputNumber } from '~/components/ui'; import { Slider, InputNumber } from '~/components/ui';
import { useLocalize } from '~/hooks'; import { useLocalize } from '~/hooks';
import store from '~/store'; import store from '~/store';
@ -7,7 +7,7 @@ import { cn, defaultTextProps, optionText } from '~/utils/';
export default function DecibelSelector() { export default function DecibelSelector() {
const localize = useLocalize(); const localize = useLocalize();
const speechToText = useRecoilState<boolean>(store.speechToText); const speechToText = useRecoilValue(store.speechToText);
const [decibelValue, setDecibelValue] = useRecoilState(store.decibelValue); const [decibelValue, setDecibelValue] = useRecoilState(store.decibelValue);
return ( return (