From c006630a45d0ce321a1cc585c1759a35460c6a97 Mon Sep 17 00:00:00 2001
From: Marco Beretta <81851188+berry-13@users.noreply.github.com>
Date: Mon, 1 Dec 2025 23:32:13 +0100
Subject: [PATCH] feat: Refactor FavoritesController to use model methods for
 user updates and retrieval

---
 api/server/controllers/FavoritesController.js | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/api/server/controllers/FavoritesController.js b/api/server/controllers/FavoritesController.js
index 0d3bd7f08c..ea268fe1fb 100644
--- a/api/server/controllers/FavoritesController.js
+++ b/api/server/controllers/FavoritesController.js
@@ -1,4 +1,4 @@
-const { User } = require('~/db/models');
+const { updateUser, getUserById } = require('~/models');
 
 const updateFavoritesController = async (req, res) => {
   try {
@@ -30,11 +30,7 @@ const updateFavoritesController = async (req, res) => {
       }
     }
 
-    const user = await User.findByIdAndUpdate(
-      userId,
-      { $set: { favorites } },
-      { new: true, select: 'favorites' },
-    );
+    const user = await updateUser(userId, { favorites });
 
     if (!user) {
       return res.status(404).json({ message: 'User not found' });
@@ -50,7 +46,7 @@ const updateFavoritesController = async (req, res) => {
 const getFavoritesController = async (req, res) => {
   try {
     const userId = req.user.id;
-    const user = await User.findById(userId).select('favorites').lean();
+    const user = await getUserById(userId, 'favorites');
 
     if (!user) {
       return res.status(404).json({ message: 'User not found' });
@@ -60,7 +56,7 @@ const getFavoritesController = async (req, res) => {
 
     if (!Array.isArray(favorites)) {
       favorites = [];
-      await User.findByIdAndUpdate(userId, { $set: { favorites: [] } });
+      await updateUser(userId, { favorites: [] });
     }
 
     res.status(200).json(favorites);