refactor: Update MCPServersInitializer tests to utilize new registry methods

* refactor: Replace direct access to sharedAppServers with registry.getServerConfig for improved abstraction.
* test: Adjust tests to verify server initialization and stale data handling using the updated registry methods, ensuring consistency and clarity in the test structure.
This commit is contained in:
Danny Avila 2025-12-15 16:39:55 -05:00
parent c88154bb9b
commit bb0a454bd4
No known key found for this signature in database
GPG key ID: BF31EEB2C5CA0956

View file

@ -315,11 +315,11 @@ describe('MCPServersInitializer', () => {
// First initialization - populates caches
await MCPServersInitializer.initialize(testConfigs);
expect(await registryStatusCache.isInitialized()).toBe(true);
expect(await registry.sharedAppServers.get('file_tools_server')).toBeDefined();
expect(await registry.getServerConfig('file_tools_server')).toBeDefined();
// Simulate stale data: add an extra server that shouldn't be there
await registry.sharedAppServers.add('stale_server', testParsedConfigs.file_tools_server);
expect(await registry.sharedAppServers.get('stale_server')).toBeDefined();
await registry.addServer('stale_server', testConfigs.file_tools_server, 'CACHE');
expect(await registry.getServerConfig('stale_server')).toBeDefined();
jest.clearAllMocks();
@ -331,20 +331,20 @@ describe('MCPServersInitializer', () => {
await MCPServersInitializer.initialize(testConfigs);
// Verify stale server was removed (cache was reset)
expect(await registry.sharedAppServers.get('stale_server')).toBeUndefined();
expect(await registry.getServerConfig('stale_server')).toBeUndefined();
// Verify new servers are present
expect(await registry.sharedAppServers.get('file_tools_server')).toBeDefined();
expect(await registry.sharedUserServers.get('oauth_server')).toBeDefined();
expect(await registry.getServerConfig('file_tools_server')).toBeDefined();
expect(await registry.getServerConfig('oauth_server')).toBeDefined();
// Verify inspector was called again (re-initialization happened)
expect(mockInspect).toHaveBeenCalled();
});
it('should not re-initialize on subsequent calls within same process', async () => {
// First initialization
// First initialization (5 servers in testConfigs)
await MCPServersInitializer.initialize(testConfigs);
expect(mockInspect).toHaveBeenCalledTimes(4);
expect(mockInspect).toHaveBeenCalledTimes(5);
jest.clearAllMocks();