From b8f2bee3fc018877cb435a5ae46f71c4780edc24 Mon Sep 17 00:00:00 2001
From: Arthur Barrett <abarrett@fas.harvard.edu>
Date: Thu, 27 Jun 2024 10:56:32 -0400
Subject: [PATCH] =?UTF-8?q?=F0=9F=93=B1fix:=20set=20initial=20nav=20visibi?=
 =?UTF-8?q?lity=20for=20small=20screens=20(#3208)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix: hide nav on small screens by default

* test: add spec for Nav component
---
 client/src/components/Nav/Nav.spec.tsx | 102 +++++++++++++++++++++++++
 client/src/components/Nav/Nav.tsx      |   5 ++
 client/test/localStorage.mock          |  21 +++++
 client/test/resizeObserver.mock        |   8 ++
 4 files changed, 136 insertions(+)
 create mode 100644 client/src/components/Nav/Nav.spec.tsx
 create mode 100644 client/test/localStorage.mock
 create mode 100644 client/test/resizeObserver.mock

diff --git a/client/src/components/Nav/Nav.spec.tsx b/client/src/components/Nav/Nav.spec.tsx
new file mode 100644
index 0000000000..0e3114a633
--- /dev/null
+++ b/client/src/components/Nav/Nav.spec.tsx
@@ -0,0 +1,102 @@
+import 'test/resizeObserver.mock';
+import 'test/matchMedia.mock';
+import 'test/localStorage.mock';
+
+import React from 'react';
+import { BrowserRouter } from 'react-router-dom';
+import { RecoilRoot } from 'recoil';
+import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
+import { render } from '@testing-library/react';
+import '@testing-library/jest-dom/extend-expect';
+
+import { AuthContextProvider } from '~/hooks/AuthContext';
+import { SearchContext } from '~/Providers';
+import Nav from './Nav';
+
+const renderNav = ({ search, navVisible, setNavVisible }) => {
+  const queryClient = new QueryClient({
+    defaultOptions: {
+      queries: {
+        retry: false,
+      },
+    },
+  });
+
+  return render(
+    <RecoilRoot>
+      <BrowserRouter>
+        <QueryClientProvider client={queryClient}>
+          <AuthContextProvider>
+            <SearchContext.Provider value={search}>
+              <Nav navVisible={navVisible} setNavVisible={setNavVisible} />
+            </SearchContext.Provider>
+          </AuthContextProvider>
+        </QueryClientProvider>
+      </BrowserRouter>
+    </RecoilRoot>,
+  );
+};
+
+const mockMatchMedia = (mediaQueryList?: string[]) => {
+  mediaQueryList = mediaQueryList || [];
+
+  Object.defineProperty(window, 'matchMedia', {
+    writable: true,
+    value: jest.fn().mockImplementation((query) => ({
+      matches: mediaQueryList.includes(query),
+      media: query,
+      onchange: null,
+      addEventListener: jest.fn(),
+      removeEventListener: jest.fn(),
+      dispatchEvent: jest.fn(),
+    })),
+  });
+};
+
+describe('Nav', () => {
+  beforeEach(() => {
+    mockMatchMedia();
+  });
+
+  it('renders visible', () => {
+    const { getByTestId } = renderNav({
+      search: { data: [], pageNumber: 1 },
+      navVisible: true,
+      setNavVisible: jest.fn(),
+    });
+
+    expect(getByTestId('nav')).toBeVisible();
+  });
+
+  it('renders hidden', async () => {
+    const { getByTestId } = renderNav({
+      search: { data: [], pageNumber: 1 },
+      navVisible: false,
+      setNavVisible: jest.fn(),
+    });
+
+    expect(getByTestId('nav')).not.toBeVisible();
+  });
+
+  it('renders hidden when small screen is detected', async () => {
+    mockMatchMedia(['(max-width: 768px)']);
+
+    const navVisible = true;
+    const mockSetNavVisible = jest.fn();
+
+    const { getByTestId } = renderNav({
+      search: { data: [], pageNumber: 1 },
+      navVisible: navVisible,
+      setNavVisible: mockSetNavVisible,
+    });
+
+    // nav is initially visible
+    expect(getByTestId('nav')).toBeVisible();
+
+    // when small screen is detected, the nav is hidden
+    expect(mockSetNavVisible.mock.calls).toHaveLength(1);
+    const updatedNavVisible = mockSetNavVisible.mock.calls[0][0](navVisible);
+    expect(updatedNavVisible).not.toEqual(navVisible);
+    expect(updatedNavVisible).toBeFalsy();
+  });
+});
diff --git a/client/src/components/Nav/Nav.tsx b/client/src/components/Nav/Nav.tsx
index 68aba256fc..ea714597f6 100644
--- a/client/src/components/Nav/Nav.tsx
+++ b/client/src/components/Nav/Nav.tsx
@@ -42,6 +42,10 @@ const Nav = ({ navVisible, setNavVisible }) => {
 
   useEffect(() => {
     if (isSmallScreen) {
+      const savedNavVisible = localStorage.getItem('navVisible');
+      if (savedNavVisible === null) {
+        toggleNavVisible();
+      }
       setNavWidth('320px');
     } else {
       setNavWidth('260px');
@@ -102,6 +106,7 @@ const Nav = ({ navVisible, setNavVisible }) => {
     <TooltipProvider delayDuration={250}>
       <Tooltip>
         <div
+          data-testid="nav"
           className={
             'nav active max-w-[320px] flex-shrink-0 overflow-x-hidden bg-gray-50 dark:bg-gray-850 md:max-w-[260px]'
           }
diff --git a/client/test/localStorage.mock b/client/test/localStorage.mock
new file mode 100644
index 0000000000..fbb1743cf3
--- /dev/null
+++ b/client/test/localStorage.mock
@@ -0,0 +1,21 @@
+let store = {};
+Object.defineProperty(window, 'localStorage', {
+    writable: true,
+    value: {
+        getItem: jest.fn().mockImplementation((key) => {
+            if(key in store) {
+                return store[key];
+            }
+            return null;
+        }),
+        setItem: jest.fn().mockImplementation((key, value) => {
+            store[key] = value.toString();
+        }),
+        clear: jest.fn().mockImplementation(() => {
+            store = {};
+        }),
+        removeItem: jest.fn().mockImplementation(() => {
+            delete store[key];
+        }),
+    },
+});
\ No newline at end of file
diff --git a/client/test/resizeObserver.mock b/client/test/resizeObserver.mock
new file mode 100644
index 0000000000..f88957a53d
--- /dev/null
+++ b/client/test/resizeObserver.mock
@@ -0,0 +1,8 @@
+Object.defineProperty(window, 'ResizeObserver', {
+  writable: true,
+  value: jest.fn().mockImplementation(() => ({
+    disconnect: jest.fn(),
+    observe: jest.fn(),
+    unobserve: jest.fn(),
+  }))
+});
\ No newline at end of file