Andreas/LibreChat
1
0
Fork 0
mirror of https://github.com/danny-avila/LibreChat.git synced 2026-04-17 21:34:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

🐞 fix: Update MCP server initialization to skip non-startup and oauth servers (#9049)

Browse source
This commit is contained in:
Theo N. Truong 2025-08-13 14:19:55 -06:00 • committed by GitHub
parent e6cebdf2b6
commit b6413b06bc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 33 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

22
packages/api/src/mcp/__tests__/MCPServersRegistry.test.ts
View file

@ -179,10 +179,10 @@ describe('MCPServersRegistry - Initialize Function', () => {
new Set(['oauth_server', 'oauth_predefined', 'oauth_startup_enabled']),
);
// Test serverInstructions
// Test serverInstructions - OAuth servers keep their original boolean value, non-OAuth fetch actual strings
expect(registry.serverInstructions).toEqual({
oauth_server: 'GitHub MCP server instructions',
stdio_server: 'Follow these instructions for stdio server',
oauth_server: true,
non_oauth_server: 'Public API instructions',
});
@ -193,16 +193,8 @@ describe('MCPServersRegistry - Initialize Function', () => {
non_oauth_server: rawConfigs.non_oauth_server,
});
// Test toolFunctions (only 2 servers have tools: oauth_server has 1, stdio_server has 2)
// Test toolFunctions (only non-OAuth servers get their tools fetched during initialization)
const expectedToolFunctions = {
get_repository_mcp_oauth_server: {
type: 'function',
function: {
name: 'get_repository_mcp_oauth_server',
description: 'Description for get_repository',
parameters: { type: 'object', properties: { input: { type: 'string' } } },
},
},
file_read_mcp_stdio_server: {
type: 'function',
function: {
@ -235,9 +227,9 @@ describe('MCPServersRegistry - Initialize Function', () => {
expect(registry.oauthServers).toBeInstanceOf(Set);
expect(registry.toolFunctions).toBeDefined();
// Error should be logged
expect(mockLogger.error).toHaveBeenCalledWith(
expect.stringContaining('[MCP][oauth_server] Failed to fetch OAuth requirement:'),
// Error should be logged as a warning at the higher level
expect(mockLogger.warn).toHaveBeenCalledWith(
expect.stringContaining('[MCP][oauth_server] Failed to initialize server:'),
expect.any(Error),
);
});
@ -250,7 +242,7 @@ describe('MCPServersRegistry - Initialize Function', () => {
expect(mockConnectionsRepo.disconnectAll).toHaveBeenCalledTimes(1);
});
it('should log configuration updates for each server', async () => {
it('should log configuration updates for each startup-enabled server', async () => {
const registry = new MCPServersRegistry(rawConfigs);
await registry.initialize();