🔬 chore: Add Circular Dependency Check to backend-review (#2149)

* 🔬 chore: Add Circular Dependency check to `backend-review`

* chore: touch random file for workflow trigger

* chore: workflow step order

* chore: update workflow to create empty auth.json file

* fix: attempt empty auth.json creation

* chore: add test_bundle ESLint ignore pattern

.eslintrc.js

@@ -19,6 +19,7 @@ module.exports = {
     'e2e/playwright-report/**/*',
     'packages/data-provider/types/**/*',
     'packages/data-provider/dist/**/*',
+    'packages/data-provider/test_bundle/**/*',
     'data-node/**/*',
     'meili_data/**/*',
     'node_modules/**/*',

.github/workflows/backend-review.yml

@@ -36,6 +36,21 @@ jobs:
       - name: Install Data Provider
         run: npm run build:data-provider
       
+      - name: Create empty auth.json file
+        run: |
+          mkdir -p api/data
+          echo '{}' > api/data/auth.json
+
+      - name: Check for Circular dependency in rollup
+        working-directory: ./packages/data-provider
+        run: |
+          output=$(npm run rollup:api)
+          echo "$output"
+          if echo "$output" | grep -q "Circular dependency"; then
+            echo "Error: Circular dependency detected!"
+            exit 1
+          fi
+
       - name: Run unit tests
         run: cd api && npm run test:ci
 

api/utils/azureUtils.js

@@ -6,7 +6,7 @@ const { isEnabled } = require('~/server/utils');
  * @returns {string} The sanitized model name.
  */
 const sanitizeModelName = (modelName) => {
-  // Replace periods with empty strings and other disallowed characters as needed
+  // Replace periods with empty strings and other disallowed characters as needed.
   return modelName.replace(/\./g, '');
 };