mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-02-14 22:48:10 +01:00
🔧 fix: Improve Endpoint Handling and Address Edge Cases (#1486)
* fix(TEndpointsConfig): resolve property access issues with typesafe helper function * fix: undefined or null endpoint edge case * refactor(mapEndpoints -> endpoints): renamed module to be more general for endpoint handling, wrote unit tests, export all helpers
This commit is contained in:
parent
42f2353509
commit
9864fc8700
24 changed files with 275 additions and 99 deletions
94
client/src/utils/endpoints.spec.ts
Normal file
94
client/src/utils/endpoints.spec.ts
Normal file
|
|
@ -0,0 +1,94 @@
|
|||
import { EModelEndpoint } from 'librechat-data-provider';
|
||||
import type { TEndpointsConfig, TConfig } from 'librechat-data-provider';
|
||||
import {
|
||||
getEndpointField,
|
||||
getAvailableEndpoints,
|
||||
getEndpointsFilter,
|
||||
mapEndpoints,
|
||||
} from './endpoints';
|
||||
|
||||
const mockEndpointsConfig: TEndpointsConfig = {
|
||||
[EModelEndpoint.openAI]: { type: undefined, iconURL: 'openAI_icon.png', order: 0 },
|
||||
[EModelEndpoint.google]: { type: undefined, iconURL: 'google_icon.png', order: 1 },
|
||||
Mistral: { type: EModelEndpoint.custom, iconURL: 'custom_icon.png', order: 2 },
|
||||
};
|
||||
|
||||
describe('getEndpointField', () => {
|
||||
it('returns undefined if endpointsConfig is undefined', () => {
|
||||
expect(getEndpointField(undefined, EModelEndpoint.openAI, 'type')).toBeUndefined();
|
||||
});
|
||||
|
||||
it('returns undefined if endpoint is null', () => {
|
||||
expect(getEndpointField(mockEndpointsConfig, null, 'type')).toBeUndefined();
|
||||
});
|
||||
|
||||
it('returns undefined if endpoint is undefined', () => {
|
||||
expect(getEndpointField(mockEndpointsConfig, undefined, 'type')).toBeUndefined();
|
||||
});
|
||||
|
||||
it('returns undefined if the endpoint does not exist in endpointsConfig', () => {
|
||||
expect(getEndpointField(mockEndpointsConfig, EModelEndpoint.bingAI, 'type')).toBeUndefined();
|
||||
});
|
||||
|
||||
it('returns the correct value for a valid endpoint and property', () => {
|
||||
expect(getEndpointField(mockEndpointsConfig, EModelEndpoint.openAI, 'order')).toEqual(0);
|
||||
expect(getEndpointField(mockEndpointsConfig, EModelEndpoint.google, 'iconURL')).toEqual(
|
||||
'google_icon.png',
|
||||
);
|
||||
});
|
||||
|
||||
it('returns undefined for a valid endpoint but an invalid property', () => {
|
||||
/* Type assertion as 'nonexistentProperty' is intentionally not a valid property of TConfig */
|
||||
expect(
|
||||
getEndpointField(
|
||||
mockEndpointsConfig,
|
||||
EModelEndpoint.openAI,
|
||||
'nonexistentProperty' as keyof TConfig,
|
||||
),
|
||||
).toBeUndefined();
|
||||
});
|
||||
|
||||
it('returns the correct value for a non-enum endpoint and valid property', () => {
|
||||
expect(getEndpointField(mockEndpointsConfig, 'Mistral', 'type')).toEqual(EModelEndpoint.custom);
|
||||
});
|
||||
|
||||
it('returns undefined for a non-enum endpoint with an invalid property', () => {
|
||||
expect(
|
||||
getEndpointField(mockEndpointsConfig, 'Mistral', 'nonexistentProperty' as keyof TConfig),
|
||||
).toBeUndefined();
|
||||
});
|
||||
});
|
||||
|
||||
describe('getEndpointsFilter', () => {
|
||||
it('returns an empty object if endpointsConfig is undefined', () => {
|
||||
expect(getEndpointsFilter(undefined)).toEqual({});
|
||||
});
|
||||
|
||||
it('returns a filter object based on endpointsConfig', () => {
|
||||
const expectedFilter = {
|
||||
[EModelEndpoint.openAI]: true,
|
||||
[EModelEndpoint.google]: true,
|
||||
Mistral: true,
|
||||
};
|
||||
expect(getEndpointsFilter(mockEndpointsConfig)).toEqual(expectedFilter);
|
||||
});
|
||||
});
|
||||
|
||||
describe('getAvailableEndpoints', () => {
|
||||
it('returns available endpoints based on filter and config', () => {
|
||||
const filter = {
|
||||
[EModelEndpoint.openAI]: true,
|
||||
[EModelEndpoint.google]: false,
|
||||
Mistral: true,
|
||||
};
|
||||
const expectedEndpoints = [EModelEndpoint.openAI, 'Mistral'];
|
||||
expect(getAvailableEndpoints(filter, mockEndpointsConfig)).toEqual(expectedEndpoints);
|
||||
});
|
||||
});
|
||||
|
||||
describe('mapEndpoints', () => {
|
||||
it('returns sorted available endpoints', () => {
|
||||
const expectedOrder = [EModelEndpoint.openAI, EModelEndpoint.google, 'Mistral'];
|
||||
expect(mapEndpoints(mockEndpointsConfig)).toEqual(expectedOrder);
|
||||
});
|
||||
});
|
||||
Loading…
Add table
Add a link
Reference in a new issue