🛡️ : Security Enhancements (#1681)

* fix: sanitize HTTP params and do not send whole error objects backs

* fix: prevent path traversal

* fix: send custom error message for tokenizer route

* chore: handle info exposure vector

* chore(oauth): skip check due to false positive as oauth routes are rate-limited

* chore(app): disable `x-powered-by`

* chore: disable false positives or flagging of hardcoded secrets when they are fake values

* chore: add path traversal safety check
This commit is contained in:
Danny Avila 2024-01-30 14:34:02 -05:00 committed by GitHub
parent 9fad1b2cae
commit 972402e029
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
23 changed files with 72 additions and 28 deletions

View file

@ -5,27 +5,28 @@ const requireJwtAuth = require('~/server/middleware/requireJwtAuth');
const { logger } = require('~/config');
const router = express.Router();
router.use(requireJwtAuth);
router.get('/', requireJwtAuth, async (req, res) => {
router.get('/', async (req, res) => {
const presets = (await getPresets(req.user.id)).map((preset) => preset);
res.status(200).send(presets);
res.status(200).json(presets);
});
router.post('/', requireJwtAuth, async (req, res) => {
router.post('/', async (req, res) => {
const update = req.body || {};
update.presetId = update?.presetId || crypto.randomUUID();
try {
const preset = await savePreset(req.user.id, update);
res.status(201).send(preset);
res.status(201).json(preset);
} catch (error) {
logger.error('[/presets] error saving preset', error);
res.status(500).send(error);
res.status(500).send('There was an error when saving the preset');
}
});
router.post('/delete', requireJwtAuth, async (req, res) => {
router.post('/delete', async (req, res) => {
let filter = {};
const { presetId } = req.body || {};
@ -37,10 +38,10 @@ router.post('/delete', requireJwtAuth, async (req, res) => {
try {
const deleteCount = await deletePresets(req.user.id, filter);
res.status(201).send(deleteCount);
res.status(201).json(deleteCount);
} catch (error) {
logger.error('[/presets/delete] error deleting presets', error);
res.status(500).send(error);
res.status(500).send('There was an error deleting the presets');
}
});