From 959e301f993e0d56fd8a8fcfb54eeec9c90799a0 Mon Sep 17 00:00:00 2001 From: Danny Avila Date: Fri, 12 Dec 2025 14:04:28 -0500 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A7=20fix:=20Express=20v5=20Optional?= =?UTF-8?q?=20chaining=20for=20endpoint=20retrieval=20in=20Assistants=20Co?= =?UTF-8?q?ntrollers=20(#10946)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Updated endpoint retrieval logic in `helpers.js` and `v1.js` to use optional chaining for safer access to request body and query parameters, enhancing code robustness. --- api/server/controllers/assistants/helpers.js | 2 +- api/server/controllers/assistants/v1.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/api/server/controllers/assistants/helpers.js b/api/server/controllers/assistants/helpers.js index ad9bc2361b..9183680f1e 100644 --- a/api/server/controllers/assistants/helpers.js +++ b/api/server/controllers/assistants/helpers.js @@ -185,7 +185,7 @@ const listAssistantsForAzure = async ({ req, res, version, azureConfig = {}, que * @returns {Promise<{ openai: OpenAI, openAIApiKey: string }>} - The initialized OpenAI SDK client. */ async function getOpenAIClient({ req, res, endpointOption, initAppClient, overrideEndpoint }) { - let endpoint = overrideEndpoint ?? req.body.endpoint ?? req.query.endpoint; + let endpoint = overrideEndpoint ?? req.body?.endpoint ?? req.query?.endpoint; const version = await getCurrentVersion(req, endpoint); if (!endpoint) { throw new Error(`[${req.baseUrl}] Endpoint is required`); diff --git a/api/server/controllers/assistants/v1.js b/api/server/controllers/assistants/v1.js index 53566f2a24..32842deb0f 100644 --- a/api/server/controllers/assistants/v1.js +++ b/api/server/controllers/assistants/v1.js @@ -259,7 +259,7 @@ function filterAssistantDocs({ documents, userId, assistantsConfig = {} }) { const getAssistantDocuments = async (req, res) => { try { const appConfig = req.config; - const endpoint = req.query; + const endpoint = req.query?.endpoint; const assistantsConfig = appConfig.endpoints?.[endpoint]; const documents = await getAssistants( {},