Andreas/LibreChat
1
0
Fork 0
mirror of https://github.com/danny-avila/LibreChat.git synced 2025-12-16 16:30:15 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

📌 fix: Exclude Pinned Keys from Cleanup and Fix MCP Pin State (#9867)
Some checks are pending
Docker Dev Branch Images Build / build (Dockerfile, lc-dev, node) (push) Waiting to run
Details
Docker Dev Branch Images Build / build (Dockerfile.multi, lc-dev-api, api-build) (push) Waiting to run
Details

Browse source 
* fix: Prevent MCPSelect from rendering when not pinned and no values are available

* fix: Exclude 'pinned' keys from timestamped storage cleanup logic

* fix: Safeguard MCPSelect rendering by adding optional chaining for mcpValues
This commit is contained in:
Danny Avila 2025-09-27 17:21:48 -04:00 • committed by GitHub
parent 062d813b21
commit 712f0b3ca2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
client/src/components/Chat/Input/MCPSelect.tsx
View file

@ -8,6 +8,7 @@ function MCPSelectContent() {
const { conversationId, mcpServerManager } = useBadgeRowContext(); const { conversationId, mcpServerManager } = useBadgeRowContext();
const { const {
localize, localize,
isPinned,
mcpValues, mcpValues,
isInitializing, isInitializing,
placeholderText, placeholderText,
@ -68,6 +69,10 @@ function MCPSelectContent() {
[getServerStatusIconProps, isInitializing], [getServerStatusIconProps, isInitializing],
); );
if (!isPinned && mcpValues?.length === 0) {
return null;
}
const configDialogProps = getConfigDialogProps(); const configDialogProps = getConfigDialogProps();
return ( return (

4
client/src/utils/timestamps.ts
View file

@ -84,7 +84,9 @@ export function cleanupTimestampedStorage(): void {
} }
// Check if this key should be timestamped // Check if this key should be timestamped
const isTimestampedKey = TIMESTAMPED_KEYS.some((prefix) => key.startsWith(prefix)); const isTimestampedKey = TIMESTAMPED_KEYS.some(
(prefix) => key.startsWith(prefix) && !key.includes('pinned'),
);
if (isTimestampedKey && !key.endsWith(TIMESTAMP_SUFFIX)) { if (isTimestampedKey && !key.endsWith(TIMESTAMP_SUFFIX)) {
const timestampKey = `${key}${TIMESTAMP_SUFFIX}`; const timestampKey = `${key}${TIMESTAMP_SUFFIX}`;