From 70e854eb59b8813f26f8ffa4cfae0dc7308e697a Mon Sep 17 00:00:00 2001
From: Dustin Healy <54083382+dustinhealy@users.noreply.github.com>
Date: Wed, 10 Dec 2025 15:28:35 -0800
Subject: [PATCH] =?UTF-8?q?=F0=9F=94=97=20fix:=20Shared=20Links=20Accessib?=
 =?UTF-8?q?ility=20Improvements=20(#10850)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix: reintroduce TooltipAnchor for shared link buttons and improve translation key accessibility

* chore: remove unused translation key
---
 .../Nav/SettingsTabs/Data/SharedLinks.tsx     | 61 +++++++++++--------
 client/src/locales/en/translation.json        |  3 +-
 2 files changed, 39 insertions(+), 25 deletions(-)

diff --git a/client/src/components/Nav/SettingsTabs/Data/SharedLinks.tsx b/client/src/components/Nav/SettingsTabs/Data/SharedLinks.tsx
index cbcf172622..cd946c2785 100644
--- a/client/src/components/Nav/SettingsTabs/Data/SharedLinks.tsx
+++ b/client/src/components/Nav/SettingsTabs/Data/SharedLinks.tsx
@@ -21,6 +21,7 @@ import {
   useMediaQuery,
   OGDialogHeader,
   OGDialogTitle,
+  TooltipAnchor,
   DataTable,
   Spinner,
   Button,
@@ -259,30 +260,42 @@ export default function SharedLinks() {
         },
         cell: ({ row }) => (
           <div className="flex items-center gap-2">
-            <a
-              href={`/c/${row.original.conversationId}`}
-              target="_blank"
-              rel="noopener noreferrer"
-              className="flex h-8 w-8 items-center justify-center rounded-md p-0 transition-colors hover:bg-surface-hover focus:outline-none focus:ring-2 focus:ring-ring"
-              aria-label={`${localize('com_ui_view_source')} - ${row.original.title || localize('com_ui_untitled')}`}
-            >
-              <MessageSquare className="size-4" aria-hidden="true" />
-            </a>
-            <Button
-              variant="ghost"
-              className="h-8 w-8 p-0 hover:bg-surface-hover"
-              onClick={() => {
-                setDeleteRow(row.original);
-                setIsDeleteOpen(true);
-              }}
-              aria-label={localize('com_ui_delete_shared_link', {
-                title: row.original.title || localize('com_ui_untitled'),
-              })}
-              aria-haspopup="dialog"
-              aria-controls="delete-shared-link-dialog"
-            >
-              <TrashIcon className="size-4" aria-hidden="true" />
-            </Button>
+            <TooltipAnchor
+              description={localize('com_ui_open_source_chat_new_tab')}
+              render={
+                <a
+                  href={`/c/${row.original.conversationId}`}
+                  target="_blank"
+                  rel="noopener noreferrer"
+                  className="flex h-8 w-8 items-center justify-center rounded-md p-0 transition-colors hover:bg-surface-hover focus:outline-none focus:ring-2 focus:ring-ring"
+                  aria-label={localize('com_ui_open_source_chat_new_tab_title', {
+                    title: row.original.title || localize('com_ui_untitled'),
+                  })}
+                >
+                  <MessageSquare className="size-4" aria-hidden="true" />
+                </a>
+              }
+            />
+            <TooltipAnchor
+              description={localize('com_ui_delete_shared_link_heading')}
+              render={
+                <Button
+                  variant="ghost"
+                  className="h-8 w-8 p-0 hover:bg-surface-hover"
+                  onClick={() => {
+                    setDeleteRow(row.original);
+                    setIsDeleteOpen(true);
+                  }}
+                  aria-label={localize('com_ui_delete_shared_link', {
+                    title: row.original.title || localize('com_ui_untitled'),
+                  })}
+                  aria-haspopup="dialog"
+                  aria-controls="delete-shared-link-dialog"
+                >
+                  <TrashIcon className="size-4" aria-hidden="true" />
+                </Button>
+              }
+            />
           </div>
         ),
       },
diff --git a/client/src/locales/en/translation.json b/client/src/locales/en/translation.json
index d61a02b94a..cb279c338e 100644
--- a/client/src/locales/en/translation.json
+++ b/client/src/locales/en/translation.json
@@ -1359,7 +1359,8 @@
   "com_ui_version_var": "Version {{0}}",
   "com_ui_versions": "Versions",
   "com_ui_view_memory": "View Memory",
-  "com_ui_view_source": "View source chat - {{title}}",
+  "com_ui_open_source_chat_new_tab_title": "Open Source Chat in New Tab - {{title}}",
+  "com_ui_open_source_chat_new_tab": "Open Source Chat in New Tab",
   "com_ui_web_search": "Web Search",
   "com_ui_web_search_cohere_key": "Enter Cohere API Key",
   "com_ui_web_search_firecrawl_url": "Firecrawl API URL (optional)",