Andreas/LibreChat
1
0
Fork 0
mirror of https://github.com/danny-avila/LibreChat.git synced 2026-04-04 14:57:20 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix: address convention violations in admin roles handlers

Browse source
This commit is contained in:
Dustin Healy 2026-03-24 23:54:32 -07:00
parent 452333ee4d
commit 69093a5d99
3 changed files with 29 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

19
packages/data-schemas/src/methods/role.ts
View file

@ -5,7 +5,7 @@ import {
permissionsSchema,
removeNullishValues,
} from 'librechat-data-provider';
import type { IRole } from '~/types';
import type { IRole, IUser } from '~/types';
import logger from '~/config/winston';
export interface RoleDeps {
@ -342,9 +342,7 @@ export function createRoleMethods(mongoose: typeof import('mongoose'), deps: Rol
}
}
/**
* Create a new custom role. Rejects names that match system roles.
*/
/** Rejects names that match system roles. */
async function createRole(roleData: Partial<IRole>): Promise<IRole> {
const { name } = roleData;
if (!name || typeof name !== 'string' || !name.trim()) {
@ -369,10 +367,7 @@ export function createRoleMethods(mongoose: typeof import('mongoose'), deps: Rol
return role.toObject() as IRole;
}
/**
* Delete a role by name. Guards against deleting system roles.
* Reassigns all users with the deleted role back to USER.
*/
/** Guards against deleting system roles. Reassigns affected users back to USER. */
async function deleteRole(roleName: string): Promise<IRole | null> {
if (SystemRoles[roleName as keyof typeof SystemRoles]) {
throw new Error(`Cannot delete system role: ${roleName}`);
@ -390,6 +385,13 @@ export function createRoleMethods(mongoose: typeof import('mongoose'), deps: Rol
return deleted as IRole | null;
}
async function listUsersByRole(roleName: string): Promise<IUser[]> {
const User = mongoose.models.User;
return (await User.find({ role: roleName })
.select('_id name email avatar createdAt')
.lean()) as IUser[];
}
return {
listRoles,
initializeRoles,
@ -399,6 +401,7 @@ export function createRoleMethods(mongoose: typeof import('mongoose'), deps: Rol
migrateRoleSchema,
createRole,
deleteRole,
listUsersByRole,
};
}