fix: address convention violations in admin roles handlers

This commit is contained in:
Dustin Healy 2026-03-24 23:54:32 -07:00
parent 452333ee4d
commit 69093a5d99
3 changed files with 29 additions and 36 deletions

View file

@ -11,21 +11,6 @@ const requireAdminAccess = requireCapability(SystemCapabilities.ACCESS_ADMIN);
const requireReadRoles = requireCapability(SystemCapabilities.READ_ROLES);
const requireManageRoles = requireCapability(SystemCapabilities.MANAGE_ROLES);
async function listUsersByRole(roleName) {
const mongoose = require('mongoose');
const User = mongoose.models.User;
const users = await User.find({ role: roleName })
.select('_id name email avatar createdAt')
.lean();
return users.map((u) => ({
userId: String(u._id),
name: u.name ?? String(u._id),
email: u.email ?? '',
avatarUrl: u.avatar,
joinedAt: u.createdAt ? u.createdAt.toISOString() : new Date().toISOString(),
}));
}
const handlers = createAdminRolesHandlers({
listRoles: db.listRoles,
getRoleByName: db.getRoleByName,
@ -35,8 +20,7 @@ const handlers = createAdminRolesHandlers({
deleteRole: db.deleteRole,
findUser: db.findUser,
updateUser: db.updateUser,
countUsers: db.countUsers,
listUsersByRole,
listUsersByRole: db.listUsersByRole,
});
router.use(requireJwtAuth, requireAdminAccess);