👓 fix: Assistants Vision Prompt Error Handling (legacy) (#4529)

* fix: vision prompt error handling

* fix: Update model reference in chatV1 controller

* remove model reference
This commit is contained in:
Danny Avila 2024-10-23 15:21:22 -04:00 committed by GitHub
parent 4da35b9cf5
commit 655f63714b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 7 deletions

View file

@ -314,7 +314,9 @@ const chatV1 = async (req, res) => {
} }
if (typeof endpointOption.artifactsPrompt === 'string' && endpointOption.artifactsPrompt) { if (typeof endpointOption.artifactsPrompt === 'string' && endpointOption.artifactsPrompt) {
body.additional_instructions = `${body.additional_instructions ?? ''}\n${endpointOption.artifactsPrompt}`.trim(); body.additional_instructions = `${body.additional_instructions ?? ''}\n${
endpointOption.artifactsPrompt
}`.trim();
} }
if (instructions) { if (instructions) {
@ -371,10 +373,13 @@ const chatV1 = async (req, res) => {
visionMessage.content = createVisionPrompt(plural); visionMessage.content = createVisionPrompt(plural);
visionMessage = formatMessage({ message: visionMessage, endpoint: EModelEndpoint.openAI }); visionMessage = formatMessage({ message: visionMessage, endpoint: EModelEndpoint.openAI });
visionPromise = openai.chat.completions.create({ visionPromise = openai.chat.completions
model: 'gpt-4-vision-preview', .create({
messages: [visionMessage], messages: [visionMessage],
max_tokens: 4000, max_tokens: 4000,
})
.catch((error) => {
logger.error('[/assistants/chat/] Error creating vision prompt', error);
}); });
const pluralized = plural ? 's' : ''; const pluralized = plural ? 's' : '';

View file

@ -151,7 +151,7 @@ const processVisionRequest = async (client, currentAction) => {
/** @type {ChatCompletion | undefined} */ /** @type {ChatCompletion | undefined} */
const completion = await client.visionPromise; const completion = await client.visionPromise;
if (completion.usage) { if (completion && completion.usage) {
recordUsage({ recordUsage({
user: client.req.user.id, user: client.req.user.id,
model: client.req.body.model, model: client.req.body.model,