📜 refactor: Optimize Conversation History Nav with Cursor Pagination (#5785)

*  feat: improve Nav/Conversations/Convo/NewChat component performance

*  feat: implement cursor-based pagination for conversations API

* 🔧 refactor: remove createdAt from conversation selection in API and type definitions

* 🔧 refactor: include createdAt in conversation selection and update related types

*  fix: search functionality and bugs with loadMoreConversations

* feat: move ArchivedChats to cursor and DataTable standard

* 🔧 refactor: add InfiniteQueryObserverResult type import in Nav component

* feat: enhance conversation listing with pagination, sorting, and search capabilities

* 🔧 refactor: remove unnecessary comment regarding lodash/debounce in ArchivedChatsTable

* 🔧 refactor: remove unused translation keys for archived chats and search results

* 🔧 fix: Archived Chats, Delete Convo, Duplicate Convo

* 🔧 refactor: improve conversation components with layout adjustments and new translations

* 🔧 refactor: simplify archive conversation mutation and improve unarchive handling; fix: update fork mutation

* 🔧 refactor: decode search query parameter in conversation route; improve error handling in unarchive mutation; clean up DataTable component styles

* 🔧 refactor: remove unused translation key for empty archived chats

* 🚀 fix: `archivedConversation` query key not updated correctly while archiving

* 🧠 feat: Bedrock Anthropic Reasoning & Update Endpoint Handling (#6163)

* feat: Add thinking and thinkingBudget parameters for Bedrock Anthropic models

* chore: Update @librechat/agents to version 2.1.8

* refactor: change region order in params

* refactor: Add maxTokens parameter to conversation preset schema

* refactor: Update agent client to use bedrockInputSchema and improve error handling for model parameters

* refactor: streamline/optimize llmConfig initialization and saving for bedrock

* fix: ensure config titleModel is used for all endpoints

* refactor: enhance OpenAIClient and agent initialization to support endpoint checks for OpenRouter

* chore: bump @google/generative-ai

*  feat: improve Nav/Conversations/Convo/NewChat component performance

* 🔧 refactor: remove unnecessary comment regarding lodash/debounce in ArchivedChatsTable

* 🔧 refactor: update translation keys for clarity; simplify conversation query parameters and improve sorting functionality in SharedLinks component

* 🔧 refactor: optimize conversation loading logic and improve search handling in Nav component

* fix: package-lock

* fix: package-lock 2

* fix: package lock 3

* refactor: remove unused utility files and exports to clean up the codebase

* refactor: remove i18n and useAuthRedirect modules to streamline codebase

* refactor: optimize Conversations component and remove unused ToggleContext

* refactor(Convo): add RenameForm and ConvoLink components; enhance Conversations component with responsive design

* fix: add missing @azure/storage-blob dependency in package.json

* refactor(Search): add error handling with toast notification for search errors

* refactor: make createdAt and updatedAt fields of tConvoUpdateSchema less restrictive if timestamps are missing

* chore: update @azure/storage-blob dependency to version 12.27.0, ensure package-lock is correct

* refactor(Search): improve conversation handling server side

* fix: eslint warning and errors

* refactor(Search): improved search loading state and overall UX

* Refactors conversation cache management

Centralizes conversation mutation logic into dedicated utility functions for adding, updating, and removing conversations from query caches.

Improves reliability and maintainability by:
- Consolidating duplicate cache manipulation code
- Adding type safety for infinite query data structures
- Implementing consistent cache update patterns across all conversation operations
- Removing obsolete conversation helper functions in favor of standardized utilities

* fix: conversation handling and SSE event processing

- Optimizes conversation state management with useMemo and proper hook ordering
- Improves SSE event handler documentation and error handling
- Adds reset guard flag for conversation changes
- Removes redundant navigation call
- Cleans up cursor handling logic and document structure

Improves code maintainability and prevents potential race conditions in conversation state updates

* refactor: add type for SearchBar `onChange`

* fix: type tags

* style: rounded to xl all Header buttons

* fix: activeConvo in Convo not working

* style(Bookmarks): improved UI

* a11y(AccountSettings): fixed hover style not visible when using light theme

* style(SettingsTabs): improved tab switchers and dropdowns

* feat: add translations keys for Speech

* chore: fix package-lock

* fix(mutations): legacy import after rebase

* feat: refactor conversation navigation for accessibility

* fix(search): convo and message create/update date not returned

* fix(search): show correct iconURL and endpoint for searched messages

* fix: small UI improvements

* chore: console.log cleanup

* chore: fix tests

* fix(ChatForm): improve conversation ID handling and clean up useMemo dependencies

* chore: improve typing

* chore: improve typing

* fix(useSSE): clear conversation ID on submission to prevent draft restoration

* refactor(OpenAIClient): clean up abort handler

* refactor(abortMiddleware): change handleAbort to use function expression

* feat: add PENDING_CONVO constant and update conversation ID checks

* fix: final event handling on abort

* fix: improve title sync and query cache sync on final event

* fix: prevent overwriting cached conversation data if it already exists

---------

Co-authored-by: Danny Avila <danny@librechat.ai>
This commit is contained in:
Marco Beretta 2025-04-15 10:04:00 +02:00 committed by GitHub
parent 77a21719fd
commit 650e9b4f6c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
69 changed files with 3434 additions and 2139 deletions

View file

@ -1,5 +1,24 @@
import type { AssistantsEndpoint } from './schemas';
// Testing this buildQuery function
const buildQuery = (params: Record<string, unknown>): string => {
const query = Object.entries(params)
.filter(([, value]) => {
if (Array.isArray(value)) {
return value.length > 0;
}
return value !== undefined && value !== null && value !== '';
})
.map(([key, value]) => {
if (Array.isArray(value)) {
return value.map((v) => `${key}=${encodeURIComponent(v)}`).join('&');
}
return `${key}=${encodeURIComponent(String(value))}`;
})
.join('&');
return query ? `?${query}` : '';
};
export const health = () => '/health';
export const user = () => '/api/user';
@ -43,10 +62,24 @@ export const abortRequest = (endpoint: string) => `/api/ask/${endpoint}/abort`;
export const conversationsRoot = '/api/convos';
export const conversations = (pageNumber: string, isArchived?: boolean, tags?: string[]) =>
`${conversationsRoot}?pageNumber=${pageNumber}${
isArchived === true ? '&isArchived=true' : ''
}${tags?.map((tag) => `&tags=${tag}`).join('')}`;
export const conversations = (
isArchived?: boolean,
sortBy?: 'title' | 'createdAt' | 'updatedAt',
sortDirection?: 'asc' | 'desc',
tags?: string[],
search?: string,
cursor?: string,
) => {
const params = {
isArchived,
sortBy,
sortDirection,
tags,
search,
cursor,
};
return `${conversationsRoot}${buildQuery(params)}`;
};
export const conversationById = (id: string) => `${conversationsRoot}/${id}`;
@ -54,7 +87,9 @@ export const genTitle = () => `${conversationsRoot}/gen_title`;
export const updateConversation = () => `${conversationsRoot}/update`;
export const deleteConversation = () => `${conversationsRoot}/clear`;
export const deleteConversation = () => `${conversationsRoot}`;
export const deleteAllConversation = () => `${conversationsRoot}/all`;
export const importConversation = () => `${conversationsRoot}/import`;
@ -62,8 +97,8 @@ export const forkConversation = () => `${conversationsRoot}/fork`;
export const duplicateConversation = () => `${conversationsRoot}/duplicate`;
export const search = (q: string, pageNumber: string) =>
`/api/search?q=${q}&pageNumber=${pageNumber}`;
export const search = (q: string, cursor?: string | null) =>
`/api/search?q=${q}${cursor ? `&cursor=${cursor}` : ''}`;
export const searchEnabled = () => '/api/search/enable';
@ -244,4 +279,4 @@ export const verifyTwoFactor = () => '/api/auth/2fa/verify';
export const confirmTwoFactor = () => '/api/auth/2fa/confirm';
export const disableTwoFactor = () => '/api/auth/2fa/disable';
export const regenerateBackupCodes = () => '/api/auth/2fa/backup/regenerate';
export const verifyTwoFactorTemp = () => '/api/auth/2fa/verify-temp';
export const verifyTwoFactorTemp = () => '/api/auth/2fa/verify-temp';

View file

@ -1228,6 +1228,8 @@ export enum Constants {
NO_PARENT = '00000000-0000-0000-0000-000000000000',
/** Standard value for the initial conversationId before a request is sent */
NEW_CONVO = 'new',
/** Standard value for the temporary conversationId after a request is sent and before the server responds */
PENDING_CONVO = 'PENDING',
/** Standard value for the conversationId used for search queries */
SEARCH = 'search',
/** Fixed, encoded domain length for Azure OpenAI Assistants Function name parsing. */

View file

@ -31,7 +31,10 @@ export function deleteUser(): Promise<s.TPreset> {
}
export function getMessagesByConvoId(conversationId: string): Promise<s.TMessage[]> {
if (conversationId === 'new') {
if (
conversationId === config.Constants.NEW_CONVO ||
conversationId === config.Constants.PENDING_CONVO
) {
return Promise.resolve([]);
}
return request.get(endpoints.messages(conversationId));
@ -589,46 +592,34 @@ export function forkConversation(payload: t.TForkConvoRequest): Promise<t.TForkC
}
export function deleteConversation(payload: t.TDeleteConversationRequest) {
//todo: this should be a DELETE request
return request.post(endpoints.deleteConversation(), { arg: payload });
return request.deleteWithOptions(endpoints.deleteConversation(), { data: { arg: payload } });
}
export function clearAllConversations(): Promise<unknown> {
return request.post(endpoints.deleteConversation(), { arg: {} });
return request.delete(endpoints.deleteAllConversation());
}
export const listConversations = (
params?: q.ConversationListParams,
): Promise<q.ConversationListResponse> => {
// Assuming params has a pageNumber property
const pageNumber = (params?.pageNumber ?? '1') || '1'; // Default to page 1 if not provided
const isArchived = params?.isArchived ?? false; // Default to false if not provided
const tags = params?.tags || []; // Default to an empty array if not provided
return request.get(endpoints.conversations(pageNumber, isArchived, tags));
};
const isArchived = params?.isArchived ?? false;
const sortBy = params?.sortBy;
const sortDirection = params?.sortDirection;
const tags = params?.tags || [];
const search = params?.search || '';
const cursor = params?.cursor;
export const listConversationsByQuery = (
params?: q.ConversationListParams & { searchQuery?: string },
): Promise<q.ConversationListResponse> => {
const pageNumber = (params?.pageNumber ?? '1') || '1'; // Default to page 1 if not provided
const searchQuery = params?.searchQuery ?? ''; // If no search query is provided, default to an empty string
// Update the endpoint to handle a search query
if (searchQuery !== '') {
return request.get(endpoints.search(searchQuery, pageNumber));
if (search !== '' && isArchived === false) {
return request.get(endpoints.search(search, cursor));
} else {
return request.get(endpoints.conversations(pageNumber));
return request.get(
endpoints.conversations(isArchived, sortBy, sortDirection, tags, search, cursor),
);
}
};
export const searchConversations = async (
q: string,
pageNumber: string,
): Promise<t.TSearchResults> => {
return request.get(endpoints.search(q, pageNumber));
};
export function getConversations(pageNumber: string): Promise<t.TGetConversationsResponse> {
return request.get(endpoints.conversations(pageNumber));
export function getConversations(cursor: string): Promise<t.TGetConversationsResponse> {
return request.get(endpoints.conversations(undefined, undefined, undefined, [], '', cursor));
}
export function getConversationById(id: string): Promise<s.TConversation> {
@ -779,15 +770,11 @@ export function enableTwoFactor(): Promise<t.TEnable2FAResponse> {
return request.get(endpoints.enableTwoFactor());
}
export function verifyTwoFactor(
payload: t.TVerify2FARequest,
): Promise<t.TVerify2FAResponse> {
export function verifyTwoFactor(payload: t.TVerify2FARequest): Promise<t.TVerify2FAResponse> {
return request.post(endpoints.verifyTwoFactor(), payload);
}
export function confirmTwoFactor(
payload: t.TVerify2FARequest,
): Promise<t.TVerify2FAResponse> {
export function confirmTwoFactor(payload: t.TVerify2FARequest): Promise<t.TVerify2FAResponse> {
return request.post(endpoints.confirmTwoFactor(), payload);
}
@ -803,4 +790,4 @@ export function verifyTwoFactorTemp(
payload: t.TVerify2FATempRequest,
): Promise<t.TVerify2FATempResponse> {
return request.post(endpoints.verifyTwoFactorTemp(), payload);
}
}

View file

@ -29,7 +29,7 @@ type EndpointSchema =
| typeof compactAgentsSchema
| typeof bedrockInputSchema;
type EndpointSchemaKey = Exclude<EModelEndpoint, EModelEndpoint.chatGPTBrowser>;
export type EndpointSchemaKey = Exclude<EModelEndpoint, EModelEndpoint.chatGPTBrowser>;
const endpointSchemas: Record<EndpointSchemaKey, EndpointSchema> = {
[EModelEndpoint.openAI]: openAISchema,

View file

@ -4,7 +4,7 @@ import type {
UseMutationResult,
QueryObserverResult,
} from '@tanstack/react-query';
import { initialModelsConfig } from '../config';
import { Constants, initialModelsConfig } from '../config';
import { defaultOrderQuery } from '../types/assistants';
import * as dataService from '../data-service';
import * as m from '../types/mutations';
@ -70,6 +70,10 @@ export const useGetSharedLinkQuery = (
[QueryKeys.sharedLinks, conversationId],
() => dataService.getSharedLink(conversationId),
{
enabled:
!!conversationId &&
conversationId !== Constants.NEW_CONVO &&
conversationId !== Constants.PENDING_CONVO,
refetchOnWindowFocus: false,
refetchOnReconnect: false,
refetchOnMount: false,
@ -242,23 +246,6 @@ export const useDeletePresetMutation = (): UseMutationResult<
});
};
export const useSearchQuery = (
searchQuery: string,
pageNumber: string,
config?: UseQueryOptions<t.TSearchResults>,
): QueryObserverResult<t.TSearchResults> => {
return useQuery<t.TSearchResults>(
[QueryKeys.searchResults, pageNumber, searchQuery],
() => dataService.searchConversations(searchQuery, pageNumber),
{
refetchOnWindowFocus: false,
refetchOnReconnect: false,
refetchOnMount: false,
...config,
},
);
};
export const useUpdateTokenCountMutation = (): UseMutationResult<
t.TUpdateTokenCountResponse,
unknown,

View file

@ -655,6 +655,8 @@ export const tPresetSchema = tConversationSchema
export const tConvoUpdateSchema = tConversationSchema.merge(
z.object({
endpoint: extendedModelEndpointSchema.nullable(),
createdAt: z.string().optional(),
updatedAt: z.string().optional(),
}),
);

View file

@ -164,6 +164,11 @@ export type DeleteConversationOptions = MutationOptions<
types.TDeleteConversationRequest
>;
export type ArchiveConversationOptions = MutationOptions<
types.TArchiveConversationResponse,
types.TArchiveConversationRequest
>;
export type DuplicateConvoOptions = MutationOptions<
types.TDuplicateConvoResponse,
types.TDuplicateConvoRequest

View file

@ -11,25 +11,38 @@ export type Conversation = {
conversations: s.TConversation[];
};
// Parameters for listing conversations (e.g., for pagination)
export type ConversationListParams = {
limit?: number;
before?: string | null;
after?: string | null;
order?: 'asc' | 'desc';
pageNumber: string;
conversationId?: string;
cursor?: string;
isArchived?: boolean;
sortBy?: 'title' | 'createdAt' | 'updatedAt';
sortDirection?: 'asc' | 'desc';
tags?: string[];
search?: string;
};
// Type for the response from the conversation list API
export type MinimalConversation = Pick<
s.TConversation,
'conversationId' | 'endpoint' | 'title' | 'createdAt' | 'updatedAt' | 'user'
>;
export type ConversationListResponse = {
conversations: s.TConversation[];
pageNumber: string;
pageSize: string | number;
pages: string | number;
conversations: MinimalConversation[];
mwssages?: s.TMessage[];
nextCursor: string | null;
};
export type SearchConversationListParams = {
nextCursor?: string | null;
pageSize?: number;
search: string;
};
export type SearchConversation = Pick<s.TConversation, 'conversationId' | 'title' | 'user'>;
export type SearchConversationListResponse = {
conversations: SearchConversation[];
messages: s.TMessage[];
nextCursor: string | null;
};
export type ConversationData = InfiniteData<ConversationListResponse>;