🪦 refactor: Remove Legacy Code (#10533)

* 🗑️ chore: Remove unused Legacy Provider clients and related helpers

* Deleted OpenAIClient and GoogleClient files along with their associated tests.
* Removed references to these clients in the clients index file.
* Cleaned up typedefs by removing the OpenAISpecClient export.
* Updated chat controllers to use the OpenAI SDK directly instead of the removed client classes.

* chore/remove-openapi-specs

* 🗑️ chore: Remove unused mergeSort and misc utility functions

* Deleted mergeSort.js and misc.js files as they are no longer needed.
* Removed references to cleanUpPrimaryKeyValue in messages.js and adjusted related logic.
* Updated mongoMeili.ts to eliminate local implementations of removed functions.

* chore: remove legacy endpoints

* chore: remove all plugins endpoint related code

* chore: remove unused prompt handling code and clean up imports

* Deleted handleInputs.js and instructions.js files as they are no longer needed.
* Removed references to these files in the prompts index.js.
* Updated docker-compose.yml to simplify reverse proxy configuration.

* chore: remove unused LightningIcon import from Icons.tsx

* chore: clean up translation.json by removing deprecated and unused keys

* chore: update Jest configuration and remove unused mock file

    * Simplified the setupFiles array in jest.config.js by removing the fetchEventSource mock.
    * Deleted the fetchEventSource.js mock file as it is no longer needed.

* fix: simplify endpoint type check in Landing and ConversationStarters components

    * Updated the endpoint type check to use strict equality for better clarity and performance.
    * Ensured consistency in the handling of the azureOpenAI endpoint across both components.

* chore: remove unused dependencies from package.json and package-lock.json

* chore: remove legacy EditController, associated routes and imports

* chore: update banResponse logic to refine request handling for banned users

* chore: remove unused validateEndpoint middleware and its references

* chore: remove unused 'res' parameter from initializeClient in multiple endpoint files

* chore: remove unused 'isSmallScreen' prop from BookmarkNav and NewChat components; clean up imports in ArchivedChatsTable and useSetIndexOptions hooks; enhance localization in PromptVersions

* chore: remove unused import of Constants and TMessage from MobileNav; retain only necessary QueryKeys import

* chore: remove unused TResPlugin type and related references; clean up imports in types and schemas

api/server/services/Endpoints/assistants/initalize.js

@@ -1,15 +1,14 @@
 const OpenAI = require('openai');
 const { ProxyAgent } = require('undici');
+const { isUserProvided } = require('@librechat/api');
 const { ErrorTypes, EModelEndpoint } = require('librechat-data-provider');
 const {
   getUserKeyValues,
   getUserKeyExpiry,
   checkUserKeyExpiry,
 } = require('~/server/services/UserService');
-const OAIClient = require('~/app/clients/OpenAIClient');
-const { isUserProvided } = require('~/server/utils');
 
-const initializeClient = async ({ req, res, endpointOption, version, initAppClient = false }) => {
+const initializeClient = async ({ req, res, version }) => {
   const { PROXY, OPENAI_ORGANIZATION, ASSISTANTS_API_KEY, ASSISTANTS_BASE_URL } = process.env;
 
   const userProvidesKey = isUserProvided(ASSISTANTS_API_KEY);
@@ -34,14 +33,6 @@ const initializeClient = async ({ req, res, endpointOption, version, initAppClie
     },
   };
 
-  const clientOptions = {
-    reverseProxyUrl: baseURL ?? null,
-    proxy: PROXY ?? null,
-    req,
-    res,
-    ...endpointOption,
-  };
-
   if (userProvidesKey & !apiKey) {
     throw new Error(
       JSON.stringify({
@@ -78,15 +69,6 @@ const initializeClient = async ({ req, res, endpointOption, version, initAppClie
   openai.req = req;
   openai.res = res;
 
-  if (endpointOption && initAppClient) {
-    const client = new OAIClient(apiKey, clientOptions);
-    return {
-      client,
-      openai,
-      openAIApiKey: apiKey,
-    };
-  }
-
   return {
     openai,
     openAIApiKey: apiKey,

api/server/services/Endpoints/assistants/initialize.spec.js

@@ -1,113 +0,0 @@
-// const OpenAI = require('openai');
-const { ProxyAgent } = require('undici');
-const { ErrorTypes } = require('librechat-data-provider');
-const { getUserKey, getUserKeyExpiry, getUserKeyValues } = require('~/server/services/UserService');
-const initializeClient = require('./initalize');
-// const { OpenAIClient } = require('~/app');
-
-jest.mock('~/server/services/UserService', () => ({
-  getUserKey: jest.fn(),
-  getUserKeyExpiry: jest.fn(),
-  getUserKeyValues: jest.fn(),
-  checkUserKeyExpiry: jest.requireActual('~/server/services/UserService').checkUserKeyExpiry,
-}));
-
-const today = new Date();
-const tenDaysFromToday = new Date(today.setDate(today.getDate() + 10));
-const isoString = tenDaysFromToday.toISOString();
-
-describe('initializeClient', () => {
-  // Set up environment variables
-  const originalEnvironment = process.env;
-  const app = {
-    locals: {},
-  };
-
-  beforeEach(() => {
-    jest.resetModules(); // Clears the cache
-    process.env = { ...originalEnvironment }; // Make a copy
-  });
-
-  afterAll(() => {
-    process.env = originalEnvironment; // Restore original env vars
-  });
-
-  test('initializes OpenAI client with default API key and URL', async () => {
-    process.env.ASSISTANTS_API_KEY = 'default-api-key';
-    process.env.ASSISTANTS_BASE_URL = 'https://default.api.url';
-
-    // Assuming 'isUserProvided' to return false for this test case
-    jest.mock('~/server/utils', () => ({
-      isUserProvided: jest.fn().mockReturnValueOnce(false),
-    }));
-
-    const req = { user: { id: 'user123' }, app };
-    const res = {};
-
-    const { openai, openAIApiKey } = await initializeClient({ req, res });
-    expect(openai.apiKey).toBe('default-api-key');
-    expect(openAIApiKey).toBe('default-api-key');
-    expect(openai.baseURL).toBe('https://default.api.url');
-  });
-
-  test('initializes OpenAI client with user-provided API key and URL', async () => {
-    process.env.ASSISTANTS_API_KEY = 'user_provided';
-    process.env.ASSISTANTS_BASE_URL = 'user_provided';
-
-    getUserKeyValues.mockResolvedValue({ apiKey: 'user-api-key', baseURL: 'https://user.api.url' });
-    getUserKeyExpiry.mockResolvedValue(isoString);
-
-    const req = { user: { id: 'user123' }, app };
-    const res = {};
-
-    const { openai, openAIApiKey } = await initializeClient({ req, res });
-    expect(openAIApiKey).toBe('user-api-key');
-    expect(openai.apiKey).toBe('user-api-key');
-    expect(openai.baseURL).toBe('https://user.api.url');
-  });
-
-  test('throws error for invalid JSON in user-provided values', async () => {
-    process.env.ASSISTANTS_API_KEY = 'user_provided';
-    getUserKey.mockResolvedValue('invalid-json');
-    getUserKeyExpiry.mockResolvedValue(isoString);
-    getUserKeyValues.mockImplementation(() => {
-      let userValues = getUserKey();
-      try {
-        userValues = JSON.parse(userValues);
-      } catch (e) {
-        throw new Error(
-          JSON.stringify({
-            type: ErrorTypes.INVALID_USER_KEY,
-          }),
-        );
-      }
-      return userValues;
-    });
-
-    const req = { user: { id: 'user123' } };
-    const res = {};
-
-    await expect(initializeClient({ req, res })).rejects.toThrow(/invalid_user_key/);
-  });
-
-  test('throws error if API key is not provided', async () => {
-    delete process.env.ASSISTANTS_API_KEY; // Simulate missing API key
-
-    const req = { user: { id: 'user123' }, app };
-    const res = {};
-
-    await expect(initializeClient({ req, res })).rejects.toThrow(/Assistants API key not/);
-  });
-
-  test('initializes OpenAI client with proxy configuration', async () => {
-    process.env.ASSISTANTS_API_KEY = 'test-key';
-    process.env.PROXY = 'http://proxy.server';
-
-    const req = { user: { id: 'user123' }, app };
-    const res = {};
-
-    const { openai } = await initializeClient({ req, res });
-    expect(openai.fetchOptions).toBeDefined();
-    expect(openai.fetchOptions.dispatcher).toBeInstanceOf(ProxyAgent);
-  });
-});

api/server/services/Endpoints/assistants/title.js

@@ -1,32 +1,84 @@
-const { isEnabled } = require('@librechat/api');
+const { isEnabled, sanitizeTitle } = require('@librechat/api');
+const { logger } = require('@librechat/data-schemas');
 const { CacheKeys } = require('librechat-data-provider');
 const { saveConvo } = require('~/models/Conversation');
 const getLogStores = require('~/cache/getLogStores');
+const initializeClient = require('./initalize');
 
-const addTitle = async (req, { text, responseText, conversationId, client }) => {
+/**
+ * Generates a conversation title using OpenAI SDK
+ * @param {Object} params
+ * @param {OpenAI} params.openai - The OpenAI SDK client instance
+ * @param {string} params.text - User's message text
+ * @param {string} params.responseText - Assistant's response text
+ * @returns {Promise<string>}
+ */
+const generateTitle = async ({ openai, text, responseText }) => {
+  const titlePrompt = `Please generate a concise title (max 40 characters) for a conversation that starts with:
+User: ${text}
+Assistant: ${responseText}
+
+Title:`;
+
+  const completion = await openai.chat.completions.create({
+    model: 'gpt-3.5-turbo',
+    messages: [
+      {
+        role: 'user',
+        content: titlePrompt,
+      },
+    ],
+    temperature: 0.7,
+    max_tokens: 20,
+  });
+
+  const title = completion.choices[0]?.message?.content?.trim() || 'New conversation';
+  return sanitizeTitle(title);
+};
+
+/**
+ * Adds a title to a conversation asynchronously
+ * @param {ServerRequest} req
+ * @param {Object} params
+ * @param {string} params.text - User's message text
+ * @param {string} params.responseText - Assistant's response text
+ * @param {string} params.conversationId - Conversation ID
+ */
+const addTitle = async (req, { text, responseText, conversationId }) => {
   const { TITLE_CONVO = 'true' } = process.env ?? {};
   if (!isEnabled(TITLE_CONVO)) {
     return;
   }
 
-  if (client.options.titleConvo === false) {
-    return;
-  }
-
   const titleCache = getLogStores(CacheKeys.GEN_TITLE);
   const key = `${req.user.id}-${conversationId}`;
 
-  const title = await client.titleConvo({ text, conversationId, responseText });
-  await titleCache.set(key, title, 120000);
+  try {
+    const { openai } = await initializeClient({ req });
+    const title = await generateTitle({ openai, text, responseText });
+    await titleCache.set(key, title, 120000);
 
-  await saveConvo(
-    req,
-    {
-      conversationId,
-      title,
-    },
-    { context: 'api/server/services/Endpoints/assistants/addTitle.js' },
-  );
+    await saveConvo(
+      req,
+      {
+        conversationId,
+        title,
+      },
+      { context: 'api/server/services/Endpoints/assistants/addTitle.js' },
+    );
+  } catch (error) {
+    logger.error('[addTitle] Error generating title:', error);
+    const fallbackTitle = text.length > 40 ? text.substring(0, 37) + '...' : text;
+    await titleCache.set(key, fallbackTitle, 120000);
+    await saveConvo(
+      req,
+      {
+        conversationId,
+        title: fallbackTitle,
+      },
+      { context: 'api/server/services/Endpoints/assistants/addTitle.js' },
+    );
+  }
 };
 
 module.exports = addTitle;