From 5e70d518aaafe9ca7954029bfc6152b7296a26f5 Mon Sep 17 00:00:00 2001 From: Danny Avila Date: Mon, 18 Aug 2025 02:31:08 -0400 Subject: [PATCH] refactor: update imports to use normalizeEndpointName from @librechat/api and remove redundant definitions --- api/server/services/Config/getCustomConfig.js | 3 +-- api/server/services/Config/loadConfigEndpoints.js | 2 +- api/server/services/Config/loadConfigModels.js | 2 +- api/server/services/start/modelSpecs.js | 4 ++-- api/server/utils/handleText.js | 11 ----------- packages/api/src/utils/common.ts | 13 ++++++++++++- 6 files changed, 17 insertions(+), 18 deletions(-) diff --git a/api/server/services/Config/getCustomConfig.js b/api/server/services/Config/getCustomConfig.js index 2b9f658b48..a66cf664b2 100644 --- a/api/server/services/Config/getCustomConfig.js +++ b/api/server/services/Config/getCustomConfig.js @@ -1,7 +1,6 @@ const { logger } = require('@librechat/data-schemas'); -const { isEnabled, getUserMCPAuthMap } = require('@librechat/api'); +const { isEnabled, getUserMCPAuthMap, normalizeEndpointName } = require('@librechat/api'); const { CacheKeys, EModelEndpoint } = require('librechat-data-provider'); -const { normalizeEndpointName } = require('~/server/utils'); const loadCustomConfig = require('./loadCustomConfig'); const getLogStores = require('~/cache/getLogStores'); diff --git a/api/server/services/Config/loadConfigEndpoints.js b/api/server/services/Config/loadConfigEndpoints.js index fca770e2ed..b50c55766e 100644 --- a/api/server/services/Config/loadConfigEndpoints.js +++ b/api/server/services/Config/loadConfigEndpoints.js @@ -1,5 +1,5 @@ +const { isUserProvided, normalizeEndpointName } = require('@librechat/api'); const { EModelEndpoint, extractEnvVariable } = require('librechat-data-provider'); -const { isUserProvided, normalizeEndpointName } = require('~/server/utils'); const { getCustomConfig } = require('./getCustomConfig'); const { getAppConfig } = require('./app'); diff --git a/api/server/services/Config/loadConfigModels.js b/api/server/services/Config/loadConfigModels.js index 895e0129b2..82561a5062 100644 --- a/api/server/services/Config/loadConfigModels.js +++ b/api/server/services/Config/loadConfigModels.js @@ -1,5 +1,5 @@ +const { isUserProvided, normalizeEndpointName } = require('@librechat/api'); const { EModelEndpoint, extractEnvVariable } = require('librechat-data-provider'); -const { isUserProvided, normalizeEndpointName } = require('~/server/utils'); const { fetchModels } = require('~/server/services/ModelService'); const { getCustomConfig } = require('./getCustomConfig'); const { getAppConfig } = require('./app'); diff --git a/api/server/services/start/modelSpecs.js b/api/server/services/start/modelSpecs.js index 4adc89cc3a..057255010f 100644 --- a/api/server/services/start/modelSpecs.js +++ b/api/server/services/start/modelSpecs.js @@ -1,6 +1,6 @@ +const { logger } = require('@librechat/data-schemas'); +const { normalizeEndpointName } = require('@librechat/api'); const { EModelEndpoint } = require('librechat-data-provider'); -const { normalizeEndpointName } = require('~/server/utils'); -const { logger } = require('~/config'); /** * Sets up Model Specs from the config (`librechat.yaml`) file. diff --git a/api/server/utils/handleText.js b/api/server/utils/handleText.js index 36671c44ff..91c2ff25ec 100644 --- a/api/server/utils/handleText.js +++ b/api/server/utils/handleText.js @@ -8,7 +8,6 @@ const { defaultAgentCapabilities, } = require('librechat-data-provider'); const { sendEvent } = require('@librechat/api'); -const { Providers } = require('@librechat/agents'); const partialRight = require('lodash/partialRight'); /** Helper function to escape special characters in regex @@ -207,15 +206,6 @@ function generateConfig(key, baseURL, endpoint) { return config; } -/** - * Normalize the endpoint name to system-expected value. - * @param {string} name - * @returns {string} - */ -function normalizeEndpointName(name = '') { - return name.toLowerCase() === Providers.OLLAMA ? Providers.OLLAMA : name; -} - module.exports = { isEnabled, handleText, @@ -226,5 +216,4 @@ module.exports = { generateConfig, addSpaceIfNeeded, createOnProgress, - normalizeEndpointName, }; diff --git a/packages/api/src/utils/common.ts b/packages/api/src/utils/common.ts index 693c00d487..f82e8dd218 100644 --- a/packages/api/src/utils/common.ts +++ b/packages/api/src/utils/common.ts @@ -1,3 +1,6 @@ +import { Providers } from '@librechat/agents'; +import { AuthType } from 'librechat-data-provider'; + /** * Checks if the given value is truthy by being either the boolean `true` or a string * that case-insensitively matches 'true'. @@ -31,7 +34,7 @@ export function isEnabled(value?: string | boolean | null | undefined): boolean * @param value - The value to check. * @returns - Returns true if the value is 'user_provided', otherwise false. */ -export const isUserProvided = (value?: string): boolean => value === 'user_provided'; +export const isUserProvided = (value?: string): boolean => value === AuthType.USER_PROVIDED; /** * @param values @@ -46,3 +49,11 @@ export function optionalChainWithEmptyCheck( } return values[values.length - 1]; } + +/** + * Normalize the endpoint name to system-expected value. + * @param name + */ +export function normalizeEndpointName(name = ''): string { + return name.toLowerCase() === Providers.OLLAMA ? Providers.OLLAMA : name; +}