From 5e6f8cbce7ed98d7bc14b0048bffe619d593fdd6 Mon Sep 17 00:00:00 2001 From: Danny Avila <110412045+danny-avila@users.noreply.github.com> Date: Wed, 22 Nov 2023 18:29:09 -0500 Subject: [PATCH] =?UTF-8?q?fix:=20Correct=20Default=20Model=20Name=20in=20?= =?UTF-8?q?Response=20Sender=20and=20Update=20Anthropics=20=F0=9F=A4=96=20?= =?UTF-8?q?(#1208)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * feat: add claude-2.1 to default anthropic models * chore: remove console log in NavLinks * fix: issue with response sender not using model name, change anthropic default value to Claude * fix: preset will not be selected on edit --- api/server/routes/endpoints/schemas.js | 2 +- api/server/services/ModelService.js | 3 ++- client/src/components/Chat/Menus/Presets/PresetItems.tsx | 1 + client/src/components/Nav/NavLinks.tsx | 2 -- client/src/hooks/useChatHelpers.ts | 2 +- packages/data-provider/src/schemas.ts | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/api/server/routes/endpoints/schemas.js b/api/server/routes/endpoints/schemas.js index 0be3987db6..84ad36b330 100644 --- a/api/server/routes/endpoints/schemas.js +++ b/api/server/routes/endpoints/schemas.js @@ -381,7 +381,7 @@ const getResponseSender = (endpointOption) => { } if (endpoint === EModelEndpoint.anthropic) { - return modelLabel ?? 'Anthropic'; + return modelLabel ?? 'Claude'; } if (endpoint === EModelEndpoint.google) { diff --git a/api/server/services/ModelService.js b/api/server/services/ModelService.js index 7a2917832a..086e8b7396 100644 --- a/api/server/services/ModelService.js +++ b/api/server/services/ModelService.js @@ -115,11 +115,12 @@ const getChatGPTBrowserModels = () => { const getAnthropicModels = () => { let models = [ + 'claude-2.1', + 'claude-2', 'claude-1', 'claude-1-100k', 'claude-instant-1', 'claude-instant-1-100k', - 'claude-2', ]; if (ANTHROPIC_MODELS) { models = String(ANTHROPIC_MODELS).split(','); diff --git a/client/src/components/Chat/Menus/Presets/PresetItems.tsx b/client/src/components/Chat/Menus/Presets/PresetItems.tsx index e2881d40b0..50f583d76e 100644 --- a/client/src/components/Chat/Menus/Presets/PresetItems.tsx +++ b/client/src/components/Chat/Menus/Presets/PresetItems.tsx @@ -98,6 +98,7 @@ const PresetItems: FC<{ className="m-0 h-full rounded-md p-2 px-4 text-gray-400 hover:text-gray-700 dark:bg-gray-700 dark:text-gray-400 dark:hover:text-gray-200 sm:invisible sm:group-hover:visible" onClick={(e) => { e.preventDefault(); + e.stopPropagation(); onChangePreset(preset); }} > diff --git a/client/src/components/Nav/NavLinks.tsx b/client/src/components/Nav/NavLinks.tsx index 5bda65921e..386cd918e5 100644 --- a/client/src/components/Nav/NavLinks.tsx +++ b/client/src/components/Nav/NavLinks.tsx @@ -41,8 +41,6 @@ function NavLinks() { conversation.conversationId !== 'new' && conversation.conversationId !== 'search'; - console.log('NavLinks', conversation, exportable); - const clickHandler = () => { if (exportable) { setShowExports(true); diff --git a/client/src/hooks/useChatHelpers.ts b/client/src/hooks/useChatHelpers.ts index 2437282bcc..3eb8f857d2 100644 --- a/client/src/hooks/useChatHelpers.ts +++ b/client/src/hooks/useChatHelpers.ts @@ -157,7 +157,7 @@ export default function useChatHelpers(index = 0, paramId: string | undefined) { endpoint, key: getExpiry(), } as TEndpointOption; - const responseSender = getResponseSender(endpointOption); + const responseSender = getResponseSender({ model: conversation?.model, ...endpointOption }); let currentMessages: TMessage[] | null = getMessages() ?? []; diff --git a/packages/data-provider/src/schemas.ts b/packages/data-provider/src/schemas.ts index 38ccad17d8..41ba554b32 100644 --- a/packages/data-provider/src/schemas.ts +++ b/packages/data-provider/src/schemas.ts @@ -533,7 +533,7 @@ export const getResponseSender = (endpointOption: TEndpointOption): string => { } if (endpoint === EModelEndpoint.anthropic) { - return modelLabel ?? 'Anthropic'; + return modelLabel ?? 'Claude'; } if (endpoint === EModelEndpoint.google) {